pgsql: Update outdated comment in ApplyRetrieveRule

2022-12-07 Thread Alvaro Herrera
Update outdated comment in ApplyRetrieveRule After a61b1f74823c. Author: Amit Langote Discussion: https://postgr.es/m/CA+HiwqGZm7hb2VAy8HGM22-fTDaQzqE6T=5GbAk=gkt9h0h...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/29861e228a47c3b6c292f1bd4da413

pgsql: Fix FK comment think-o

2022-12-07 Thread Peter Eisentraut
Fix FK comment think-o from commit d6f96ed94e7 Author: Paul Jungwirth Reviewed-by: Ian Lawrence Barwick Discussion: https://www.postgresql.org/message-id/flat/6a7c7338-1aa2-4689-d171-0b0b294fdd84%40illuminatedcomputing.com Branch -- master Details --- https://git.postgresql.org/pg/co

pgsql: Fix FK comment think-o

2022-12-07 Thread Peter Eisentraut
Fix FK comment think-o from commit d6f96ed94e7 Author: Paul Jungwirth Reviewed-by: Ian Lawrence Barwick Discussion: https://www.postgresql.org/message-id/flat/6a7c7338-1aa2-4689-d171-0b0b294fdd84%40illuminatedcomputing.com Branch -- REL_15_STABLE Details --- https://git.postgresql.or

pgsql: Doc: subdivide System Information Functions and Operators.

2022-12-07 Thread Tom Lane
Doc: subdivide System Information Functions and Operators. Provide subdivisions in 9.26 System Information Functions and Operators. This is useful because it adds a mini-TOC at the top of the page to aid jumping to portions of what's become quite a long section. Also, now that several of the su

pgsql: Minor code refactoring in elog.c (no functional change).

2022-12-07 Thread Tom Lane
Minor code refactoring in elog.c (no functional change). Combine some duplicated code stanzas by creating small functions. Most of these duplications arose at a time when I wouldn't have trusted C compilers to auto-inline small functions intelligently, but they're probably poor practice now. Simi

pgsql: meson: Add 'running' test setup, as a replacement for installche

2022-12-07 Thread Andres Freund
meson: Add 'running' test setup, as a replacement for installcheck To run all tests that support running against existing server: $ meson test --setup running To run just the main pg_regress tests against existing server: $ meson test --setup running regress-running/regress To ensure the 'runnin

pgsql: Avoid unnecessary streaming of transactions during logical repli

2022-12-07 Thread Amit Kapila
Avoid unnecessary streaming of transactions during logical replication. After restart, we don't perform streaming of an in-progress transaction if it was previously decoded and confirmed by the client. To achieve that we were comparing the END location of the WAL record being decoded with the WAL

pgsql: Add option to specify segment size in blocks

2022-12-07 Thread Andres Freund
Add option to specify segment size in blocks The tests don't have much coverage of segment related code, as we don't create large enough tables. To make it easier to test these paths, add a new option specifying the segment size in blocks. Set the new option to 6 blocks in one of the CI tasks. Sm

pgsql: Remove new structure member from ResultRelInfo.

2022-12-07 Thread Etsuro Fujita
Remove new structure member from ResultRelInfo. In commit ffbb7e65a, I added a ModifyTableState member to ResultRelInfo to save the owning ModifyTableState for use by nodeModifyTable.c when performing batch inserts, but as pointed out by Tom Lane, that changed the array stride of es_result_relatio

pgsql: Remove new structure member from ResultRelInfo.

2022-12-07 Thread Etsuro Fujita
Remove new structure member from ResultRelInfo. In commit ffbb7e65a, I added a ModifyTableState member to ResultRelInfo to save the owning ModifyTableState for use by nodeModifyTable.c when performing batch inserts, but as pointed out by Tom Lane, that changed the array stride of es_result_relatio

pgsql: Remove new structure member from ResultRelInfo.

2022-12-07 Thread Etsuro Fujita
Remove new structure member from ResultRelInfo. In commit ffbb7e65a, I added a ModifyTableState member to ResultRelInfo to save the owning ModifyTableState for use by nodeModifyTable.c when performing batch inserts, but as pointed out by Tom Lane, that changed the array stride of es_result_relatio