Re: pgsql: postgres_fdw: Fix assertion in estimate_path_cost_size().

2022-12-14 Thread Etsuro Fujita
Hi Robins, On Mon, Dec 12, 2022 at 9:29 PM Robins Tharakan wrote: > I think this bugfix needs to be backpatched to v12 too. > > See backtrace / repro SQL here - > https://www.postgresql.org/message-id/17713-92cce66de7e81c04%40postgresql.org I misunderstood that the mentioned commit was added in

pgsql: Rearrange some static assertions for consistency

2022-12-14 Thread Peter Eisentraut
Rearrange some static assertions for consistency Put lengthof first. Reported-by: Peter Smith Discussion: https://www.postgresql.org/message-id/CAHut+PsUDMySVRuRc=h+P5N3+=tgvj4w_mi32xxg9dt4o-b...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b18c

pgsql: Convert a few more datatype input functions to report errors sof

2022-12-14 Thread Tom Lane
Convert a few more datatype input functions to report errors softly. Convert bit_in, varbit_in, inet_in, cidr_in, macaddr_in, and macaddr8_in to the new style. Amul Sul, minor mods by me Discussion: https://postgr.es/m/caaj_b97kedwudptkgoafypv0oicjou6ew+qywj-ywrgj_ae...@mail.gmail.com Branch -

pgsql: Convert the geometric input functions to report errors softly.

2022-12-14 Thread Tom Lane
Convert the geometric input functions to report errors softly. Convert box_in, circle_in, line_in, lseg_in, path_in, point_in, and poly_in to the new style. line_in still throws hard errors for overflows/underflows that can occur when the input is specified as two points rather than in the canoni

pgsql: Convert a few more datatype input functions to report errors sof

2022-12-14 Thread Tom Lane
Convert a few more datatype input functions to report errors softly. Convert assorted internal-ish datatypes, namely aclitemin, int2vectorin, oidin, oidvectorin, pg_lsn_in, pg_snapshot_in, and tidin to the new style. (Some others you might expect to find in this group, such as cidin and xidin, ne

pgsql: Convert a few more datatype input functions to report errors sof

2022-12-14 Thread Tom Lane
Convert a few more datatype input functions to report errors softly. Convert cash_in and uuid_in to the new style. Amul Sul, minor mods by me Discussion: https://postgr.es/m/caaj_b97kedwudptkgoafypv0oicjou6ew+qywj-ywrgj_ae...@mail.gmail.com Branch -- master Details --- https://git.pos

pgsql: Convert a few more datatype input functions to report errors sof

2022-12-14 Thread Tom Lane
Convert a few more datatype input functions to report errors softly. Convert the remaining string-category input functions (bpcharin, varcharin, byteain) to the new style. Discussion: https://postgr.es/m/3038346.1671060...@sss.pgh.pa.us Branch -- master Details --- https://git.postgresq

pgsql: Move provariadic sanity check to a more appropriate place

2022-12-14 Thread Peter Eisentraut
Move provariadic sanity check to a more appropriate place 35f059e9bdfb3b14ac9d22a9e159d36ec0ccf804 put the provariadic sanity check into type_sanity.sql, even though it's not about types, and moreover in the middle of some connected test group, which makes it all very confusing. Move it to opr_sa