pgsql: Fix bug in translate_col_privs_multilevel

2022-12-23 Thread David Rowley
Fix bug in translate_col_privs_multilevel Fix incorrect code which was trying to convert a Bitmapset of columns at the attnums according to a parent table and transform them into the equivalent Bitmapset with same attnums according to the given child table. This code is new as of a61b1f748 and was

pgsql: Fix event trigger example

2022-12-23 Thread Alvaro Herrera
Fix event trigger example Commit 2f9661311b changed command tags from strings to numbers, but forgot to adjust the code in the event trigger example, which consequently failed to compile. While fixing that, improve the indentation to adhere to pgindent style. Backpatch to v13, where the change w

pgsql: Fix event trigger example

2022-12-23 Thread Alvaro Herrera
Fix event trigger example Commit 2f9661311b changed command tags from strings to numbers, but forgot to adjust the code in the event trigger example, which consequently failed to compile. While fixing that, improve the indentation to adhere to pgindent style. Backpatch to v13, where the change w

pgsql: Fix event trigger example

2022-12-23 Thread Alvaro Herrera
Fix event trigger example Commit 2f9661311b changed command tags from strings to numbers, but forgot to adjust the code in the event trigger example, which consequently failed to compile. While fixing that, improve the indentation to adhere to pgindent style. Backpatch to v13, where the change w

pgsql: Fix event trigger example

2022-12-23 Thread Alvaro Herrera
Fix event trigger example Commit 2f9661311b changed command tags from strings to numbers, but forgot to adjust the code in the event trigger example, which consequently failed to compile. While fixing that, improve the indentation to adhere to pgindent style. Backpatch to v13, where the change w

pgsql: Convert contrib/seg's input function to report errors softly

2022-12-23 Thread Andrew Dunstan
Convert contrib/seg's input function to report errors softly Reviewed by Tom Lane Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/878ce16056c087e2dcd7cc31cd7e4700f407a770 Modified F

pgsql: Fix end LSN determination in recently added test

2022-12-23 Thread Alvaro Herrera
Fix end LSN determination in recently added test The test added in commit e44dae07f931 has a thinko: it wants to read info about a few WAL records, but it obtains the LSN of the final record to read by asking for the WAL insert position; however, pg_get_wal_records_info only accepts to read up to

pgsql: Fix end LSN determination in recently added test

2022-12-23 Thread Alvaro Herrera
Fix end LSN determination in recently added test The test added in commit e44dae07f931 has a thinko: it wants to read info about a few WAL records, but it obtains the LSN of the final record to read by asking for the WAL insert position; however, pg_get_wal_records_info only accepts to read up to

pgsql: Rework box about column list combining in logical repl

2022-12-23 Thread Alvaro Herrera
Rework box about column list combining in logical replication After some copy-edit I made in commit 3a06a79cd137, we have a that only contains a warning box. This doesn't look good. Rework by moving the sect2 title to be the warning's title, and put the 'id' to it as well, so that the external

pgsql: Rework box about column list combining in logical repl

2022-12-23 Thread Alvaro Herrera
Rework box about column list combining in logical replication After some copy-edit I made in commit 3a06a79cd137, we have a that only contains a warning box. This doesn't look good. Rework by moving the sect2 title to be the warning's title, and put the 'id' to it as well, so that the external

pgsql: Fix recent accidental omission in pg_proc.dat

2022-12-23 Thread David Rowley
Fix recent accidental omission in pg_proc.dat ed1a88dda added support functions for the ntile(), percent_rank() and cume_dist() window functions but neglected to actually add these support functions to the pg_proc entry for the corresponding window function. Also, take this opportunity to add the