pgsql: Clean up MergeAttributesIntoExisting()

Clean up MergeAttributesIntoExisting() Make variable naming clearer and more consistent. Move some variables to smaller scope. Remove some unnecessary intermediate variables. Try to save some vertical space. Apply analogous changes to nearby MergeConstraintsIntoExisting() and RemoveInheritance(

pgsql: Add some const qualifiers

Add some const qualifiers There was a mismatch between the const qualifiers for excludeDirContents in src/backend/backup/basebackup.c and src/bin/pg_rewind/filemap.c, which led to a quick search for similar cases. We should make excludeDirContents match, but the rest of the changes seem like a go

pgsql: Fix another bug in parent page splitting during GiST index build

Fix another bug in parent page splitting during GiST index build. Yet another bug in the ilk of commits a7ee7c851 and 741b88435. In 741b88435, we took care to clear the memorized location of the downlink when we split the parent page, because splitting the parent page can move the downlink. But we

pgsql: Fix another bug in parent page splitting during GiST index build

Fix another bug in parent page splitting during GiST index build. Yet another bug in the ilk of commits a7ee7c851 and 741b88435. In 741b88435, we took care to clear the memorized location of the downlink when we split the parent page, because splitting the parent page can move the downlink. But we

pgsql: Fix another bug in parent page splitting during GiST index build

Fix another bug in parent page splitting during GiST index build. Yet another bug in the ilk of commits a7ee7c851 and 741b88435. In 741b88435, we took care to clear the memorized location of the downlink when we split the parent page, because splitting the parent page can move the downlink. But we

pgsql: Fix another bug in parent page splitting during GiST index build

Fix another bug in parent page splitting during GiST index build. Yet another bug in the ilk of commits a7ee7c851 and 741b88435. In 741b88435, we took care to clear the memorized location of the downlink when we split the parent page, because splitting the parent page can move the downlink. But we

pgsql: Fix another bug in parent page splitting during GiST index build

Fix another bug in parent page splitting during GiST index build. Yet another bug in the ilk of commits a7ee7c851 and 741b88435. In 741b88435, we took care to clear the memorized location of the downlink when we split the parent page, because splitting the parent page can move the downlink. But we

pgsql: Fix another bug in parent page splitting during GiST index build

Fix another bug in parent page splitting during GiST index build. Yet another bug in the ilk of commits a7ee7c851 and 741b88435. In 741b88435, we took care to clear the memorized location of the downlink when we split the parent page, because splitting the parent page can move the downlink. But we

pgsql: Clean up MergeCheckConstraint()

Clean up MergeCheckConstraint() If the constraint is not already in the list, add it ourselves, instead of making the caller do it. This makes the interface more consistent with other "merge" functions in this file. Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-

pgsql: MergeAttributes() and related variable renaming

MergeAttributes() and related variable renaming Mainly, rename "schema" to "columns" and related changes. The previous naming has long been confusing. Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da%40eisentraut.org Branch -- master Details

pgsql: doc: PG 16 relnotes: clarify "relation" segsize mention

doc: PG 16 relnotes: clarify "relation" segsize mention Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 16 only Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e391939b76f941544fdb

pgsql: doc: correct reference to pg_relation in comment

doc: correct reference to pg_relation in comment Reported-by: Dagfinn Ilmari Mannsåker Discussion: https://postgr.es/m/[email protected] Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/441bbd29fe751a01b6c74cc53f2e7b223

pgsql: pgbench: Improve help output of -I option

pgbench: Improve help output of -I option Add a description of the step letters to the --help output. Author: Gurjeet Singh Reviewed-by: Tristen Raab Discussion: https://www.postgresql.org/message-id/flat/CABwTF4Xbc=K4tFj5Znc8jx0GCufQa577GCDsWD7=71qdnue...@mail.gmail.com Branch -- master

pgsql: doc: mention GROUP BY columns can reference target col numbers

doc: mention GROUP BY columns can reference target col numbers Reported-by: hape Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/17cd48d

pgsql: doc: mention GROUP BY columns can reference target col numbers

doc: mention GROUP BY columns can reference target col numbers Reported-by: hape Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/28919a0

pgsql: doc: mention GROUP BY columns can reference target col numbers

doc: mention GROUP BY columns can reference target col numbers Reported-by: hape Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1b5a00450acb34

pgsql: doc: mention GROUP BY columns can reference target col numbers

doc: mention GROUP BY columns can reference target col numbers Reported-by: hape Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e1ae79b

pgsql: doc: mention GROUP BY columns can reference target col numbers

doc: mention GROUP BY columns can reference target col numbers Reported-by: hape Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9ac7fa2

pgsql: doc: mention GROUP BY columns can reference target col numbers

doc: mention GROUP BY columns can reference target col numbers Reported-by: hape Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3d398ae

pgsql: doc: mention GROUP BY columns can reference target col numbers

doc: mention GROUP BY columns can reference target col numbers Reported-by: hape Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3a9a1b8

pgsql: pgrowlocks: change lock mode output labels for consistency

pgrowlocks: change lock mode output labels for consistency Change "Share" to "For Share" and "Key Share" to "For Key Share" for consistency with other lock mode labels. BACKWARD COMPATIBILITY BREAK Reported-by: David Cook Discussion: https://postgr.es/m/CA+dNBPNBf+FCEwohe7SH1tSks0R_G4F=tuvM=

pgsql: doc: pg_upgrade, clarify standby servers must remain running

doc: pg_upgrade, clarify standby servers must remain running Also mention that mismatching primary/standby LSNs should never happen. Reported-by: Nikolay Samokhvalov Discussion: https://postgr.es/m/cam527d8heqkjg5vrvju3xjsqxg41ufuyabd9qzccdaxnpbr...@mail.gmail.com Backpatch-through: 11 Branch

pgsql: doc: pg_upgrade, clarify standby servers must remain running

doc: pg_upgrade, clarify standby servers must remain running Also mention that mismatching primary/standby LSNs should never happen. Reported-by: Nikolay Samokhvalov Discussion: https://postgr.es/m/cam527d8heqkjg5vrvju3xjsqxg41ufuyabd9qzccdaxnpbr...@mail.gmail.com Backpatch-through: 11 Branch

pgsql: doc: pg_upgrade, clarify standby servers must remain running

doc: pg_upgrade, clarify standby servers must remain running Also mention that mismatching primary/standby LSNs should never happen. Reported-by: Nikolay Samokhvalov Discussion: https://postgr.es/m/cam527d8heqkjg5vrvju3xjsqxg41ufuyabd9qzccdaxnpbr...@mail.gmail.com Backpatch-through: 11 Branch

pgsql: doc: pg_upgrade, clarify standby servers must remain running

doc: pg_upgrade, clarify standby servers must remain running Also mention that mismatching primary/standby LSNs should never happen. Reported-by: Nikolay Samokhvalov Discussion: https://postgr.es/m/cam527d8heqkjg5vrvju3xjsqxg41ufuyabd9qzccdaxnpbr...@mail.gmail.com Backpatch-through: 11 Branch

pgsql: doc: pg_upgrade, clarify standby servers must remain running

doc: pg_upgrade, clarify standby servers must remain running Also mention that mismatching primary/standby LSNs should never happen. Reported-by: Nikolay Samokhvalov Discussion: https://postgr.es/m/cam527d8heqkjg5vrvju3xjsqxg41ufuyabd9qzccdaxnpbr...@mail.gmail.com Backpatch-through: 11 Branch

pgsql: doc: pg_upgrade, clarify standby servers must remain running

doc: pg_upgrade, clarify standby servers must remain running Also mention that mismatching primary/standby LSNs should never happen. Reported-by: Nikolay Samokhvalov Discussion: https://postgr.es/m/cam527d8heqkjg5vrvju3xjsqxg41ufuyabd9qzccdaxnpbr...@mail.gmail.com Backpatch-through: 11 Branch

pgsql: doc: pg_upgrade, clarify standby servers must remain running

doc: pg_upgrade, clarify standby servers must remain running Also mention that mismatching primary/standby LSNs should never happen. Reported-by: Nikolay Samokhvalov Discussion: https://postgr.es/m/cam527d8heqkjg5vrvju3xjsqxg41ufuyabd9qzccdaxnpbr...@mail.gmail.com Backpatch-through: 11 Branch

pgsql: doc: clarify the behavior of unopenable listen_addresses

doc: clarify the behavior of unopenable listen_addresses Reported-by: Gurjeet Singh Discussion: https://postgr.es/m/cabwtf4wypd9ov-kcsq1+j+zj5wydqlxquy6lu2cvb-y7ptp...@mail.gmail.com Backpatch-through: 11 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3fea85469

pgsql: doc: clarify the behavior of unopenable listen_addresses

doc: clarify the behavior of unopenable listen_addresses Reported-by: Gurjeet Singh Discussion: https://postgr.es/m/cabwtf4wypd9ov-kcsq1+j+zj5wydqlxquy6lu2cvb-y7ptp...@mail.gmail.com Backpatch-through: 11 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/cf

pgsql: doc: clarify the behavior of unopenable listen_addresses

doc: clarify the behavior of unopenable listen_addresses Reported-by: Gurjeet Singh Discussion: https://postgr.es/m/cabwtf4wypd9ov-kcsq1+j+zj5wydqlxquy6lu2cvb-y7ptp...@mail.gmail.com Backpatch-through: 11 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7c

pgsql: doc: clarify the behavior of unopenable listen_addresses

doc: clarify the behavior of unopenable listen_addresses Reported-by: Gurjeet Singh Discussion: https://postgr.es/m/cabwtf4wypd9ov-kcsq1+j+zj5wydqlxquy6lu2cvb-y7ptp...@mail.gmail.com Backpatch-through: 11 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/14

pgsql: doc: clarify the behavior of unopenable listen_addresses

doc: clarify the behavior of unopenable listen_addresses Reported-by: Gurjeet Singh Discussion: https://postgr.es/m/cabwtf4wypd9ov-kcsq1+j+zj5wydqlxquy6lu2cvb-y7ptp...@mail.gmail.com Backpatch-through: 11 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/aa

pgsql: doc: clarify the behavior of unopenable listen_addresses

doc: clarify the behavior of unopenable listen_addresses Reported-by: Gurjeet Singh Discussion: https://postgr.es/m/cabwtf4wypd9ov-kcsq1+j+zj5wydqlxquy6lu2cvb-y7ptp...@mail.gmail.com Backpatch-through: 11 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/95

pgsql: doc: clarify the behavior of unopenable listen_addresses

doc: clarify the behavior of unopenable listen_addresses Reported-by: Gurjeet Singh Discussion: https://postgr.es/m/cabwtf4wypd9ov-kcsq1+j+zj5wydqlxquy6lu2cvb-y7ptp...@mail.gmail.com Backpatch-through: 11 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/36

pgsql: doc: clarify handling of time zones with "time with time zone"

doc: clarify handling of time zones with "time with time zone" Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/c

pgsql: doc: clarify handling of time zones with "time with time zone"

doc: clarify handling of time zones with "time with time zone" Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/c

pgsql: doc: clarify handling of time zones with "time with time zone"

doc: clarify handling of time zones with "time with time zone" Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- master Details --- https://git.postgresql.org/pg/commitdi

pgsql: doc: clarify handling of time zones with "time with time zone"

doc: clarify handling of time zones with "time with time zone" Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/c

pgsql: doc: clarify handling of time zones with "time with time zone"

doc: clarify handling of time zones with "time with time zone" Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/c

pgsql: doc: clarify handling of time zones with "time with time zone"

doc: clarify handling of time zones with "time with time zone" Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/c

pgsql: doc: clarify handling of time zones with "time with time zone"

doc: clarify handling of time zones with "time with time zone" Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/c

pgsql: doc: clarify the effect of concurrent work_mem allocations

doc: clarify the effect of concurrent work_mem allocations Reported-by: Sami Imseih Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a4a8c0de2b8120b909510eb

pgsql: doc: clarify the effect of concurrent work_mem allocations

doc: clarify the effect of concurrent work_mem allocations Reported-by: Sami Imseih Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2ef5c5e736b8b13d777d5ec

pgsql: doc: clarify the effect of concurrent work_mem allocations

doc: clarify the effect of concurrent work_mem allocations Reported-by: Sami Imseih Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9a59ff483e2c46ad24f23d1

pgsql: doc: clarify the effect of concurrent work_mem allocations

doc: clarify the effect of concurrent work_mem allocations Reported-by: Sami Imseih Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c3f7e91a191bfce657ed27e

pgsql: doc: clarify the effect of concurrent work_mem allocations

doc: clarify the effect of concurrent work_mem allocations Reported-by: Sami Imseih Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/aa7d0b6cf954c53e9e7f446

pgsql: doc: clarify the effect of concurrent work_mem allocations

doc: clarify the effect of concurrent work_mem allocations Reported-by: Sami Imseih Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c8afad9e634979ed0ba411c

pgsql: doc: clarify the effect of concurrent work_mem allocations

doc: clarify the effect of concurrent work_mem allocations Reported-by: Sami Imseih Discussion: https://postgr.es/m/[email protected] Backpatch-through: 11 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5f567b3c35c10668f62839a4a6d111

pgsql: Stop using "-multiply_defined suppress" on macOS.

Stop using "-multiply_defined suppress" on macOS. We started to use this linker switch in commit 9df308697 of 2004-07-13, which was in the OS X 10.3 era. Apparently it's been a no-op since around OS X 10.9. Apple's most recent toolchain version actively complains about it, so it's time to get ri

pgsql: Stop using "-multiply_defined suppress" on macOS.

Stop using "-multiply_defined suppress" on macOS. We started to use this linker switch in commit 9df308697 of 2004-07-13, which was in the OS X 10.3 era. Apparently it's been a no-op since around OS X 10.9. Apple's most recent toolchain version actively complains about it, so it's time to get ri

pgsql: Stop using "-multiply_defined suppress" on macOS.

Stop using "-multiply_defined suppress" on macOS. We started to use this linker switch in commit 9df308697 of 2004-07-13, which was in the OS X 10.3 era. Apparently it's been a no-op since around OS X 10.9. Apple's most recent toolchain version actively complains about it, so it's time to get ri

pgsql: Stop using "-multiply_defined suppress" on macOS.

Stop using "-multiply_defined suppress" on macOS. We started to use this linker switch in commit 9df308697 of 2004-07-13, which was in the OS X 10.3 era. Apparently it's been a no-op since around OS X 10.9. Apple's most recent toolchain version actively complains about it, so it's time to get ri

pgsql: Stop using "-multiply_defined suppress" on macOS.

Stop using "-multiply_defined suppress" on macOS. We started to use this linker switch in commit 9df308697 of 2004-07-13, which was in the OS X 10.3 era. Apparently it's been a no-op since around OS X 10.9. Apple's most recent toolchain version actively complains about it, so it's time to get ri

pgsql: Stop using "-multiply_defined suppress" on macOS.

Stop using "-multiply_defined suppress" on macOS. We started to use this linker switch in commit 9df308697 of 2004-07-13, which was in the OS X 10.3 era. Apparently it's been a no-op since around OS X 10.9. Apple's most recent toolchain version actively complains about it, so it's time to get ri

pgsql: Stop using "-multiply_defined suppress" on macOS.

Stop using "-multiply_defined suppress" on macOS. We started to use this linker switch in commit 9df308697 of 2004-07-13, which was in the OS X 10.3 era. Apparently it's been a no-op since around OS X 10.9. Apple's most recent toolchain version actively complains about it, so it's time to get ri

pgsql: unaccent: Tweak value of PYTHON when building without Python sup

unaccent: Tweak value of PYTHON when building without Python support As coded, the module's Makefile would fail to set a value for PYTHON as it checked if the variable is defined. When compiling without --with-python, PYTHON is defined and set to an empty value, so the existing check is not able

pgsql: unaccent: Tweak value of PYTHON when building without Python sup

unaccent: Tweak value of PYTHON when building without Python support As coded, the module's Makefile would fail to set a value for PYTHON as it checked if the variable is defined. When compiling without --with-python, PYTHON is defined and set to an empty value, so the existing check is not able

pgsql: unaccent: Tweak value of PYTHON when building without Python sup

unaccent: Tweak value of PYTHON when building without Python support As coded, the module's Makefile would fail to set a value for PYTHON as it checked if the variable is defined. When compiling without --with-python, PYTHON is defined and set to an empty value, so the existing check is not able

pgsql: unaccent: Tweak value of PYTHON when building without Python sup

unaccent: Tweak value of PYTHON when building without Python support As coded, the module's Makefile would fail to set a value for PYTHON as it checked if the variable is defined. When compiling without --with-python, PYTHON is defined and set to an empty value, so the existing check is not able

pgsql: unaccent: Tweak value of PYTHON when building without Python sup

unaccent: Tweak value of PYTHON when building without Python support As coded, the module's Makefile would fail to set a value for PYTHON as it checked if the variable is defined. When compiling without --with-python, PYTHON is defined and set to an empty value, so the existing check is not able