pgsql: Remove debug_print_rel and replace usages with pprint

2023-10-08 Thread David Rowley
Remove debug_print_rel and replace usages with pprint Going by c4a1933b4, b33ef397a and 05893712c (to name just a few), it seems that maintaining debug_print_rel() is often forgotten. In the case of c4a1933b4, it was several years before anyone noticed that a path type was not handled by debug_pr

pgsql: Strip off ORDER BY/DISTINCT aggregate pathkeys in create_agg_pat

2023-10-08 Thread David Rowley
Strip off ORDER BY/DISTINCT aggregate pathkeys in create_agg_path 1349d2790 added code to adjust the PlannerInfo.group_pathkeys so that ORDER BY / DISTINCT aggregate functions could obtain pre-sorted inputs to allow faster execution. That commit forgot to adjust the pathkeys in create_agg_path().

pgsql: Strip off ORDER BY/DISTINCT aggregate pathkeys in create_agg_pat

2023-10-08 Thread David Rowley
Strip off ORDER BY/DISTINCT aggregate pathkeys in create_agg_path 1349d2790 added code to adjust the PlannerInfo.group_pathkeys so that ORDER BY / DISTINCT aggregate functions could obtain pre-sorted inputs to allow faster execution. That commit forgot to adjust the pathkeys in create_agg_path().

pgsql: Remove duplicate words in docs and code comments.

2023-10-08 Thread Amit Kapila
Remove duplicate words in docs and code comments. Additionally, add a missing "the" in a couple of places. Author: Vignesh C, Dagfinn Ilmari Mannsåker Discussion: http://postgr.es/m/CALDaNm28t+wWyPfuyqEaARS810Je=drfkapertalaejyy2c...@mail.gmail.com Branch -- master Details --- https://

pgsql: Optimize various aggregate deserialization functions

2023-10-08 Thread David Rowley
Optimize various aggregate deserialization functions The serialized representation of an internal aggregate state is a bytea value. In each deserial function, in order to "receive" the bytea value we appended it onto a short-lived StringInfoData using appendBinaryStringInfo. This was a little wa