pgsql: Revise GUC names quoting in messages again

2024-05-17 Thread Peter Eisentraut
Revise GUC names quoting in messages again After further review, we want to move in the direction of always quoting GUC names in error messages, rather than the previous (PG16) wildly mixed practice or the intermittent (mid-PG17) idea of doing this depending on how possibly confusing the GUC name

Re: pgsql: Update obsolete index scan TID comments.

2024-05-17 Thread Alexander Lakhin
Hello Peter, 12.03.2024 01:07, Peter Geoghegan wrote: Update obsolete index scan TID comments. Oversight in commit c2fe139c20. I found one more obsolete comment mentioning xs_ctup:     /* * For IndexOnlyScan, the tuple stored in ss_ScanTupleSlot may be * a vi

pgsql: A few follow-up fixes for GUC name quoting

2024-05-17 Thread Peter Eisentraut
A few follow-up fixes for GUC name quoting Fixups for 17974ec259: Some messages were missed (and some were new since the patch was originally proposed), and there was a typo introduced. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e9b7aee27283e65bd8819cd7a081dbe7

pgsql: Refuse upgrades from pre-9.0 clusters

2024-05-17 Thread Daniel Gustafsson
Refuse upgrades from pre-9.0 clusters Commit 695b4a113ab added a dependency on retrieving oldestxid from pg_control, which only exists in 9.0 and onwards, but the check for 8.4 as the oldest version was retained. Since there has been few if any complaints of 8.4 upgrades not working, fix by settin

pgsql: Refuse upgrades from pre-9.0 clusters

2024-05-17 Thread Daniel Gustafsson
Refuse upgrades from pre-9.0 clusters Commit 695b4a113ab added a dependency on retrieving oldestxid from pg_control, which only exists in 9.0 and onwards, but the check for 8.4 as the oldest version was retained. Since there has been few if any complaints of 8.4 upgrades not working, fix by settin

pgsql: Refuse upgrades from pre-9.0 clusters

2024-05-17 Thread Daniel Gustafsson
Refuse upgrades from pre-9.0 clusters Commit 695b4a113ab added a dependency on retrieving oldestxid from pg_control, which only exists in 9.0 and onwards, but the check for 8.4 as the oldest version was retained. Since there has been few if any complaints of 8.4 upgrades not working, fix by settin

pgsql: Sync typedefs.list with buildfarm, for real this time.

2024-05-17 Thread Tom Lane
Sync typedefs.list with buildfarm, for real this time. In commit da256a4a7, I manually added some typedef names to the buildfarm-generated list so as not to cause any formatting regressions compared to the prior manually-updated list. About half of the additions were injection-point-related names