Re: pgsql: Generalize hash and ordering support in amapi

2025-03-01 Thread Peter Eisentraut
On 27.02.25 23:17, Mark Dilger wrote: On Thu, Feb 27, 2025 at 8:27 AM Tom Lane > wrote: Peter Eisentraut mailto:pe...@eisentraut.org>> writes: > Generalize hash and ordering support in amapi > Stop comparing access method OID values against HASH_AM_OID

pgsql: Set amcancrosscompare to true for hash

2025-03-01 Thread Peter Eisentraut
Set amcancrosscompare to true for hash This was missed in the refactoring in patch ce62f2f2a0a, which thus created a regression. Reported-by: Tom Lane Reviewed-by: Mark Dilger Discussion: https://www.postgresql.org/message-id/flat/E1tngY6-UL-2n%40gemulon.postgresql.org Branch -- maste

pgsql: Fix pg_strtof() to not crash on NULL endptr.

2025-03-01 Thread Tom Lane
Fix pg_strtof() to not crash on NULL endptr. We had managed not to notice this simple oversight because none of our calls exercised the case --- until commit 8f427187d. That led to pg_dump crashing on any platform that uses this code (currently Cygwin and Mingw). Even though there's no immediate

pgsql: Fix pg_strtof() to not crash on NULL endptr.

2025-03-01 Thread Tom Lane
Fix pg_strtof() to not crash on NULL endptr. We had managed not to notice this simple oversight because none of our calls exercised the case --- until commit 8f427187d. That led to pg_dump crashing on any platform that uses this code (currently Cygwin and Mingw). Even though there's no immediate

pgsql: Fix pg_strtof() to not crash on NULL endptr.

2025-03-01 Thread Tom Lane
Fix pg_strtof() to not crash on NULL endptr. We had managed not to notice this simple oversight because none of our calls exercised the case --- until commit 8f427187d. That led to pg_dump crashing on any platform that uses this code (currently Cygwin and Mingw). Even though there's no immediate

pgsql: Fix pg_strtof() to not crash on NULL endptr.

2025-03-01 Thread Tom Lane
Fix pg_strtof() to not crash on NULL endptr. We had managed not to notice this simple oversight because none of our calls exercised the case --- until commit 8f427187d. That led to pg_dump crashing on any platform that uses this code (currently Cygwin and Mingw). Even though there's no immediate

pgsql: Fix pg_strtof() to not crash on NULL endptr.

2025-03-01 Thread Tom Lane
Fix pg_strtof() to not crash on NULL endptr. We had managed not to notice this simple oversight because none of our calls exercised the case --- until commit 8f427187d. That led to pg_dump crashing on any platform that uses this code (currently Cygwin and Mingw). Even though there's no immediate

pgsql: Fix pg_strtof() to not crash on NULL endptr.

2025-03-01 Thread Tom Lane
Fix pg_strtof() to not crash on NULL endptr. We had managed not to notice this simple oversight because none of our calls exercised the case --- until commit 8f427187d. That led to pg_dump crashing on any platform that uses this code (currently Cygwin and Mingw). Even though there's no immediate