pgsql: Add missing newlines to PQescapeInternal() messages pre-v16.

2025-05-01 Thread Tom Lane
Add missing newlines to PQescapeInternal() messages pre-v16. While back-patching 9f45e6a91, I neglected that the convention in pre-v16 libpq was to include a trailing newline in error message strings (since then, we add those separately). Add them now. Reported-by: Peter Eisentraut Discussion:

pgsql: Add missing newlines to PQescapeInternal() messages pre-v16.

2025-05-01 Thread Tom Lane
Add missing newlines to PQescapeInternal() messages pre-v16. While back-patching 9f45e6a91, I neglected that the convention in pre-v16 libpq was to include a trailing newline in error message strings (since then, we add those separately). Add them now. Reported-by: Peter Eisentraut Discussion:

pgsql: Add missing newlines to PQescapeInternal() messages pre-v16.

2025-05-01 Thread Tom Lane
Add missing newlines to PQescapeInternal() messages pre-v16. While back-patching 9f45e6a91, I neglected that the convention in pre-v16 libpq was to include a trailing newline in error message strings (since then, we add those separately). Add them now. Reported-by: Peter Eisentraut Discussion:

pgsql: doc: Warn that ts_headline() output is not HTML-safe.

2025-05-01 Thread Dean Rasheed
doc: Warn that ts_headline() output is not HTML-safe. Add a documentation warning to ts_headline() pointing out that, when working with untrusted input documents, the output is not guaranteed to be safe for direct inclusion in web pages. This is because, while it does remove some XML tags from the

pgsql: doc: Warn that ts_headline() output is not HTML-safe.

2025-05-01 Thread Dean Rasheed
doc: Warn that ts_headline() output is not HTML-safe. Add a documentation warning to ts_headline() pointing out that, when working with untrusted input documents, the output is not guaranteed to be safe for direct inclusion in web pages. This is because, while it does remove some XML tags from the

pgsql: doc: Warn that ts_headline() output is not HTML-safe.

2025-05-01 Thread Dean Rasheed
doc: Warn that ts_headline() output is not HTML-safe. Add a documentation warning to ts_headline() pointing out that, when working with untrusted input documents, the output is not guaranteed to be safe for direct inclusion in web pages. This is because, while it does remove some XML tags from the

pgsql: doc: Warn that ts_headline() output is not HTML-safe.

2025-05-01 Thread Dean Rasheed
doc: Warn that ts_headline() output is not HTML-safe. Add a documentation warning to ts_headline() pointing out that, when working with untrusted input documents, the output is not guaranteed to be safe for direct inclusion in web pages. This is because, while it does remove some XML tags from the

pgsql: doc: Warn that ts_headline() output is not HTML-safe.

2025-05-01 Thread Dean Rasheed
doc: Warn that ts_headline() output is not HTML-safe. Add a documentation warning to ts_headline() pointing out that, when working with untrusted input documents, the output is not guaranteed to be safe for direct inclusion in web pages. This is because, while it does remove some XML tags from the

pgsql: doc: Warn that ts_headline() output is not HTML-safe.

2025-05-01 Thread Dean Rasheed
doc: Warn that ts_headline() output is not HTML-safe. Add a documentation warning to ts_headline() pointing out that, when working with untrusted input documents, the output is not guaranteed to be safe for direct inclusion in web pages. This is because, while it does remove some XML tags from the

Re: pgsql: oauth: Move the builtin flow into a separate module

2025-05-01 Thread Tom Lane
Jacob Champion writes: > I'm taking a look at the MacPorts failure now. It looks like you need to mention libintl explicitly in the link command for libpq-oauth, if we're building with NLS. macOS is picky that way ... regards, tom lane

Re: pgsql: oauth: Move the builtin flow into a separate module

2025-05-01 Thread Jacob Champion
On Thu, May 1, 2025 at 10:48 AM Tom Lane wrote: > It looks like you need to mention libintl explicitly in the link > command for libpq-oauth, if we're building with NLS. > macOS is picky that way ... Yeah, and that was in at one point at Peter's suggestion. :/ I made the mistake of taking it back

pgsql: doc: Improve explanations when a table rewrite is needed

2025-05-01 Thread Peter Eisentraut
doc: Improve explanations when a table rewrite is needed Further improvement for commit 11bd8318602. That commit confused identity and generated columns; fix that. Also, virtual generated columns have since been added; add more details about that. Also some small rewordings and reformattings to

pgsql: Remove extra "not" in pg_upgrade documentation.

2025-05-01 Thread Nathan Bossart
Remove extra "not" in pg_upgrade documentation. Oversight in commit cb45dc3afb. Reported-by: Erik Rijkers Reviewed-by: Fujii Masao Discussion: https://postgr.es/m/7b856277-62ad-80f0-36e1-a134ec3c9cab%40xs4all.nl Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a3e

pgsql: oauth: Move the builtin flow into a separate module

2025-05-01 Thread Jacob Champion
oauth: Move the builtin flow into a separate module The additional packaging footprint of the OAuth Curl dependency, as well as the existence of libcurl in the address space even if OAuth isn't ever used by a client, has raised some concerns. Split off this dependency into a separate loadable modu

Re: pgsql: oauth: Move the builtin flow into a separate module

2025-05-01 Thread Jacob Champion
On Thu, May 1, 2025 at 10:26 AM Jacob Champion wrote: > > oauth: Move the builtin flow into a separate module I'm taking a look at the MacPorts failure now. --Jacob

pgsql: oauth: Fix Autoconf build on macOS

2025-05-01 Thread Jacob Champion
oauth: Fix Autoconf build on macOS Oversight in b0635bfda. -lintl is necessary for gettext on Mac, which libpq-oauth depends on via pgport/pgcommon. (I'd incorrectly removed this change from an earlier version of the patch, where it was suggested by Peter Eisentraut.) Per buildfarm member indri.

pgsql: doc: Flesh out extension docs for the "prefix" make variable

2025-05-01 Thread Peter Eisentraut
doc: Flesh out extension docs for the "prefix" make variable The variable is a bit magical in how it requires "postgresql" or "pgsql" to be part of the path, and files end up in its "share" and "lib" subdirectories. So mention all that and show an example of setting "extension_control_path" and "

Re: pgsql: Make escaping functions retain trailing bytes of an invalid char

2025-05-01 Thread Tom Lane
Peter Eisentraut writes: > On 15.02.25 22:20, Tom Lane wrote: >> Make escaping functions retain trailing bytes of an invalid character. > I think the backpatch of this to PG15 and older has erroneously dropped > newlines at the end of some error messages. Oh! You're right, though I'd phrase it

Re: pgsql: doc: Warn that ts_headline() output is not HTML-safe.

2025-05-01 Thread Robins Tharakan
d LTO compression algorithms: zlib zstd gcc version 16.0.0 20250501 (experimental) (GCC) COLLECT_GCC_OPTIONS='-v' '-save-temps' '-Wall' '-Wmissing-prototypes' '-Wpointer-arith' '-Wdeclaration-after-statement' '-Werror=vla' '-W

pgsql: Doc: stop implying recommendation of insecure search_path value.

2025-05-01 Thread Noah Misch
Doc: stop implying recommendation of insecure search_path value. SQL "SET search_path = 'pg_catalog, pg_temp'" is silently equivalent to "SET search_path = pg_temp, pg_catalog, "pg_catalog, pg_temp"" instead of the intended "SET search_path = pg_catalog, pg_temp". (The intent was a two-element se

pgsql: Doc: stop implying recommendation of insecure search_path value.

2025-05-01 Thread Noah Misch
Doc: stop implying recommendation of insecure search_path value. SQL "SET search_path = 'pg_catalog, pg_temp'" is silently equivalent to "SET search_path = pg_temp, pg_catalog, "pg_catalog, pg_temp"" instead of the intended "SET search_path = pg_catalog, pg_temp". (The intent was a two-element se

pgsql: Doc: stop implying recommendation of insecure search_path value.

2025-05-01 Thread Noah Misch
Doc: stop implying recommendation of insecure search_path value. SQL "SET search_path = 'pg_catalog, pg_temp'" is silently equivalent to "SET search_path = pg_temp, pg_catalog, "pg_catalog, pg_temp"" instead of the intended "SET search_path = pg_catalog, pg_temp". (The intent was a two-element se

pgsql: Doc: stop implying recommendation of insecure search_path value.

2025-05-01 Thread Noah Misch
Doc: stop implying recommendation of insecure search_path value. SQL "SET search_path = 'pg_catalog, pg_temp'" is silently equivalent to "SET search_path = pg_temp, pg_catalog, "pg_catalog, pg_temp"" instead of the intended "SET search_path = pg_catalog, pg_temp". (The intent was a two-element se

pgsql: Doc: stop implying recommendation of insecure search_path value.

2025-05-01 Thread Noah Misch
Doc: stop implying recommendation of insecure search_path value. SQL "SET search_path = 'pg_catalog, pg_temp'" is silently equivalent to "SET search_path = pg_temp, pg_catalog, "pg_catalog, pg_temp"" instead of the intended "SET search_path = pg_catalog, pg_temp". (The intent was a two-element se

pgsql: Doc: stop implying recommendation of insecure search_path value.

2025-05-01 Thread Noah Misch
Doc: stop implying recommendation of insecure search_path value. SQL "SET search_path = 'pg_catalog, pg_temp'" is silently equivalent to "SET search_path = pg_temp, pg_catalog, "pg_catalog, pg_temp"" instead of the intended "SET search_path = pg_catalog, pg_temp". (The intent was a two-element se

Re: pgsql: doc: Warn that ts_headline() output is not HTML-safe.

2025-05-01 Thread Tom Lane
Robins Tharakan writes: > On Thu, 1 May 2025 at 19:43, Dean Rasheed wrote: >> doc: Warn that ts_headline() output is not HTML-safe. > This commit looks harmless, but 2 separate machines are > failing on this commit (at the same point). It's hardly likely that a docs-only commit is the cause. D

Re: pgsql: doc: Warn that ts_headline() output is not HTML-safe.

2025-05-01 Thread Robins Tharakan
On Fri, 2 May 2025 at 07:28, Robins Tharakan wrote: > > So ideally if gcc fixes the issue (or if I fix something stupid in the way > I am > compiling gcc etc), the next buildfarm run should automatically go > green soon after. > Does look like a gcc bug. Ideally should go green automatically (o

Re: pgsql: doc: Warn that ts_headline() output is not HTML-safe.

2025-05-01 Thread Robins Tharakan
ing (0). Good. gcs09da 20250502_0616 - gcc version string has changed from [16.0.0 20250501 (experimental) - b6d37ec1dd2] to [16.0.0 20250501 (experimental) - 87c4460024d] gcs2d5a 20250502_0630 - git checkout successful. gcs2d5a 20250502_0630 - git pull successful. gcs2d5a 20250502_0630 - No change

pgsql: doc: first draft of the PG 18 release notes

2025-05-01 Thread Bruce Momjian
doc: first draft of the PG 18 release notes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a724c7889f74cc4e76e1979f90808decbc744c79 Modified Files -- doc/src/sgml/release-18.sgml | 3511 +- 1 file changed, 3501 in

Re: pgsql: Make escaping functions retain trailing bytes of an invalid char

2025-05-01 Thread Peter Eisentraut
On 15.02.25 22:20, Tom Lane wrote: Make escaping functions retain trailing bytes of an invalid character. Instead of dropping the trailing byte(s) of an invalid or incomplete multibyte character, replace only the first byte with a known-invalid sequence, and process the rest normally. This seem