Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

Alexander Korotkov writes: > On Sat, May 3, 2025 at 10:34 PM Tom Lane wrote: >> You are aware that we are in release freeze, no? > I missed that. Should I revert this commit now? Yes, I think so. If you feel it's critical enough to go in on a release weekend, you should ask pgsql-release@ for

pgsql: Revert "Refactor ChangeVarNodesExtended() using the custom callb

Revert "Refactor ChangeVarNodesExtended() using the custom callback" This reverts commit 250a718aadad68793e82103282247556a46a3cfc. It shouldn't be pushed during the release freeze. Reported-by: Tom Lane Discussion: https://postgr.es/m/E1uBIbY-000owH-0O%40gemulon.postgresql.org Branch -- mast

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

On Sat, May 3, 2025 at 11:06 PM Tom Lane wrote: > > Alexander Korotkov writes: > > On Sat, May 3, 2025 at 10:34 PM Tom Lane wrote: > >> You are aware that we are in release freeze, no? > > > I missed that. Should I revert this commit now? > > Yes, I think so. If you feel it's critical enough t

pgsql: doc PG 18 relnotes: move protocol version item to "server"

doc PG 18 relnotes: move protocol version item to "server" Reported-by: Jelte Fennema-Nio Discussion: https://postgr.es/m/cageczqstbgtsdjpxohwko7106-ynnyqgzpznjdis+xtkguh...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/04b269da56db966bd439bf4634

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

Alexander Korotkov writes: > Refactor ChangeVarNodesExtended() using the custom callback You are aware that we are in release freeze, no? regards, tom lane

pgsql: Refactor ChangeVarNodesExtended() using the custom callback

Refactor ChangeVarNodesExtended() using the custom callback fc069a3a6319 implemented Self-Join Elimination (SJE) and put related logic to ChangeVarNodes_walker(). This commit provides refactoring to remove the SJE-related logic from ChangeVarNodes_walker() but adds a custom callback to ChangeVarN

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

On Sat, May 3, 2025 at 10:34 PM Tom Lane wrote: > > Alexander Korotkov writes: > > Refactor ChangeVarNodesExtended() using the custom callback > > You are aware that we are in release freeze, no? I missed that. Should I revert this commit now? -- Regards, Alexander Korotkov Supabase

pgsql: doc PG 18 relnotes: add GROUP BY column elimination item

doc PG 18 relnotes: add GROUP BY column elimination item With a nod to PG 9.6. Reported-by: jian he Discussion: https://postgr.es/m/CACJufxEqs=exzetwtaoootfhzrtxvswg8m2upfzjnts3wq6...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/24987c6f0687576

pgsql: doc: update guidelines on non-ASCII characters in docs

doc: update guidelines on non-ASCII characters in docs Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fb21ed6c38da719149443e78048790c0347e2c9b Modified Files -- doc/src/sgml/README.non-ASCII | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)

pgsql: doc PG 18 relnotes: fix libpq wording

doc PG 18 relnotes: fix libpq wording Reported-by: Jelte Fennema-Nio Discussion: https://postgr.es/m/CAGECzQT4804OLOP+nDBxDpMw3Soq=g+fkoe7nrybhggy4gg...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a675149e87706d01e4007150a0124b89bdef08be Modifi

pgsql: Fix typos in comments.

Fix typos in comments. Also adjust the phrasing in the comments. Author: Etsuro Fujita Author: Heikki Linnakangas Reviewed-by: Tender Wang Reviewed-by: Gurjeet Singh Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAPmGK17%3DPHSDZ%2B0G6jcj12buyyE1bQQc3sbp1Wxri7tODT-SDw%40mail.g

pgsql: Fix memory allocation/copy mistakes.

Fix memory allocation/copy mistakes. The previous code was allocating more memory and copying more data than necessary because it specified the wrong PgStat_KindInfo member as the size argument for MemoryContextAlloc and memcpy, respectively. Although these issues exist since 5891c7a8e, there hav

pgsql: Fix typos in comments.

Fix typos in comments. Also adjust the phrasing in the comments. Author: Etsuro Fujita Author: Heikki Linnakangas Reviewed-by: Tender Wang Reviewed-by: Gurjeet Singh Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAPmGK17%3DPHSDZ%2B0G6jcj12buyyE1bQQc3sbp1Wxri7tODT-SDw%40mail.g

pgsql: Fix typos in comments.

Fix typos in comments. Also adjust the phrasing in the comments. Author: Etsuro Fujita Author: Heikki Linnakangas Reviewed-by: Tender Wang Reviewed-by: Gurjeet Singh Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAPmGK17%3DPHSDZ%2B0G6jcj12buyyE1bQQc3sbp1Wxri7tODT-SDw%40mail.g

pgsql: Fix typos in comments.

Fix typos in comments. Also adjust the phrasing in the comments. Author: Etsuro Fujita Author: Heikki Linnakangas Reviewed-by: Tender Wang Reviewed-by: Gurjeet Singh Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAPmGK17%3DPHSDZ%2B0G6jcj12buyyE1bQQc3sbp1Wxri7tODT-SDw%40mail.g