pgsql: Improve guards against false regex matches in BackgroundPsql.pm.

2026-01-30 Thread Tom Lane
Improve guards against false regex matches in BackgroundPsql.pm. BackgroundPsql needs to wait for all the output from an interactive psql command to come back. To make sure that's happened, it issues the command, then issues \echo and \warn psql commands that echo a "banner" string (which we assu

pgsql: Improve guards against false regex matches in BackgroundPsql.pm.

2026-01-30 Thread Tom Lane
Improve guards against false regex matches in BackgroundPsql.pm. BackgroundPsql needs to wait for all the output from an interactive psql command to come back. To make sure that's happened, it issues the command, then issues \echo and \warn psql commands that echo a "banner" string (which we assu

pgsql: Improve guards against false regex matches in BackgroundPsql.pm.

2026-01-30 Thread Tom Lane
Improve guards against false regex matches in BackgroundPsql.pm. BackgroundPsql needs to wait for all the output from an interactive psql command to come back. To make sure that's happened, it issues the command, then issues \echo and \warn psql commands that echo a "banner" string (which we assu

pgsql: Make psql/t/030_pager.pl more robust.

2026-01-30 Thread Tom Lane
Make psql/t/030_pager.pl more robust. Similarly to the preceding commit, 030_pager.pl was assuming that patterns it looks for in interactive psql output would appear by themselves on a line, but that assumption tends to fall over in builds made --without-readline: the output we get might have a ps

pgsql: Improve guards against false regex matches in BackgroundPsql.pm.

2026-01-30 Thread Tom Lane
Improve guards against false regex matches in BackgroundPsql.pm. BackgroundPsql needs to wait for all the output from an interactive psql command to come back. To make sure that's happened, it issues the command, then issues \echo and \warn psql commands that echo a "banner" string (which we assu

pgsql: Improve guards against false regex matches in BackgroundPsql.pm.

2026-01-30 Thread Tom Lane
Improve guards against false regex matches in BackgroundPsql.pm. BackgroundPsql needs to wait for all the output from an interactive psql command to come back. To make sure that's happened, it issues the command, then issues \echo and \warn psql commands that echo a "banner" string (which we assu

pgsql: Improve guards against false regex matches in BackgroundPsql.pm.

2026-01-30 Thread Tom Lane
Improve guards against false regex matches in BackgroundPsql.pm. BackgroundPsql needs to wait for all the output from an interactive psql command to come back. To make sure that's happened, it issues the command, then issues \echo and \warn psql commands that echo a "banner" string (which we assu

pgsql: Update .abi-compliance-history for change to TransitionCaptureSt

2026-01-30 Thread Dean Rasheed
Update .abi-compliance-history for change to TransitionCaptureState. As noted in the commit message for b4307ae2e54, the change to the TransitionCaptureState structure is nominally an ABI break, but it is not expected to affect any third-party code. Therefore, add it to the .abi-compliance-history

pgsql: Update .abi-compliance-history for change to TransitionCaptureSt

2026-01-30 Thread Dean Rasheed
Update .abi-compliance-history for change to TransitionCaptureState. As noted in the commit message for b4307ae2e54, the change to the TransitionCaptureState structure is nominally an ABI break, but it is not expected to affect any third-party code. Therefore, add it to the .abi-compliance-history

pgsql: Update .abi-compliance-history for change to TransitionCaptureSt

2026-01-30 Thread Dean Rasheed
Update .abi-compliance-history for change to TransitionCaptureState. As noted in the commit message for b4307ae2e54, the change to the TransitionCaptureState structure is nominally an ABI break, but it is not expected to affect any third-party code. Therefore, add it to the .abi-compliance-history

pgsql: Update .abi-compliance-history for change to TransitionCaptureSt

2026-01-30 Thread Dean Rasheed
Update .abi-compliance-history for change to TransitionCaptureState. As noted in the commit message for b4307ae2e54, the change to the TransitionCaptureState structure is nominally an ABI break, but it is not expected to affect any third-party code. Therefore, add it to the .abi-compliance-history

pgsql: Use C99 designated designators in a couple of places

2026-01-30 Thread Álvaro Herrera
Use C99 designated designators in a couple of places This makes the arrays somewhat easier to read. Author: Álvaro Herrera Reviewed-by: Peter Eisentraut Reviewed-by: Melanie Plageman Reviewed-by: Jelte Fennema-Nio Discussion: https://postgr.es/m/[email protected] Branc

pgsql: Minor cosmetic tweaks

2026-01-30 Thread Álvaro Herrera
Minor cosmetic tweaks These changes should have been done by 2f9661311b83, but were overlooked. I noticed while reviewing the code for commit b8926a5b4bb8. Author: Álvaro Herrera Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https:/

pgsql: Move shmem allocator's fields from PGShmemHeader to its own stru

2026-01-30 Thread Heikki Linnakangas
Move shmem allocator's fields from PGShmemHeader to its own struct For readability. It was a slight modularity violation to have fields in PGShmemHeader that were only used by the allocator code in shmem.c. And it was inconsistent that ShmemLock was nevertheless not stored there. Moving all the al