Re: [COMMITTERS] pgsql-server: Comment out unused variable.

2004-10-04 Thread Bruce Momjian
Neil Conway wrote: > On Tue, 2004-10-05 at 01:09, Bruce Momjian wrote: > > Log Message: > > --- > > Comment out unused variable. > > If it is unused, it ought to be removed IMHO. Merely commenting out > unused code leads to bloat over time. It was part of the original NetBSD code so I usu

[COMMITTERS] pgsql-server: Pickup fix from upstream OpenBSD sources: mark a read-only

2004-10-04 Thread Neil Conway
Log Message: --- Pickup fix from upstream OpenBSD sources: mark a read-only local array as "static" to reduce size of generated code slightly. Modified Files: -- pgsql-server/contrib/pgcrypto: blf.c (r1.5 -> r1.6) (http://developer.postgresql.org/cvsweb.cgi

[COMMITTERS] pgsql-server: License cleanup: crypt.c and qsort.c to latest NetBSD CVS

2004-10-04 Thread Neil Conway
Log Message: --- License cleanup: crypt.c and qsort.c to latest NetBSD CVS sources, to pickup license clarification (3-clause BSD is now used). Add license terms to memcmp.c (also from NetBSD), which previously had none. Finally, pickup an upstream fix to crypt.c (const-ify some arrays). M

Re: [COMMITTERS] pgsql-server: Comment out unused variable.

2004-10-04 Thread Neil Conway
On Tue, 2004-10-05 at 01:09, Bruce Momjian wrote: > Log Message: > --- > Comment out unused variable. If it is unused, it ought to be removed IMHO. Merely commenting out unused code leads to bloat over time. -Neil ---(end of broadcast)---

[COMMITTERS] contrib: Refer to ll_to_earth() function by its actual name.

2004-10-04 Thread Tom Lane
Log Message: --- Refer to ll_to_earth() function by its actual name. Modified Files: -- contrib/earthdistance: README.earthdistance (r1.5 -> r1.6) (http://developer.postgresql.org/cvsweb.cgi/contrib/earthdistance/README.earthdistance.diff?r1=1.5&r2=1.6) --

[COMMITTERS] pgsql-server: Remove arithmetic operators on the 1-byte-char datatype,

2004-10-04 Thread Tom Lane
Log Message: --- Remove arithmetic operators on the 1-byte-char datatype, as per proposals made several times in the past. Add coercion functions between "char" and integer so that a workaround is possible if needed. Initdb forced. Modified Files: -- pgsql-server/doc/src/

[COMMITTERS] pgsql-server: Correct the volatility labeling of ten timestamp-related

2004-10-04 Thread Tom Lane
Log Message: --- Correct the volatility labeling of ten timestamp-related functions, per discussion from Friday. initdb not forced in this commit but I intend to do that later. Modified Files: -- pgsql-server/src/include/catalog: pg_proc.h (r1.345 -> r1.346)

[COMMITTERS] pgbuildfarm - client-code: experimental code (turned off by default) to

2004-10-04 Thread User Andrewd
Log Message: --- experimental code (turned off by default) to time out cvs checkouts in case they hang on a lock. Modified Files: -- client-code: run_build.pl (r1.5 -> r1.6) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbuildfarm/client-code/run_build.pl.

[COMMITTERS] pgsql-server: PortalRun must guard against the possibility that the

2004-10-04 Thread Tom Lane
Log Message: --- PortalRun must guard against the possibility that the portal it's running contains VACUUM or a similar command that will internally start and commit transactions. In such a case, the original caller values of CurrentMemoryContext and CurrentResourceOwner will point to obje

[COMMITTERS] pgsql-server: Make sure no libs use libpgport by removing it from the

2004-10-04 Thread Bruce Momjian
Log Message: --- Make sure no libs use libpgport by removing it from the link line. Modified Files: -- pgsql-server/src/bin/psql: Makefile (r1.49 -> r1.50) (http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/bin/psql/Makefile.diff?r1=1.49&r2=1.50)

[COMMITTERS] pgsql-server: Fix MinGW link failure with new libpgport processing.

2004-10-04 Thread Bruce Momjian
Log Message: --- Fix MinGW link failure with new libpgport processing. Modified Files: -- pgsql-server/src/bin/pg_dump: Makefile (r1.54 -> r1.55) (http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/bin/pg_dump/Makefile.diff?r1=1.54&r2=1.55) --

[COMMITTERS] pgsql-server: Update comment on int64 printf speciifications for MinGW:

2004-10-04 Thread Bruce Momjian
Log Message: --- Update comment on int64 printf speciifications for MinGW: # MinGW uses '%I64d', though gcc throws an warning with -Wall, # while '%lld' doesn't generate a warning, but doesn't work. Modified Files: -- pgsql-server/config: c-library.m4 (r1.27 -> r1.

[COMMITTERS] pgsql-server: Readd -DFRONTEND to client makefiles because it still

2004-10-04 Thread Bruce Momjian
Log Message: --- Readd -DFRONTEND to client makefiles because it still affects win32.h defines. Modified Files: -- pgsql-server/src/bin/initdb: Makefile (r1.45 -> r1.46) (http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/bin/initdb/Makefile.diff?r

[COMMITTERS] pgbuildfarm - client-code: fix stage labels and differentiate between

2004-10-04 Thread User Andrewd
Log Message: --- fix stage labels and differentiate between invocations of start/stop db. Modified Files: -- client-code: run_build.pl (r1.4 -> r1.5) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbuildfarm/client-code/run_build.pl.diff?r1=1.4&r2=1.5) ---

[COMMITTERS] pgsql-server: Add CVS URL for docs.

2004-10-04 Thread Bruce Momjian
Log Message: --- Add CVS URL for docs. Modified Files: -- pgsql-server/doc: FAQ_DEV (r1.62 -> r1.63) (http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/FAQ_DEV.diff?r1=1.62&r2=1.63) pgsql-server/doc/src/FAQ: FAQ_DEV.html (r1.65 -> r1.6

[COMMITTERS] pgsql-server: Fix warnings from crypt.c compile.

2004-10-04 Thread Bruce Momjian
Log Message: --- Fix warnings from crypt.c compile. Modified Files: -- pgsql-server/src/port: crypt.c (r1.9 -> r1.10) (http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/port/crypt.c.diff?r1=1.9&r2=1.10) ---(end of broadcas

[COMMITTERS] pgsql-server: Comment out unused variable.

2004-10-04 Thread Bruce Momjian
Log Message: --- Comment out unused variable. Modified Files: -- pgsql-server/src/port: crypt.c (r1.8 -> r1.9) (http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/port/crypt.c.diff?r1=1.8&r2=1.9) ---(end of broadcast)--

[COMMITTERS] pgsql-server: Suppress getppid test on WIN32, per Dave Page.

2004-10-04 Thread Tom Lane
Log Message: --- Suppress getppid test on WIN32, per Dave Page. Modified Files: -- pgsql-server/src/backend/utils/init: miscinit.c (r1.133 -> r1.134) (http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/utils/init/miscinit.c.diff?r1=1.133&r2

[COMMITTERS] pgsql-server: Detect overflow in integer arithmetic operators (integer,

2004-10-04 Thread Tom Lane
Log Message: --- Detect overflow in integer arithmetic operators (integer, smallint, and bigint variants). Clean up some inconsistencies in error message wording. Fix scanint8 to allow trailing whitespace in INT64_MIN case. Update int8-exp-three-digits.out, which seems to have been ignore

[COMMITTERS] pginstaller - pginst: Update JDBC to pgdev.306 build.

2004-10-04 Thread User Dpage
Log Message: --- Update JDBC to pgdev.306 build. Modified Files: -- pginst/wxs: pginst.wxs (r1.72 -> r1.73) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pginstaller/pginst/wxs/pginst.wxs.diff?r1=1.72&r2=1.73) ---(end of broadcast)--

[COMMITTERS] pgsql-server: Make libpgport be front-end only and make libpgport_srv be

2004-10-04 Thread Bruce Momjian
Log Message: --- Make libpgport be front-end only and make libpgport_srv be a backend library that uses palloc, ereport, etc. This simplifies the makefiles for client applications. Modified Files: -- pgsql-server/src/backend: Makefile (r1.104 -> r1.105) (h

[COMMITTERS] pginstaller - pginst: Fix typo.

2004-10-04 Thread User Dpage
Log Message: --- Fix typo. Improve user feedback during initdb. Modified Files: -- pginst/ca: pginstca.c (r1.56 -> r1.57) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pginstaller/pginst/ca/pginstca.c.diff?r1=1.56&r2=1.57) pginst/wxs: pginst.wxs

[COMMITTERS] pginstaller - pginst: Added the last of the contrib modules: string,

2004-10-04 Thread User Dpage
Log Message: --- Added the last of the contrib modules: string, tablefunc, tsearch, userlock, vacuumlo, adddepend and dbmirror. xml/xml2 are also included, but currently commented out due to build issues. Modified Files: -- pginst/ca: pginstca.c (r1.55 -> r1.56)

[COMMITTERS] pgsql-server: Fix error in setseed() docs: "int32" is not a (SQL) type,

2004-10-04 Thread Neil Conway
Log Message: --- Fix error in setseed() docs: "int32" is not a (SQL) type, but "integer" is. Modified Files: -- pgsql-server/doc/src/sgml: func.sgml (r1.219 -> r1.220) (http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/func.sgml.diff?r1=1