Re: [COMMITTERS] pgsql: Add time/date macros for code clarity: #define

2005-07-20 Thread Bruce Momjian
Fixed. --- Tom Lane wrote: > BTW, the initial returns (see kookaburra buildfarm log) say that you > broke things completely. > > cc -O2 -qmaxmem=16384 -qsrcmsg -qlonglong -g -I../../../../src/include > -I/usr/local/include

Re: [COMMITTERS] pgsql: Add time/date macros for code clarity: #define

2005-07-20 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >> In short, I don't think this is an improvement. > > > The problem is that 24 or 30 or 60 doesn't really say what it is, while > > the macros are self-documenting. > > Except that they're NOT. > > Anyone who is reading datetime cod

[COMMITTERS] pgsql: Fix integer timestamp build for macro changes.

2005-07-20 Thread Bruce Momjian
Log Message: --- Fix integer timestamp build for macro changes. Modified Files: -- pgsql/src/backend/utils/adt: timestamp.c (r1.136 -> r1.137) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/timestamp.c.diff?r1=1.136&r2=1.137) pg

Re: [COMMITTERS] pgsql: Add time/date macros for code clarity: #define

2005-07-20 Thread Bruce Momjian
Marc G. Fournier wrote: > On Thu, 21 Jul 2005, Tom Lane wrote: > > > Bruce Momjian writes: > >> Tom Lane wrote: > #define DAYS_PER_YEAR 365.25 > #define MONTHS_PER_YEAR 12 > #define DAYS_PER_MONTH 30 > #define HOURS_PER_DAY 24 > >>> > >>> Considering that only one of thes

Re: [COMMITTERS] pgsql: Add time/date macros for code clarity: #define

2005-07-20 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> In short, I don't think this is an improvement. > The problem is that 24 or 30 or 60 doesn't really say what it is, while > the macros are self-documenting. Except that they're NOT. Anyone who is reading datetime code will be entirely familiar with the

Re: [COMMITTERS] pgsql: Add 'day' field to INTERVAL so 1 day interval

2005-07-20 Thread Bruce Momjian
Kris Jurka wrote: > Bruce Momjian wrote: > > Log Message: > > --- > > Add 'day' field to INTERVAL so 1 day interval can be distinguished from > > 24 hours. This is very helpful for daylight savings time: > > > > Seems to have broken the contrib/btree_gist interval regression tests > > ht

Re: [COMMITTERS] pgsql: Add time/date macros for code clarity:

2005-07-20 Thread Marc G. Fournier
On Thu, 21 Jul 2005, Tom Lane wrote: Bruce Momjian writes: Tom Lane wrote: #define DAYS_PER_YEAR 365.25 #define MONTHS_PER_YEAR 12 #define DAYS_PER_MONTH 30 #define HOURS_PER_DAY 24 Considering that only one of these four is actually an accurate constant, I have to question the usefuln

Re: [COMMITTERS] pgsql: Add time/date macros for code clarity: #define DAYS_PER_YEAR

2005-07-20 Thread Tom Lane
BTW, the initial returns (see kookaburra buildfarm log) say that you broke things completely. cc -O2 -qmaxmem=16384 -qsrcmsg -qlonglong -g -I../../../../src/include -I/usr/local/include -c -o timestamp.o timestamp.c 1211 | span->time = (tm->tm_hour * ((int64) SECS_PER_MINUTELL)

Re: [COMMITTERS] pgsql: Add time/date macros for code clarity: #define

2005-07-20 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >>> #define DAYS_PER_YEAR 365.25 > >>> #define MONTHS_PER_YEAR 12 > >>> #define DAYS_PER_MONTH 30 > >>> #define HOURS_PER_DAY 24 > >> > >> Considering that only one of these four is actually an accurate > >> constant, I have to qu

Re: [COMMITTERS] pgsql: Add time/date macros for code clarity: #define DAYS_PER_YEAR

2005-07-20 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >>> #define DAYS_PER_YEAR 365.25 >>> #define MONTHS_PER_YEAR 12 >>> #define DAYS_PER_MONTH 30 >>> #define HOURS_PER_DAY 24 >> >> Considering that only one of these four is actually an accurate >> constant, I have to question the usefulness of this. >

Re: [COMMITTERS] pgsql: Add time/date macros for code clarity: #define

2005-07-20 Thread Bruce Momjian
Tom Lane wrote: > [EMAIL PROTECTED] (Bruce Momjian) writes: > > Log Message: > > --- > > Add time/date macros for code clarity: > > > #define DAYS_PER_YEAR 365.25 > > #define MONTHS_PER_YEAR 12 > > #define DAYS_PER_MONTH 30 > > #define HOURS_PER_DAY 24 > > Considering

[COMMITTERS] pgsql: Add comment marking non-exact time conversion macros.

2005-07-20 Thread Bruce Momjian
Log Message: --- Add comment marking non-exact time conversion macros. Modified Files: -- pgsql/src/include/utils: timestamp.h (r1.48 -> r1.49) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/timestamp.h.diff?r1=1.48&r2=1.49) pgsql/s

[COMMITTERS] pgsql: Remove unnecessary parentheses in assignments.

2005-07-20 Thread Bruce Momjian
Log Message: --- Remove unnecessary parentheses in assignments. Add spaces where needed. Reference time interval variables as tinterval. Modified Files: -- pgsql/src/backend/utils/adt: acl.c (r1.119 -> r1.120) (http://developer.postgresql.org/cvsweb.cgi/pgs

Re: [COMMITTERS] pgsql: Add time/date macros for code clarity: #define DAYS_PER_YEAR

2005-07-20 Thread Tom Lane
[EMAIL PROTECTED] (Bruce Momjian) writes: > Log Message: > --- > Add time/date macros for code clarity: > #define DAYS_PER_YEAR 365.25 > #define MONTHS_PER_YEAR 12 > #define DAYS_PER_MONTH 30 > #define HOURS_PER_DAY 24 Considering that only one of these four i

[COMMITTERS] pgsql: Fix storage size for btree_gist interval indexes.

2005-07-20 Thread Tom Lane
Log Message: --- Fix storage size for btree_gist interval indexes. Fix penalty calculations for interval and time/timetz to behave sanely for both integer and float timestamps; up to now I think it's been doing something pretty strange... Modified Files: -- pgsql/contrib/b

[COMMITTERS] pgsql: Add time/date macros for code clarity: #define DAYS_PER_YEAR

2005-07-20 Thread Bruce Momjian
Log Message: --- Add time/date macros for code clarity: #define DAYS_PER_YEAR 365.25 #define MONTHS_PER_YEAR 12 #define DAYS_PER_MONTH 30 #define HOURS_PER_DAY 24 Modified Files: -- pgsql/src/backend/commands: variable.c (r1.110

[COMMITTERS] pgsql: Fix breakage of INSTALL document build.

2005-07-20 Thread Tom Lane
Log Message: --- Fix breakage of INSTALL document build. Modified Files: -- pgsql/doc/src/sgml: installation.sgml (r1.240 -> r1.241) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/installation.sgml.diff?r1=1.240&r2=1.241) --

[COMMITTERS] python - ex: Use 'Py' instead of 'PY' for the Python code class as it

2005-07-20 Thread James William Pye
Log Message: --- Use 'Py' instead of 'PY' for the Python code class as it seems to standout better. Modified Files: -- ex/src: code.py (r1.4 -> r1.5) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/python/ex/src/code.py.diff?r1=1.4&r2=1.5) ---

[COMMITTERS] python - ex: Add code specific classes and generalize IntegrityError.

2005-07-20 Thread James William Pye
Log Message: --- Add code specific classes and generalize IntegrityError. Add Undefined* and Duplicate* code specific exceptions. These are likely to be fairly common, so provide use convenience by giving code specific exceptions. IntegrityError has become an abstract exception; ICV code c

[COMMITTERS] bizgres - bizgres: Initial check in of the first set of reports.

2005-07-20 Thread User Bklawans
Log Message: --- Initial check in of the first set of reports. Requires JasperReports 1.0 to work, and many will not work within the current 0.5 version of iReports. See the README for more info. Added Files: --- bizgres/JasperReports/reports: EntryPagesForWeek.jrxml

[COMMITTERS] bizgres - bizgres: Added JasperReports license information.

2005-07-20 Thread User Bklawans
Log Message: --- Added JasperReports license information. Added Files: --- bizgres/JasperReports/license: jasperreports.txt (r1.1) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/bizgres/bizgres/JasperReports/license/jasperreports.txt?rev=1.1&content-type=text/x-c

[COMMITTERS] bizgres - bizgres: Some SQL scripts to create additional aggregate

2005-07-20 Thread User Bklawans
Log Message: --- Some SQL scripts to create additional aggregate tables used by some of the reports. These need to be integrated with KETL and obsoleted. See the README for more info. Added Files: --- bizgres/JasperReports/sql_scripts: README.txt (r1.1) (http:

[COMMITTERS] bizgres - bizgres: New Directory

2005-07-20 Thread User Bklawans
Update of /cvsroot/bizgres/bizgres/JasperReports/license In directory pgfoundry.org:/tmp/cvs-serv25326/license Log Message: Directory /cvsroot/bizgres/bizgres/JasperReports/license added to the repository ---(end of broadcast)--- TIP 4: Have you se

[COMMITTERS] bizgres - bizgres: New Directory

2005-07-20 Thread User Bklawans
Update of /cvsroot/bizgres/bizgres/JasperReports/lib In directory pgfoundry.org:/tmp/cvs-serv23513/lib Log Message: Directory /cvsroot/bizgres/bizgres/JasperReports/lib added to the repository ---(end of broadcast)--- TIP 6: explain analyze is your

[COMMITTERS] bizgres - bizgres: New Directory

2005-07-20 Thread User Bklawans
Update of /cvsroot/bizgres/bizgres/JasperReports/reports In directory pgfoundry.org:/tmp/cvs-serv23768/reports Log Message: Directory /cvsroot/bizgres/bizgres/JasperReports/reports added to the repository ---(end of broadcast)--- TIP 6: explain ana

[COMMITTERS] bizgres - bizgres: New Directory

2005-07-20 Thread User Bklawans
Update of /cvsroot/bizgres/bizgres/JasperReports/sql_scripts In directory pgfoundry.org:/tmp/cvs-serv24034/sql_scripts Log Message: Directory /cvsroot/bizgres/bizgres/JasperReports/sql_scripts added to the repository ---(end of broadcast)--- TIP 5

[COMMITTERS] bizgres - bizgres: The newly release 1.0 version of JasperReports.

2005-07-20 Thread User Bklawans
Log Message: --- The newly release 1.0 version of JasperReports. This version of the library is required, as several of the included reports use the new charting capabilities. For the source, go to http://jasperreports.sourceforge.net Added Files: --- bizgres/JasperReports/li

[COMMITTERS] pgsql: /contrib/btree_gist adjustments for new 'day' interval value.

2005-07-20 Thread Bruce Momjian
Log Message: --- /contrib/btree_gist adjustments for new 'day' interval value. Modified Files: -- pgsql/contrib/btree_gist: btree_interval.c (r1.4 -> r1.5) (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/btree_gist/btree_interval.c.diff?r1=1.4&r2=

Re: [COMMITTERS] pgsql: Add 'day' field to INTERVAL so 1 day interval

2005-07-20 Thread Bruce Momjian
Kris Jurka wrote: > Bruce Momjian wrote: > > Log Message: > > --- > > Add 'day' field to INTERVAL so 1 day interval can be distinguished from > > 24 hours. This is very helpful for daylight savings time: > > > > Seems to have broken the contrib/btree_gist interval regression tests > > ht

Re: [COMMITTERS] pgsql: Add 'day' field to INTERVAL so 1 day interval can be

2005-07-20 Thread Kris Jurka
Bruce Momjian wrote: Log Message: --- Add 'day' field to INTERVAL so 1 day interval can be distinguished from 24 hours. This is very helpful for daylight savings time: Seems to have broken the contrib/btree_gist interval regression tests http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=d

Re: [COMMITTERS] pgsql: Add 'day' field to INTERVAL so 1 day interval

2005-07-20 Thread Bruce Momjian
Bruce Momjian wrote: > Log Message: > --- > Add 'day' field to INTERVAL so 1 day interval can be distinguished from > 24 hours. This is very helpful for daylight savings time: > > select '2005-05-03 00:00:00 EST'::timestamp with time zone + '24 hours'; > ?column? >

Re: [COMMITTERS] pgsql: Add 'day' field to INTERVAL so 1 day interval

2005-07-20 Thread Bruce Momjian
Tom Lane wrote: > [EMAIL PROTECTED] (Bruce Momjian) writes: > > Add 'day' field to INTERVAL so 1 day interval can be distinguished from > > 24 hours. This is very helpful for daylight savings time: > > Surely this patch should have forced initdb. Thanks, done. He originally had the catversion bu

[COMMITTERS] pgsql: Update catalog version for INTERVAL day addition.

2005-07-20 Thread Bruce Momjian
Log Message: --- Update catalog version for INTERVAL day addition. Modified Files: -- pgsql/src/include/catalog: catversion.h (r1.289 -> r1.290) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/catversion.h.diff?r1=1.289&r2=1.290)

Re: [COMMITTERS] pgsql: Add 'day' field to INTERVAL so 1 day interval can be

2005-07-20 Thread Tom Lane
[EMAIL PROTECTED] (Bruce Momjian) writes: > Add 'day' field to INTERVAL so 1 day interval can be distinguished from > 24 hours. This is very helpful for daylight savings time: Surely this patch should have forced initdb. regards, tom lane ---(end o

[COMMITTERS] pgsql: Add 'day' field to INTERVAL so 1 day interval can be

2005-07-20 Thread Bruce Momjian
Log Message: --- Add 'day' field to INTERVAL so 1 day interval can be distinguished from 24 hours. This is very helpful for daylight savings time: select '2005-05-03 00:00:00 EST'::timestamp with time zone + '24 hours'; ?column? --