[COMMITTERS] pgsql: Fix unportable usages of tolower().

2008-02-29 Thread Tom Lane
Log Message: --- Fix unportable usages of tolower(). On signed-char machines, it is necessary to explicitly cast the output back to char before comparing it to a char value, else we get the wrong result for high-bit-set characters. Found by Rolf Jentsch. Also, fix several places where f

[COMMITTERS] pgsql: Fix unportable usages of tolower().

2008-02-29 Thread Tom Lane
Log Message: --- Fix unportable usages of tolower(). On signed-char machines, it is necessary to explicitly cast the output back to char before comparing it to a char value, else we get the wrong result for high-bit-set characters. Found by Rolf Jentsch. Also, fix several places where f

[COMMITTERS] pgsql: Disable the undocumented xmlvalidate() function, which was

2008-02-29 Thread Tom Lane
Log Message: --- Disable the undocumented xmlvalidate() function, which was unintentionally left in the code though it was not meant to be provided. It represents a security hole because unprivileged users could use it to look at (at least the first line of) any file readable by the backen

[COMMITTERS] pgsql: Disable the undocumented xmlvalidate() function, which was

2008-02-29 Thread Tom Lane
Log Message: --- Disable the undocumented xmlvalidate() function, which was unintentionally left in the code though it was not meant to be provided. It represents a security hole because unprivileged users could use it to look at (at least the first line of) any file readable by the backen

[COMMITTERS] pgsql: Don't call AddUserToDacl on Cygwin

2008-02-29 Thread Andrew Dunstan
Log Message: --- Don't call AddUserToDacl on Cygwin Tags: REL8_2_STABLE Modified Files: -- pgsql/src/bin/initdb: initdb.c (r1.125.2.1 -> r1.125.2.2) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/initdb/initdb.c?r1=1.125.2.1&r2=1.125.2.2)

[COMMITTERS] pgsql: Don't call AddUserToDacl on Cygwin

2008-02-29 Thread Andrew Dunstan
Log Message: --- Don't call AddUserToDacl on Cygwin Tags: REL8_3_STABLE Modified Files: -- pgsql/src/bin/initdb: initdb.c (r1.152.2.1 -> r1.152.2.2) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/initdb/initdb.c?r1=1.152.2.1&r2=1.152.2.2)

[COMMITTERS] pgsql: Don't call AddUserToDacl on Cygwin

2008-02-29 Thread Andrew Dunstan
Log Message: --- Don't call AddUserToDacl on Cygwin Modified Files: -- pgsql/src/bin/initdb: initdb.c (r1.154 -> r1.155) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/initdb/initdb.c?r1=1.154&r2=1.155) pgsql/src/bin/pg_ctl: pg_ctl.c (r

Re: [COMMITTERS] pgsql: Fix handling of restricted processes for Windows Vista (mainly),

2008-02-29 Thread Andrew Dunstan
My testing on Vista shows we don't need them for Cygwin. cheers andrew Magnus Hagander wrote: AFAIK, we will if we want to run as Administrator on Vista. I'm not sure what we're doing there is actually compatible with it though. And do we care? I'm perfectly fine saying that we don't support

[COMMITTERS] pgsql: Remove long-unused and broken TCL_ARRAYS.

2008-02-29 Thread Alvaro Herrera
Log Message: --- Remove long-unused and broken TCL_ARRAYS. Modified Files: -- pgsql/src/backend/utils/adt: arrayfuncs.c (r1.140 -> r1.141) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/arrayfuncs.c?r1=1.140&r2=1.141) pgsql/src/in

Re: [COMMITTERS] pgsql: Fix handling of restricted processes for Windows Vista (mainly),

2008-02-29 Thread Magnus Hagander
AFAIK, we will if we want to run as Administrator on Vista. I'm not sure what we're doing there is actually compatible with it though. And do we care? I'm perfectly fine saying that we don't support that part on cygwin, and just #ifdef the whole thing out there? //Magnus Andrew Dunstan wrote:

Re: [COMMITTERS] pgsql: Fix handling of restricted processes for Windows Vista (mainly),

2008-02-29 Thread Andrew Dunstan
You have broken the Cygwin build (see buildfarm). Will we need those calls to AddUserToDacl() on Cygwin? If not, the simplest thing would be to #ifdef them out, I guess. cheers andrew Magnus Hagander wrote: Log Message: --- Fix handling of restricted processes for Windows Vista (ma

[COMMITTERS] pgsql: Reducing the assumed alignment of struct varlena means that the

2008-02-29 Thread Tom Lane
Log Message: --- Reducing the assumed alignment of struct varlena means that the compiler is also licensed to put a local variable declared that way at an unaligned address. Which will not work if the variable is then manipulated with SET_VARSIZE or other macros that assume alignment. So

[COMMITTERS] pgsql: Reducing the assumed alignment of struct varlena means that the

2008-02-29 Thread Tom Lane
Log Message: --- Reducing the assumed alignment of struct varlena means that the compiler is also licensed to put a local variable declared that way at an unaligned address. Which will not work if the variable is then manipulated with SET_VARSIZE or other macros that assume alignment. So

[COMMITTERS] pgbuildfarm - client-code: work around mingw's old version of File::Temp

2008-02-29 Thread User Andrewd
Log Message: --- work around mingw's old version of File::Temp Modified Files: -- client-code: run_build.pl (r1.91 -> r1.92) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbuildfarm/client-code/run_build.pl.diff?r1=1.91&r2=1.92) ---

Re: [COMMITTERS] pgsql: Fix handling of restricted processes for Windows Vista (mainly),

2008-02-29 Thread Andrew Dunstan
Magnus Hagander wrote: Uh, it was applied to HEAD. If you didn't get the email, check your spamfilters - it's in the archives so it was sent: http://archives.postgresql.org/pgsql-committers/2008-02/msg00363.php / OK, thanks. I have had odd delays in getting email from the lists, that must

Re: [COMMITTERS] pgsql: Fix handling of restricted processes for Windows Vista (mainly),

2008-02-29 Thread Magnus Hagander
Uh, it was applied to HEAD. If you didn't get the email, check your spamfilters - it's in the archives so it was sent: http://archives.postgresql.org/pgsql-committers/2008-02/msg00363.php //Magnus Andrew Dunstan wrote: What about HEAD? cheers andrew Magnus Hagander wrote: Log Message: ---

Re: [COMMITTERS] pgsql: Fix handling of restricted processes for Windows Vista (mainly),

2008-02-29 Thread Andrew Dunstan
What about HEAD? cheers andrew Magnus Hagander wrote: Log Message: --- Fix handling of restricted processes for Windows Vista (mainly), by explicitly adding back the user to the DACL of the new process. This fixes the failure case when executing as the Administrator user, which had no

[COMMITTERS] pgsql: Fix handling of restricted processes for Windows Vista (mainly),

2008-02-29 Thread Magnus Hagander
Log Message: --- Fix handling of restricted processes for Windows Vista (mainly), by explicitly adding back the user to the DACL of the new process. This fixes the failure case when executing as the Administrator user, which had no permissions left at all after we dropped the Administrators

[COMMITTERS] pgsql: Fix handling of restricted processes for Windows Vista (mainly),

2008-02-29 Thread Magnus Hagander
Log Message: --- Fix handling of restricted processes for Windows Vista (mainly), by explicitly adding back the user to the DACL of the new process. This fixes the failure case when executing as the Administrator user, which had no permissions left at all after we dropped the Administrators

[COMMITTERS] pgsql: Fix handling of restricted processes for Windows Vista (mainly),

2008-02-29 Thread Magnus Hagander
Log Message: --- Fix handling of restricted processes for Windows Vista (mainly), by explicitly adding back the user to the DACL of the new process. This fixes the failure case when executing as the Administrator user, which had no permissions left at all after we dropped the Administrators

[COMMITTERS] plpsm - plpgpsm: fix for 8.3

2008-02-29 Thread User Okbob
Log Message: --- fix for 8.3 Modified Files: -- plpgpsm/src: pl_comp.c (r1.23 -> r1.24) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/plpsm/plpgpsm/src/pl_comp.c.diff?r1=1.23&r2=1.24) ---(end of broadcast)---

[COMMITTERS] pgsql: Update wording: < * Add Oracle-style packages (Pavel) > * Add

2008-02-29 Thread Bruce Momjian
Log Message: --- Update wording: < * Add Oracle-style packages (Pavel) > * Add features of Oracle-style packages (Pavel) Modified Files: -- pgsql/doc: TODO (r1.2245 -> r1.2246) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/TODO?r1=1.2245&r2=1.2246)

[COMMITTERS] pgunittest - pgUnitTest_Rnd:

2008-02-29 Thread User Pgunittest
Log Message: --- Modified Files: -- pgUnitTest_Rnd/src/objects: pguDifferent.cpp (r1.5 -> r1.6) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgunittest/pgUnitTest_Rnd/src/objects/pguDifferent.cpp.diff?r1=1.5&r2=1.6) pguModulo.cpp (r1.5 -> r1.6)

[COMMITTERS] pgsql: Write the objfiles.txt rules in a way that is compatible with GNU

2008-02-29 Thread Peter Eisentraut
Log Message: --- Write the objfiles.txt rules in a way that is compatible with GNU make 3.78, and simpler, too. Modified Files: -- pgsql/src/backend: common.mk (r1.5 -> r1.6) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/common.mk?r1=1.5&r2=1.