[COMMITTERS] pgsql: Shave a few cycles in compare_pathkeys() by checking for

2009-02-27 Thread Tom Lane
Log Message: --- Shave a few cycles in compare_pathkeys() by checking for pointer-identical input lists before we grovel through the lists. This doesn't save much, but testing shows that the case of both inputs NIL is common enough that it saves something. And this is used enough to be a

[COMMITTERS] pgsql: Reduce the maximum value of vacuum_cost_delay and

2009-02-27 Thread Tom Lane
Log Message: --- Reduce the maximum value of vacuum_cost_delay and autovacuum_vacuum_cost_delay to 100ms (from 1000). This still seems to be comfortably larger than the useful range of the parameter, and it should help discourage people from picking uselessly large values. Tweak the docum

[COMMITTERS] pgsql: Temporarily (I hope) disable flattening of IN/EXISTS sublinks

2009-02-27 Thread Tom Lane
Log Message: --- Temporarily (I hope) disable flattening of IN/EXISTS sublinks that are within the ON clause of an outer join. Doing so is semantically correct but results in de-optimizing queries that were structured to take advantage of the sublink style of execution, as seen in recent c

[COMMITTERS] pgsql: Tighten up join ordering rules to account for recent more-careful

2009-02-27 Thread Tom Lane
Log Message: --- Tighten up join ordering rules to account for recent more-careful analysis of the associativity of antijoins. Also improve optimizer/README discussion of outer join ordering rules. Modified Files: -- pgsql/src/backend/optimizer: README (r1.48 -> r1

[COMMITTERS] pgsql: In CREATE CONVERSION, test that the given function is a valid

2009-02-27 Thread Heikki Linnakangas
Log Message: --- In CREATE CONVERSION, test that the given function is a valid conversion function for the specified source and destination encodings. We do that by calling the function with an empty string. If it can't perform the requested conversion, it will throw an error. Backport to

[COMMITTERS] pgsql: In CREATE CONVERSION, test that the given function is a valid

2009-02-27 Thread Heikki Linnakangas
Log Message: --- In CREATE CONVERSION, test that the given function is a valid conversion function for the specified source and destination encodings. We do that by calling the function with an empty string. If it can't perform the requested conversion, it will throw an error. Backport to

[COMMITTERS] pgsql: In CREATE CONVERSION, test that the given function is a valid

2009-02-27 Thread Heikki Linnakangas
Log Message: --- In CREATE CONVERSION, test that the given function is a valid conversion function for the specified source and destination encodings. We do that by calling the function with an empty string. If it can't perform the requested conversion, it will throw an error. Backport to

[COMMITTERS] pgsql: In CREATE CONVERSION, test that the given function is a valid

2009-02-27 Thread Heikki Linnakangas
Log Message: --- In CREATE CONVERSION, test that the given function is a valid conversion function for the specified source and destination encodings. We do that by calling the function with an empty string. If it can't perform the requested conversion, it will throw an error. Backport to

[COMMITTERS] pgsql: In CREATE CONVERSION, test that the given function is a valid

2009-02-27 Thread Heikki Linnakangas
Log Message: --- In CREATE CONVERSION, test that the given function is a valid conversion function for the specified source and destination encodings. We do that by calling the function with an empty string. If it can't perform the requested conversion, it will throw an error. Backport to

[COMMITTERS] pgsql: In CREATE CONVERSION, test that the given function is a valid

2009-02-27 Thread Heikki Linnakangas
Log Message: --- In CREATE CONVERSION, test that the given function is a valid conversion function for the specified source and destination encodings. We do that by calling the function with an empty string. If it can't perform the requested conversion, it will throw an error. Backport to

[COMMITTERS] pgstatspack - pgstatspack: Updated the readme to reflect the fact that

2009-02-27 Thread User Kpierno
Log Message: --- Updated the readme to reflect the fact that directory structure has changed and old installs should be removed prior to new file system install. Modified Files: -- pgstatspack: pgstatspack_README.txt (r1.3 -> r1.4) (http://cvs.pgfoundry.or

[COMMITTERS] pgsql: Set isnull for errm and sqlstate local variables when they're

2009-02-27 Thread Heikki Linnakangas
Log Message: --- Set isnull for errm and sqlstate local variables when they're free'd. Because they are out of scope for any code after that anyway, leaving isnull true should be harmless. However, PL/pgSQL Debugger doesn't seem to care about the scoping and crashed, per report by Robert Wa

[COMMITTERS] pgsql: Set isnull for errm and sqlstate local variables when they're

2009-02-27 Thread Heikki Linnakangas
Log Message: --- Set isnull for errm and sqlstate local variables when they're free'd. Because they are out of scope for any code after that anyway, leaving isnull true should be harmless. However, PL/pgSQL Debugger doesn't seem to care about the scoping and crashed, per report by Robert Wa

[COMMITTERS] pgsql: Set isnull for errm and sqlstate local variables when they're

2009-02-27 Thread Heikki Linnakangas
Log Message: --- Set isnull for errm and sqlstate local variables when they're free'd. Because they are out of scope for any code after that anyway, leaving isnull true should be harmless. However, PL/pgSQL Debugger doesn't seem to care about the scoping and crashed, per report by Robert Wa

[COMMITTERS] pgsql: Add the long options to the psql --help display, where they were

2009-02-27 Thread Peter Eisentraut
Log Message: --- Add the long options to the psql --help display, where they were curiously missing. Since this touches most lines of the help output, also change the mix of puts and printf calls to printf everywhere, for easier code editing and reviewing. Modified Files: --

[COMMITTERS] pgsql: Equip the programs installed by contrib with proper --help and

2009-02-27 Thread Peter Eisentraut
Log Message: --- Equip the programs installed by contrib with proper --help and --version options and normally formatted help output. Modified Files: -- pgsql/contrib/oid2name: oid2name.c (r1.34 -> r1.35) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/cont