Re: [COMMITTERS] pgsql: Fix a violation of WAL coding rules in the recent patch to

2009-08-23 Thread Heikki Linnakangas
Tom Lane wrote: > --- 74,80 >* That might actually be OK for the index scans, though. The newly inserted >* tuple wouldn't have an index pointer yet, so all tuples reachable from an >* index would still be visible to all other backends, and deletions > wouldn't > ! * be visible t

Re: [COMMITTERS] pgsql: Fix a violation of WAL coding rules in the recent patch to

2009-08-23 Thread Heikki Linnakangas
Tom Lane wrote: > Log Message: > --- > Fix a violation of WAL coding rules in the recent patch to include an > "all tuples visible" flag in heap page headers. The flag update *must* > be applied before calling XLogInsert, but heap_update and the tuple > moving routines in VACUUM FULL were

[COMMITTERS] pgsql: Run the "tablespace" regression test first not last.

2009-08-23 Thread Tom Lane
Log Message: --- Run the "tablespace" regression test first not last. The former placement renders useless one of the few test methodologies we have for WAL replay, which is to intentionally crash the system just after completing the regression tests and see if it recovers to the expected

[COMMITTERS] pgsql: Fix a violation of WAL coding rules in the recent patch to

2009-08-23 Thread Tom Lane
Log Message: --- Fix a violation of WAL coding rules in the recent patch to include an "all tuples visible" flag in heap page headers. The flag update *must* be applied before calling XLogInsert, but heap_update and the tuple moving routines in VACUUM FULL were ignoring this rule. A crash

[COMMITTERS] pgsql: Fix a violation of WAL coding rules in the recent patch to

2009-08-23 Thread Tom Lane
Log Message: --- Fix a violation of WAL coding rules in the recent patch to include an "all tuples visible" flag in heap page headers. The flag update *must* be applied before calling XLogInsert, but heap_update and the tuple moving routines in VACUUM FULL were ignoring this rule. A crash

[COMMITTERS] npgsql - Npgsql2: Last commit message should have been: Thanks Alaric

2009-08-23 Thread User Fxjr
Log Message: --- Last commit message should have been: Thanks Alaric for heads up and testcase Modified Files: -- Npgsql2/src/Npgsql: NpgsqlConnectionStringBuilder.cs (r1.10 -> r1.11) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/src/Npgsql/N

[COMMITTERS] npgsql - Npgsql2: [#1010668] Npgsql ConnectionStringBuilder provides no

2009-08-23 Thread User Fxjr
Log Message: --- [#1010668] Npgsql ConnectionStringBuilder provides no connectionstring properties. Now Npgsql correctly reports default connectionstring properties. Thanks Alaric Dailey for heads up and patch! Modified Files: -- Npgsql2/src/Npgsql: NpgsqlConnect

[COMMITTERS] pgsql: Make TRUNCATE do truncate-in-place when processing a relation

2009-08-23 Thread Tom Lane
Log Message: --- Make TRUNCATE do truncate-in-place when processing a relation that was created or previously truncated in the current (sub)transaction. This is safe since if the (sub)transaction later rolls back, we'd just discard the rel's current physical file anyway. This avoids unrea

[COMMITTERS] pgsql: Tweak ExecIndexEvalRuntimeKeys to forcibly detoast any toasted

2009-08-23 Thread Tom Lane
Log Message: --- Tweak ExecIndexEvalRuntimeKeys to forcibly detoast any toasted comparison values before they get passed to the index access method. This avoids repeated detoastings that will otherwise ensue as the comparison value is examined by various index support functions. We have s

[COMMITTERS] pgsql: Tweak ExecIndexEvalRuntimeKeys to forcibly detoast any toasted

2009-08-23 Thread Tom Lane
Log Message: --- Tweak ExecIndexEvalRuntimeKeys to forcibly detoast any toasted comparison values before they get passed to the index access method. This avoids repeated detoastings that will otherwise ensue as the comparison value is examined by various index support functions. We have s