[COMMITTERS] pgsql: Adjust pg_test_fsync to always do XLOG_BLCKSZ-sized writes, rath

Adjust pg_test_fsync to always do XLOG_BLCKSZ-sized writes, rather than always 8k writes, per suggestion from Tom. Also adjust open_sync output layout. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=64bc872761bc9bf730307957f09f44a3eabbe3af

Re: [COMMITTERS] pgsql: Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, bu

Tom Lane wrote: > Bruce Momjian writes: > > Sure I am willing to fix it. Should I have it always use the value of > > XLOG_BLCKSZ for its tests, and adjust the output text accordingly? > > Makes sense to me. OK, done with attached patch. I also cleaned up the open_sync size test output. The p

Re: [COMMITTERS] pgsql: Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, bu

Bruce Momjian writes: > Sure I am willing to fix it. Should I have it always use the value of > XLOG_BLCKSZ for its tests, and adjust the output text accordingly? Makes sense to me. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresq

Re: [COMMITTERS] pgsql: Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, bu

Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >> If you aren't willing to deal with a variable value for the block size, > >> please revert this patch. > > > The problem is that I have hard-coded 8k into various text strings and I > > didn't want to make that variable. How should

Re: [COMMITTERS] pgsql: Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, bu

Bruce Momjian writes: > Tom Lane wrote: >> If you aren't willing to deal with a variable value for the block size, >> please revert this patch. > The problem is that I have hard-coded 8k into various text strings and I > didn't want to make that variable. How should it behave if they are > using

Re: [COMMITTERS] pgsql: Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, bu

Tom Lane wrote: > Bruce Momjian writes: > > Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, but verify > > it is 8k as expected. > > -#define WRITE_SIZE (8 * 1024) /* 8k */ > +#if XLOG_BLCKSZ != 8 * 1024 /* 8k */ > +#error Unknown block size for test. > +#endif > > This seems li

Re: [COMMITTERS] pgsql: Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, bu

Bruce Momjian writes: > Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, but verify > it is 8k as expected. -#define WRITE_SIZE (8 * 1024) /* 8k */ +#if XLOG_BLCKSZ != 8 * 1024 /* 8k */ +#error Unknown block size for test. +#endif This seems like a pretty awful idea. Aren't you

[COMMITTERS] pgsql: Update warning about synchronous-commit durability, per suggesti

Update warning about synchronous-commit durability, per suggestion from Robvert Haas. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=a91c950658016162020258574fb98aba182a5eac Modified Files -- doc/src/sgml/perform.sgml |2 +- 1

[COMMITTERS] pgsql: Correct ALTER TYPE -> SET DATA TYPE in ALTER TABLE documentation

Correct ALTER TYPE -> SET DATA TYPE in ALTER TABLE documentation. The latter is the correct name of the operation to change the data type of a column. Noah Misch Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=2b2b2ae2aa4a7089aee729e67bb3231

[COMMITTERS] pgsql: Correct ALTER TYPE -> SET DATA TYPE in ALTER TABLE documentation

Correct ALTER TYPE -> SET DATA TYPE in ALTER TABLE documentation. The latter is the correct name of the operation to change the data type of a column. Noah Misch Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=2c3e29299842f6de74ff96d3

[COMMITTERS] pgsql: Remove old claim that ExclusiveLock is sometimes taken on system

Remove old claim that ExclusiveLock is sometimes taken on system catalogs. We used to do that on pg_listener, but pg_listener is no more. Also add a bit more documentation for ShareRowExclusive mode. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commit

[COMMITTERS] pgsql: Fix thinko in ALTER FOREIGN TABLE documentation.

Fix thinko in ALTER FOREIGN TABLE documentation. Noah Misch Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=558d1c95ae6afb8728f70a150c593f7e7aa5fac1 Modified Files -- doc/src/sgml/ref/alter_foreign_table.sgml |2 +- 1 files ch

[COMMITTERS] pgsql: Replace pg_class.relhasexclusion with pg_index.indisexclusion.

Replace pg_class.relhasexclusion with pg_index.indisexclusion. There isn't any need to track this state on a table-wide basis, and trying to do so introduces undesirable semantic fuzziness. Move the flag to pg_index, where it clearly describes just a single index and can be immutable after index

[COMMITTERS] [PGBuildFarm/server-code] ffe3a5: remove options not used in failures case

Branch: refs/heads/master Home: https://github.com/PGBuildFarm/server-code Commit: ffe3a5f17b995075ccf28c773786015b83e45f75 https://github.com/PGBuildFarm/server-code/commit/ffe3a5f17b995075ccf28c773786015b83e45f75 Author: Andrew Dunstan Date: 2011-01-24 (Mon, 24 Jan 2011) Changed paths

[COMMITTERS] pgsql: Implement ALTER TABLE ADD UNIQUE/PRIMARY KEY USING INDEX.

Implement ALTER TABLE ADD UNIQUE/PRIMARY KEY USING INDEX. This feature allows a unique or pkey constraint to be created using an already-existing unique index. While the constraint isn't very functionally different from the bare index, it's nice to be able to do that for documentation purposes.

[COMMITTERS] pgsql: Typo fix for MemSet size.

Typo fix for MemSet size. Fujii Masao Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=966d4f52c258aba8187d61fdc1e10b80d560f07c Modified Files -- src/backend/replication/basebackup.c |2 +- 1 files changed, 1 insertions(+), 1 d