Re: [COMMITTERS] pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc

2011-05-24 Thread Heikki Linnakangas
On 25.05.2011 00:58, Tom Lane wrote: Heikki Linnakangas writes: On 22.05.2011 21:18, Tom Lane wrote: I'm also concerned that you've probably added cycles on net to MemoryContextAlloc (where it's no longer possible to tail-call AllocSetAlloc), which could very easily cost more cycles on most wo

[COMMITTERS] pgsql: Convert builddoc.bat into a perl script that actually works.

2011-05-24 Thread Andrew Dunstan
Convert builddoc.bat into a perl script that actually works. The old .bat file wasn't working for reasons that are unclear, and which it did not seem worth the trouble to ascertain. The new perl script has been tested and is known to work. Soon it will be tested regularly on the buildfarm. The .ba

[COMMITTERS] pgsql: Add C comment about why we don't spell out "month" in interval v

2011-05-24 Thread Bruce Momjian
Add C comment about why we don't spell out "month" in interval values. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0711a8b2b340ee0b0a7fd7ea2ac0fa6aee4708ae Modified Files -- src/backend/utils/adt/datetime.c |5 + 1 files changed, 5 insertions(+

Re: [COMMITTERS] pgsql: Support RIGHT and FULL OUTER JOIN in hash joins.

2011-05-24 Thread Hitoshi Harada
2011/5/24 Tom Lane : > Hitoshi Harada writes: >> It looks to me like mergejoin_allowed should be initialized to false. >> If enable_mergejoin is off and jointype != JOIN_FULL then mergejoin is >> not allowed, isn't it? Sorry for noise if it's only my confusing. > > No, the code is correct as-is: w

[COMMITTERS] pgsql: Grammar cleanup for src/test/isolation/README

2011-05-24 Thread Tom Lane
Grammar cleanup for src/test/isolation/README Josh Kupershmidt Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/446d5d32aedcca378578c8fe1c2eed34df92a238 Modified Files -- src/test/isolation/README |8 1 files changed, 4 insertions(+), 4 deleti

Re: [COMMITTERS] pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc

2011-05-24 Thread Tom Lane
Heikki Linnakangas writes: > On 22.05.2011 21:18, Tom Lane wrote: >> I'm also concerned that you've probably >> added cycles on net to MemoryContextAlloc (where it's no longer possible >> to tail-call AllocSetAlloc), which could very easily cost more cycles on >> most workloads than could ever be

[COMMITTERS] pgsql: Cleanup for pull-up-isReset patch.

2011-05-24 Thread Tom Lane
Cleanup for pull-up-isReset patch. Clear isReset before, not after, calling the context-specific alloc method, so as to preserve the option to do a tail call in MemoryContextAlloc (and also so this code isn't assuming that a failed alloc call won't have changed the context's state before failing).

Re: [COMMITTERS] pgsql: Add a "local" replication sample entry

2011-05-24 Thread Magnus Hagander
On Tue, May 24, 2011 at 16:46, Peter Eisentraut wrote: > On tis, 2011-05-24 at 20:41 +, Thom Brown wrote: >> On 24 May 2011 20:24, Magnus Hagander wrote: >> >> > Hmm. We intentionally did not include the local case, because there >> > really aren't any usecases for it. It seems you disagree?

Re: [COMMITTERS] pgsql: Add a "local" replication sample entry

2011-05-24 Thread Peter Eisentraut
On tis, 2011-05-24 at 20:41 +, Thom Brown wrote: > On 24 May 2011 20:24, Magnus Hagander wrote: > > > Hmm. We intentionally did not include the local case, because there > > really aren't any usecases for it. It seems you disagree? ;) > > > > pg_basebackup? Exactly -- Sent via pgsql-comm

Re: [COMMITTERS] pgsql: Add a "local" replication sample entry

2011-05-24 Thread Thom Brown
On 24 May 2011 20:24, Magnus Hagander wrote: > Hmm. We intentionally did not include the local case, because there > really aren't any usecases for it. It seems you disagree? ;) > pg_basebackup? -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 Enterp

Re: [COMMITTERS] pgsql: Add a "local" replication sample entry

2011-05-24 Thread Magnus Hagander
Hmm. We intentionally did not include the local case, because there really aren't any usecases for it. It seems you disagree? ;) //Magnus On Tue, May 24, 2011 at 14:36, Peter Eisentraut wrote: > Add a "local" replication sample entry > > Also adjust alignment a bit to distinguish commented out f

[COMMITTERS] pgsql: In pg_upgrade, do case-insensitive checks of locale, encoding, a

2011-05-24 Thread Bruce Momjian
In pg_upgrade, do case-insensitive checks of locale, encoding, and ctype because these are often inconsistently capitalized. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/11c08c3fd79f1fd5a83f9156fc1c43c7be3453ce Modified Files -- contrib/pg_upgrade/chec

[COMMITTERS] pgsql: Adjust configure's probe for libselinux so it rejects too-old ve

2011-05-24 Thread Tom Lane
Adjust configure's probe for libselinux so it rejects too-old versions. We need at least version 2.0.93, so probe for a function that was added in that version. Kaigai Kohei Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8ff1f6a78c4fb48337f671f1586839cef5d4b940 Mo

[COMMITTERS] pgsql: Message improvements

2011-05-24 Thread Peter Eisentraut
Message improvements Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c8d45152fa04c77370fc16faf0727c0f52739f0a Modified Files -- src/bin/pg_basebackup/pg_basebackup.c |8 1 files changed, 4 insertions(+), 4 deletions(-) -- Sent via pgsql-com

[COMMITTERS] pgsql: Add a "local" replication sample entry

2011-05-24 Thread Peter Eisentraut
Add a "local" replication sample entry Also adjust alignment a bit to distinguish commented out from comment. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f50655900a865d65d17bb79f57f1d8c48b1cb266 Modified Files -- src/backend/libpq/pg_hba.conf.sample

[COMMITTERS] pgsql: Avoid uninitialized bits in the result of QTN2QT().

2011-05-24 Thread Tom Lane
Avoid uninitialized bits in the result of QTN2QT(). Found with additional valgrind testing. Noah Misch Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c2a366d9d9d3b1e2dc4c65d9a9fab5c1c0d6c246 Modified Files -- src/backend/utils/adt/tsquery_util.c

[COMMITTERS] pgsql: Avoid uninitialized bits in the result of QTN2QT().

2011-05-24 Thread Tom Lane
Avoid uninitialized bits in the result of QTN2QT(). Found with additional valgrind testing. Noah Misch Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9a57eafe9d29280fa65c5912df38fc8650507035 Modified Files -- src/backend/utils/adt/tsquery_util.c

[COMMITTERS] pgsql: Avoid uninitialized bits in the result of QTN2QT().

2011-05-24 Thread Tom Lane
Avoid uninitialized bits in the result of QTN2QT(). Found with additional valgrind testing. Noah Misch Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cc24fb418d8da7ed93f9cd936f7da8fc7e0381bf Modified Files -- src/backend/utils/adt/tsquery_util.c |2

[COMMITTERS] pgsql: Avoid uninitialized bits in the result of QTN2QT().

2011-05-24 Thread Tom Lane
Avoid uninitialized bits in the result of QTN2QT(). Found with additional valgrind testing. Noah Misch Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/bd9215a346da64467d9b070715bf40e412ba6b14 Modified Files -- src/backend/utils/adt/tsquery_util.c

Re: [COMMITTERS] pgsql: Support RIGHT and FULL OUTER JOIN in hash joins.

2011-05-24 Thread Tom Lane
Hitoshi Harada writes: > It looks to me like mergejoin_allowed should be initialized to false. > If enable_mergejoin is off and jointype != JOIN_FULL then mergejoin is > not allowed, isn't it? Sorry for noise if it's only my confusing. No, the code is correct as-is: we need the flag to be set tru

Re: [COMMITTERS] pgsql: Support RIGHT and FULL OUTER JOIN in hash joins.

2011-05-24 Thread Hitoshi Harada
2011/1/1 Tom Lane : > Robert Haas writes: >> On Thu, Dec 30, 2010 at 9:55 PM, Tom Lane wrote: >>> On reflection, how about inverting the flag's value and calling it >>> mergejoin_allowed or some such? > >> Yeah, that's better. > > OK, done that way. It looks to me like mergejoin_allowed should b