[COMMITTERS] pgsql: Fix grammar and spelling in log message.

2011-08-09 Thread Heikki Linnakangas
Fix grammar and spelling in log message. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5b6c8436d7e696cced4db14c885eff23f87dc712 Modified Files -- src/backend/postmaster/postmaster.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) -- Sent

[COMMITTERS] pgsql: Change the way string relopts are allocated.

2011-08-09 Thread Heikki Linnakangas
Change the way string relopts are allocated. Don't try to allocate the default value for a string relopt in the same palloc chunk as the relopt_string struct. That didn't work too well if you added a built-in string relopt in the stringRelOpts array, as it's not possible to have an initializer for

[COMMITTERS] pgsql: Use clearer notation for getnameinfo() return handling

2011-08-09 Thread Peter Eisentraut
Use clearer notation for getnameinfo() return handling Writing if (getnameinfo(...)) handle_error(); reads quite strangely, so use something like if (getnameinfo(...) != 0) handle_error(); instead. Branch -- master Details --- http://git.postgresql.org/pg/comm

[COMMITTERS] pgsql: Avoid creating PlaceHolderVars immediately within PlaceHolderVar

2011-08-09 Thread Tom Lane
Avoid creating PlaceHolderVars immediately within PlaceHolderVars. Such a construction is useless since the lower PlaceHolderVar is already nullable; no need to make it more so. Noted while pursuing bug #6154. This is just a minor planner efficiency improvement, since the final plan will come ou

[COMMITTERS] pgsql: Documentation improvement and minor code cleanups for the latch

2011-08-09 Thread Tom Lane
Documentation improvement and minor code cleanups for the latch facility. Improve the documentation around weak-memory-ordering risks, and do a pass of general editorialization on the comments in the latch code. Make the Windows latch code more like the Unix latch code where feasible; in particul

[COMMITTERS] pgsql: Documentation improvement and minor code cleanups for the latch

2011-08-09 Thread Tom Lane
Documentation improvement and minor code cleanups for the latch facility. Improve the documentation around weak-memory-ordering risks, and do a pass of general editorialization on the comments in the latch code. Make the Windows latch code more like the Unix latch code where feasible; in particul

[COMMITTERS] pgsql: Measure WaitLatch's timeout parameter in milliseconds, not micro

2011-08-09 Thread Tom Lane
Measure WaitLatch's timeout parameter in milliseconds, not microseconds. The original definition had the problem that timeouts exceeding about 2100 seconds couldn't be specified on 32-bit machines. Milliseconds seem like sufficient resolution, and finer grain than that would be fantasy anyway on

[COMMITTERS] pgsql: Measure WaitLatch's timeout parameter in milliseconds, not micro

2011-08-09 Thread Tom Lane
Measure WaitLatch's timeout parameter in milliseconds, not microseconds. The original definition had the problem that timeouts exceeding about 2100 seconds couldn't be specified on 32-bit machines. Milliseconds seem like sufficient resolution, and finer grain than that would be fantasy anyway on

[COMMITTERS] pgsql: If backup-end record is not seen, and we reach end of recovery f

2011-08-09 Thread Heikki Linnakangas
If backup-end record is not seen, and we reach end of recovery from a streamed backup, throw an error and refuse to start up. The restore has not finished correctly in that case and the data directory is possibly corrupt. We already errored out in case of archive recovery, but could not during cras

[COMMITTERS] pgsql: Oops, we're working on version 9.2 already, not 9.1. Update the

2011-08-09 Thread Heikki Linnakangas
Oops, we're working on version 9.2 already, not 9.1. Update the PG_CONTROL_VERSION accordingly; I updated it wrong in previous commit. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1f1b70a7cf957b88433f871f3732ad5701b6ad8b Modified Files -- src/include/c