[COMMITTERS] pgsql: Fix error detection in contrib/pgcrypto's encrypt_iv() and decry

2012-01-27 Thread Tom Lane
Fix error detection in contrib/pgcrypto's encrypt_iv() and decrypt_iv(). Due to oversights, the encrypt_iv() and decrypt_iv() functions failed to report certain types of invalid-input errors, and would instead return random garbage values. Marko Kreen, per report from Stefan Kaltenbrunner Branch

[COMMITTERS] pgsql: Fix error detection in contrib/pgcrypto's encrypt_iv() and decry

2012-01-27 Thread Tom Lane
Fix error detection in contrib/pgcrypto's encrypt_iv() and decrypt_iv(). Due to oversights, the encrypt_iv() and decrypt_iv() functions failed to report certain types of invalid-input errors, and would instead return random garbage values. Marko Kreen, per report from Stefan Kaltenbrunner Branch

[COMMITTERS] pgsql: Fix error detection in contrib/pgcrypto's encrypt_iv() and decry

2012-01-27 Thread Tom Lane
Fix error detection in contrib/pgcrypto's encrypt_iv() and decrypt_iv(). Due to oversights, the encrypt_iv() and decrypt_iv() functions failed to report certain types of invalid-input errors, and would instead return random garbage values. Marko Kreen, per report from Stefan Kaltenbrunner Branch

[COMMITTERS] pgsql: Fix error detection in contrib/pgcrypto's encrypt_iv() and decry

2012-01-27 Thread Tom Lane
Fix error detection in contrib/pgcrypto's encrypt_iv() and decrypt_iv(). Due to oversights, the encrypt_iv() and decrypt_iv() functions failed to report certain types of invalid-input errors, and would instead return random garbage values. Marko Kreen, per report from Stefan Kaltenbrunner Branch

[COMMITTERS] pgsql: Fix error detection in contrib/pgcrypto's encrypt_iv() and decry

2012-01-27 Thread Tom Lane
Fix error detection in contrib/pgcrypto's encrypt_iv() and decrypt_iv(). Due to oversights, the encrypt_iv() and decrypt_iv() functions failed to report certain types of invalid-input errors, and would instead return random garbage values. Marko Kreen, per report from Stefan Kaltenbrunner Branch

[COMMITTERS] pgsql: Undo 8.4-era lobotomization of subquery pullup rules.

2012-01-27 Thread Tom Lane
Undo 8.4-era lobotomization of subquery pullup rules. After the planner was fixed to convert some IN/EXISTS subqueries into semijoins or antijoins, we had to prevent it from doing that in some cases where the plans risked getting much worse. The reason the plans got worse was that in the unoptimi

[COMMITTERS] pgsql: Use parameterized paths to generate inner indexscans more flexib

2012-01-27 Thread Tom Lane
Use parameterized paths to generate inner indexscans more flexibly. This patch fixes the planner so that it can generate nestloop-with- inner-indexscan plans even with one or more levels of joining between the indexscan and the nestloop join that is supplying the parameter. The executor was fixed

[COMMITTERS] pgsql: Show default privileges in information schema

2012-01-27 Thread Peter Eisentraut
Show default privileges in information schema Hitherto, the information schema only showed explicitly granted privileges that were visible in the *acl catalog columns. If no privileges had been granted, the implicit privileges were not shown. To fix that, add an SQL-accessible version of the acl

[COMMITTERS] pgsql: Revert unfortunate whitespace change

2012-01-27 Thread Peter Eisentraut
Revert unfortunate whitespace change In e5e2fc842c418432756d8b5825ff107c6c5fc4c3, blank lines were removed after a comment block, which now looks as though the comment refers to the immediately following code, but it actually refers to the preceding code. So put the blank lines back. Branch

[COMMITTERS] pgsql: Disallow ALTER DOMAIN on non-domain type everywhere

2012-01-27 Thread Peter Eisentraut
Disallow ALTER DOMAIN on non-domain type everywhere This has been the behavior already in most cases, but through omission, ALTER DOMAIN / OWNER TO and ALTER DOMAIN / SET SCHEMA would silently work on non-domain types as well. Branch -- master Details --- http://git.postgresql.org/pg/com

[COMMITTERS] pgsql: Hide most variable-length fields from Form_pg_* structs

2012-01-27 Thread Peter Eisentraut
Hide most variable-length fields from Form_pg_* structs Those fields only appear in the structs so that genbki.pl can create the BKI bootstrap files for the catalogs. But they are not actually usable from C. So hiding them can prevent coding mistakes, saves stack space, and can help the compiler

[COMMITTERS] pgsql: Do not access indclass through Form_pg_index

2012-01-27 Thread Peter Eisentraut
Do not access indclass through Form_pg_index Normally, accessing variable-length members of catalog structures past the first one doesn't work at all. Here, it happened to work because indnatts was checked to be 1, and so the defined FormData_pg_index layout, using int2vector[1] and oidvector[1]

[COMMITTERS] pgsql: Document that COUNT(*) might not need a seq scan any more.

2012-01-27 Thread Robert Haas
Document that COUNT(*) might not need a seq scan any more. Noted by Josh Kupershmidt. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/eb6af016fc04392c41106ac866072914bf66ecd0 Modified Files -- doc/src/sgml/func.sgml |6 -- 1 files changed, 4 inser

[COMMITTERS] pgsql: Document that analyzing an empty table doesn't update the statis

2012-01-27 Thread Robert Haas
Document that analyzing an empty table doesn't update the statistics. Per a suggestion from Sergey Konoplev Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/db6de5b71ef2d91dde94fc0de8adf45372bc332d Modified Files -- doc/src/sgml/ref/analyze.sgml |6 ++

Re: [COMMITTERS] pgsql: Make bgwriter sleep longer when it has no work to do, to save el

2012-01-27 Thread Heikki Linnakangas
On 27.01.2012 16:43, Peter Geoghegan wrote: On 26 January 2012 16:43, Heikki Linnakangas wrote: Make bgwriter sleep longer when it has no work to do, to save electricity. Perhaps this is pedantic, but shouldn't we be initialising bgwriterLatch to NULL within InitProcGlobal(), much as we alrea

[COMMITTERS] pgsql: Initialize the new bgwriterLatch field properly.

2012-01-27 Thread Heikki Linnakangas
Initialize the new bgwriterLatch field properly. Peter Geoghegan Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cf3fff6326299deca77c1387df31d24aea36e2e1 Modified Files -- src/backend/storage/lmgr/proc.c |1 + 1 files changed, 1 insertions(+), 0 delet

[COMMITTERS] pgsql: pg_dump: Move connection-setup code to a separate function.

2012-01-27 Thread Robert Haas
pg_dump: Move connection-setup code to a separate function. Parallel dump will need to repeat these steps for each new connection, so it's better to have this logic in its own function. Extracted (with some changes) from a much larger patch by Joachim Wieland. Branch -- master Details -

Re: [COMMITTERS] pgsql: Make bgwriter sleep longer when it has no work to do, to save el

2012-01-27 Thread Peter Geoghegan
On 26 January 2012 16:43, Heikki Linnakangas wrote: > Make bgwriter sleep longer when it has no work to do, to save electricity. Perhaps this is pedantic, but shouldn't we be initialising bgwriterLatch to NULL within InitProcGlobal(), much as we already do for the other pointers in that structure

[COMMITTERS] pgsql: Fix copy-paste error in docs.

2012-01-27 Thread Heikki Linnakangas
Fix copy-paste error in docs. Dean Rasheed Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/59c67ecdd39725aaee0db6e09f399c8e6c248f22 Modified Files -- doc/src/sgml/ref/alter_foreign_table.sgml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[COMMITTERS] pgsql: Fix wording, per Peter Geoghegan

2012-01-27 Thread Magnus Hagander
Fix wording, per Peter Geoghegan Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c9f14bb4acf3e5caff97ef0a639c3ee911932e1c Modified Files -- doc/src/sgml/auto-explain.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-comm

[COMMITTERS] pgsql: Fix wording, per Peter Geoghegan

2012-01-27 Thread Magnus Hagander
Fix wording, per Peter Geoghegan Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b7922a6dd0ec2ff949751d77b004576c820de19c Modified Files -- doc/src/sgml/auto-explain.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgs

[COMMITTERS] pgsql: Fix wording, per Peter Geoghegan

2012-01-27 Thread Magnus Hagander
Fix wording, per Peter Geoghegan Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5b242e5addcb2e337c3d9fcc637d092c2b45625b Modified Files -- doc/src/sgml/auto-explain.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgs

[COMMITTERS] pgsql: Fix wording, per Peter Geoghegan

2012-01-27 Thread Magnus Hagander
Fix wording, per Peter Geoghegan Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/2f66c1a2ff8918086099cdfb3b9d9759c8658382 Modified Files -- doc/src/sgml/auto-explain.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgs