[COMMITTERS] pgsql: Improve discussion of setting server parameters.

2012-05-10 Thread Tom Lane
Improve discussion of setting server parameters. Rewrite description of "include_if_exists" for clarity. Add subsection headings to make the structure of the page a little clearer. A couple other minor improvements too. Josh Kupershmidt and Tom Lane Branch -- master Details --- http:/

[COMMITTERS] pgsql: Revert catalog bump; was post-beta1, and unnecessary.

2012-05-10 Thread Bruce Momjian
Revert catalog bump; was post-beta1, and unnecessary. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ee24de40018fe5b6f8dc015e56e41c7889622c33 Modified Files -- src/include/catalog/catversion.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[COMMITTERS] pgsql: Update comment for 'name' data type to say 63 "bytes".

2012-05-10 Thread Bruce Momjian
Update comment for 'name' data type to say 63 "bytes". Catalog version bump so everyone has the same comment for beta1. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d2fe836cd28dbaff86f63b77da8d7ea0efa9a9c3 Modified Files -- src/include/catalog/catvers

[COMMITTERS] pgsql: Stamp 9.2beta1.

2012-05-10 Thread Tom Lane
Stamp 9.2beta1. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f70fa835e08eee4cb2dc0f72d66cf633089c37e8 Modified Files -- configure | 18 +- configure.in |2 +- doc/bug.template |2

[COMMITTERS] pgsql: Tweak documentation wording to avoid "pdfendlink" failure.

2012-05-10 Thread Tom Lane
Tweak documentation wording to avoid "pdfendlink" failure. HEAD documentation was failing to build as US PDF for me, because a link to "CREATE CAST" was getting split across pages. Adjust wording to remove this rather gratuitous cross-reference. Branch -- master Details --- http://git.p

Re: [COMMITTERS] pgsql: Make WaitLatch's WL_POSTMASTER_DEATH result trustworthy; simplif

2012-05-10 Thread Tom Lane
Peter Geoghegan writes: > On 10 May 2012 19:35, Tom Lane wrote: >> Remove weasel wording about falsely-set result bits from >> WaitLatch's API contract. > Aren't those weasel words still applicable to the case where sock != > PGINVALID_SOCKET ? I don't think so. WaitLatch is honestly reporting

[COMMITTERS] pgsql: Temporarily revert stats collector latch changes so we can ship

2012-05-10 Thread Tom Lane
Temporarily revert stats collector latch changes so we can ship beta1. This patch reverts commit 49340037ee3ab46cb24144a86705e35f272c24d5 and some follow-on tweaking in pgstat.c. While the basic scheme of latch-ifying the stats collector seems sound enough, it's failing on most Windows buildfarm

Re: [COMMITTERS] pgsql: Make WaitLatch's WL_POSTMASTER_DEATH result trustworthy; simplif

2012-05-10 Thread Peter Geoghegan
On 10 May 2012 19:35, Tom Lane wrote: > Remove weasel wording about falsely-set result bits from > WaitLatch's API contract. Aren't those weasel words still applicable to the case where sock != PGINVALID_SOCKET ? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

[COMMITTERS] pgsql: Merge visibility map crash-safety into index-only scan release n

2012-05-10 Thread Bruce Momjian
Merge visibility map crash-safety into index-only scan release note item, per Robert Haas. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5428ff4af84e488c7f0629108cd12ff51125e09f Modified Files -- doc/src/sgml/release-9.2.sgml | 16 +++- 1 f

[COMMITTERS] pgsql: Make WaitLatch's WL_POSTMASTER_DEATH result trustworthy; simplif

2012-05-10 Thread Tom Lane
Make WaitLatch's WL_POSTMASTER_DEATH result trustworthy; simplify callers. Per a suggestion from Peter Geoghegan, make WaitLatch responsible for verifying that the WL_POSTMASTER_DEATH bit it returns is truthful (by testing PostmasterIsAlive). Then simplify its callers, who no longer need to do th

Re: [COMMITTERS] pgsql: Remove unportable use of SGML character-code entity.

2012-05-10 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of jue may 10 13:52:22 -0400 2012: > On Thu, May 10, 2012 at 04:22:40PM +, Tom Lane wrote: > > Remove unportable use of SGML character-code entity. > > > > It'd be nice to be able to spell Jan Urbanski's name with the correct > > accent marks, but we have

[COMMITTERS] pgsql: Properly capitalize the TimeZone parameter

2012-05-10 Thread Peter Eisentraut
Properly capitalize the TimeZone parameter For better or worse, it is implemented in mixed case, so document it as such, at least in the main listing, like DateStyle. Josh Kupershmidt Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/586d356bc5af1aa61f965f6ba1cbeb1533

Re: [COMMITTERS] pgsql: Remove unportable use of SGML character-code entity.

2012-05-10 Thread Bruce Momjian
On Thu, May 10, 2012 at 04:22:40PM +, Tom Lane wrote: > Remove unportable use of SGML character-code entity. > > It'd be nice to be able to spell Jan Urbanski's name with the correct > accent marks, but we haven't yet found a way that works in everybody's > docs toolchain. This way definitely

[COMMITTERS] pgsql: Add comma after "Previously" as suggested by Josh Kupershmidt

2012-05-10 Thread Bruce Momjian
Add comma after "Previously" as suggested by Josh Kupershmidt Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/45f6fb2713feb21bc24fa907bad575008fd680ef Modified Files -- doc/src/sgml/release-9.2.sgml | 10 +- 1 files changed, 5 insertions(+), 5 de

[COMMITTERS] pgsql: PL/Python: Update incorrect comment

2012-05-10 Thread Peter Eisentraut
PL/Python: Update incorrect comment Jan Urbański Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1540d3bf4d405278533377ba81dbbf1c857eaec0 Modified Files -- src/pl/plpython/plpy_resultobject.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -

[COMMITTERS] pgsql: PL/Python: Fix slicing support for result objects for Python 3

2012-05-10 Thread Peter Eisentraut
PL/Python: Fix slicing support for result objects for Python 3 The old way of implementing slicing support by implementing PySequenceMethods.sq_slice no longer works in Python 3. You now have to implement PyMappingMethods.mp_subscript. Do this by simply proxying the call to the wrapped list of r

[COMMITTERS] pgsql: Fix Windows implementation of PGSemaphoreLock.

2012-05-10 Thread Tom Lane
Fix Windows implementation of PGSemaphoreLock. The original coding failed to reset ImmediateInterruptOK before returning, which would potentially allow a subsequent query-cancel interrupt to be accepted at an unsafe point. This is a really nasty bug since it's so hard to predict the consequences,

[COMMITTERS] pgsql: Fix Windows implementation of PGSemaphoreLock.

2012-05-10 Thread Tom Lane
Fix Windows implementation of PGSemaphoreLock. The original coding failed to reset ImmediateInterruptOK before returning, which would potentially allow a subsequent query-cancel interrupt to be accepted at an unsafe point. This is a really nasty bug since it's so hard to predict the consequences,

[COMMITTERS] pgsql: Fix Windows implementation of PGSemaphoreLock.

2012-05-10 Thread Tom Lane
Fix Windows implementation of PGSemaphoreLock. The original coding failed to reset ImmediateInterruptOK before returning, which would potentially allow a subsequent query-cancel interrupt to be accepted at an unsafe point. This is a really nasty bug since it's so hard to predict the consequences,

[COMMITTERS] pgsql: Fix Windows implementation of PGSemaphoreLock.

2012-05-10 Thread Tom Lane
Fix Windows implementation of PGSemaphoreLock. The original coding failed to reset ImmediateInterruptOK before returning, which would potentially allow a subsequent query-cancel interrupt to be accepted at an unsafe point. This is a really nasty bug since it's so hard to predict the consequences,

[COMMITTERS] pgsql: Fix Windows implementation of PGSemaphoreLock.

2012-05-10 Thread Tom Lane
Fix Windows implementation of PGSemaphoreLock. The original coding failed to reset ImmediateInterruptOK before returning, which would potentially allow a subsequent query-cancel interrupt to be accepted at an unsafe point. This is a really nasty bug since it's so hard to predict the consequences,

[COMMITTERS] pgsql: 9.2 release note updates from Peter Geoghegan

2012-05-10 Thread Bruce Momjian
9.2 release note updates from Peter Geoghegan Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ffda90f3afe3f4db10127d2b853dfe4230720873 Modified Files -- doc/src/sgml/release-9.2.sgml | 47 + 1 files changed, 24 ins

[COMMITTERS] pgsql: Improve Windows implementation of WaitLatch/WaitLatchOrSocket.

2012-05-10 Thread Tom Lane
Improve Windows implementation of WaitLatch/WaitLatchOrSocket. Ensure that signal handlers are serviced before this function returns. This should make the behavior more like Unix. Also, add some more error checking, and make some other cosmetic improvements. No back-patch since it's not clear wh

[COMMITTERS] pgsql: New 9.2 SSL parameters are GUC, not libpq, per Magnus's observat

2012-05-10 Thread Bruce Momjian
New 9.2 SSL parameters are GUC, not libpq, per Magnus's observation. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/53216e3992665eda1570650f4047efa4202e7173 Modified Files -- doc/src/sgml/release-9.2.sgml |2 +- 1 files changed, 1 insertions(+), 1 del

[COMMITTERS] pgsql: Add 9.2 release note suggestions from Heikki,

2012-05-10 Thread Bruce Momjian
Add 9.2 release note suggestions from Heikki, Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/deb2c6e381e26b4e3c042b16990dd3821f6757b3 Modified Files -- doc/src/sgml/release-9.2.sgml | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) --

[COMMITTERS] pgsql: Whitespace cleanup

2012-05-10 Thread Peter Eisentraut
Whitespace cleanup Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d9bb75dd37ae1642392b8638c99bfeb9f9890c0a Modified Files -- doc/src/sgml/pgtesttiming.sgml | 190 +++- 1 files changed, 92 insertions(+), 98 deletions(-)

[COMMITTERS] pgsql: Python 2.2 is no longer supported

2012-05-10 Thread Peter Eisentraut
Python 2.2 is no longer supported It was already on its last legs, and it turns out that it was accidentally broken in commit 89e850e6fda9e4e441712012abe971fe938d595a and no one cared. So remove the rest the support for it and update the documentation to indicate that Python 2.3 is now required.

[COMMITTERS] pgsql: 9.2 release note adjustments from Robert Haas.

2012-05-10 Thread Bruce Momjian
9.2 release note adjustments from Robert Haas. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1908a6796a2e61e78c9a31807076746c34ea6a15 Modified Files -- doc/src/sgml/release-9.2.sgml | 33 + 1 files changed, 5 insertions(

[COMMITTERS] pgsql: Update entitiy escapes docs; must be Latin1.

2012-05-10 Thread Bruce Momjian
Update entitiy escapes docs; must be Latin1. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/77bfdb11d09a3adef1f9310201e1b2fe38ee47bd Modified Files -- doc/src/sgml/release.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pg

[COMMITTERS] pgsql: Another doc fix for HTML entities.

2012-05-10 Thread Bruce Momjian
Another doc fix for HTML entities. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d413efe9e14357577a3b7537784eb856ab6525ba Modified Files -- doc/src/sgml/release.sgml |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- Sent via pgsql-commit

[COMMITTERS] pgsql: Remove URL that suggested numeric HTML entities.

2012-05-10 Thread Bruce Momjian
Remove URL that suggested numeric HTML entities. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/38cd7cc0bcd6fcbfa8942e28f6aee84ab9fbb651 Modified Files -- doc/src/sgml/release.sgml |1 - 1 files changed, 0 insertions(+), 1 deletions(-) -- Sent via

[COMMITTERS] pgsql: Remove unportable use of SGML character-code entity.

2012-05-10 Thread Tom Lane
Remove unportable use of SGML character-code entity. It'd be nice to be able to spell Jan Urbanski's name with the correct accent marks, but we haven't yet found a way that works in everybody's docs toolchain. This way definitely doesn't. Branch -- master Details --- http://git.postgres

[COMMITTERS] pgsql: Release notes adjustments from Erik Rijkers

2012-05-10 Thread Bruce Momjian
Release notes adjustments from Erik Rijkers Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1ee90397f498141abf0c77b4d3c9ea26babc072d Modified Files -- doc/src/sgml/release-9.2.sgml | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) -

Re: [COMMITTERS] pgsql: Improve tests for postmaster death in auxiliary processes.

2012-05-10 Thread Tom Lane
Peter Geoghegan writes: > On 10 May 2012 05:55, Tom Lane wrote: >> I had already removed the unconditional >> PostmasterIsAlive calls in bgwriter and pgstat in previous patches, but >> forgot that WL_POSTMASTER_DEATH is supposed to be treated as untrustworthy >> (per comment in unix_latch.c); so

Re: [COMMITTERS] pgsql: Improve tests for postmaster death in auxiliary processes.

2012-05-10 Thread Peter Geoghegan
On 10 May 2012 05:55, Tom Lane wrote: > In checkpointer and walwriter, avoid calling PostmasterIsAlive unless > WaitLatch has reported WL_POSTMASTER_DEATH.  This saves a kernel call per > iteration of the process's outer loop, which is not all that much, but a > cycle shaved is a cycle earned.  I

[COMMITTERS] pgsql: Improve two 9.2 release note items.

2012-05-10 Thread Bruce Momjian
Improve two 9.2 release note items. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5d258fe90cbd6a0efd68e057697f85a1f961c42d Modified Files -- doc/src/sgml/release-9.2.sgml |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- Sent via pgsql-c

[COMMITTERS] pgsql: Fix a couple of typos in 9.2 release notes.

2012-05-10 Thread Heikki Linnakangas
Fix a couple of typos in 9.2 release notes. Thom Brown Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/386bb92f6348bf8a6f5ebd39122161e190e464c2 Modified Files -- doc/src/sgml/release-9.2.sgml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[COMMITTERS] pgsql: Copy-editing 9.2 release notes.

2012-05-10 Thread Heikki Linnakangas
Copy-editing 9.2 release notes. Fix a couple of typos, add missing filename tags, and add a link to the doc section on timezone guc. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3e8e692bbc829f48c8c1accbeed9284735f9a88c Modified Files -- doc/src/sgml/r

[COMMITTERS] pgsql: Only attempt to show collations on servers >= 9.1.

2012-05-10 Thread Magnus Hagander
Only attempt to show collations on servers >= 9.1. Show a proper error message instead of a SQL error. Josh Kupershmidt Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/71ca53608de1763c0d82bf463580a30f634eba56 Modified Files -- src/bin/psql/descri

[COMMITTERS] pgsql: Only attempt to show collations on servers >= 9.1.

2012-05-10 Thread Magnus Hagander
Only attempt to show collations on servers >= 9.1. Show a proper error message instead of a SQL error. Josh Kupershmidt Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f33c5d471ccdf33ac413d49b32a898eeab13538b Modified Files -- src/bin/psql/describe.c |