[COMMITTERS] pgsql: Fix a stupid bug I introduced into XLogFlush().

2012-07-02 Thread Robert Haas
Fix a stupid bug I introduced into XLogFlush(). Commit f11e8be3e812cdbbc139c1b4e49141378b118dee broke this; it was right in Peter's original patch, but I messed it up before committing. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3cf39e6ddbece4000ee56a0f79cdbe71f

Re: [COMMITTERS] pgsql: Add missing space in event_source GUC description.

2012-07-02 Thread Magnus Hagander
On Mon, Jul 2, 2012 at 9:28 PM, Peter Eisentraut wrote: > On mån, 2012-07-02 at 21:16 +0200, Magnus Hagander wrote: >> Shouldn't this go on master as well? > > It was already committed to master some time ago.  I just cherry-picked > to 9.2. Oh, I missed that.. Sorry. --  Magnus Hagander  Me: h

Re: [COMMITTERS] pgsql: Add missing space in event_source GUC description.

2012-07-02 Thread Peter Eisentraut
On mån, 2012-07-02 at 21:16 +0200, Magnus Hagander wrote: > Shouldn't this go on master as well? It was already committed to master some time ago. I just cherry-picked to 9.2. > > //Magnus > > On Mon, Jul 2, 2012 at 8:02 PM, Peter Eisentraut wrote: > > Add missing space in event_source GUC de

Re: [COMMITTERS] pgsql: Add missing space in event_source GUC description.

2012-07-02 Thread Magnus Hagander
Shouldn't this go on master as well? //Magnus On Mon, Jul 2, 2012 at 8:02 PM, Peter Eisentraut wrote: > Add missing space in event_source GUC description. > > This has apparently been wrong since event_source was added. > > Alexander Lakhin > > Branch > -- > REL9_2_STABLE > > Details > -

[COMMITTERS] pgsql: Fix position of WalSndWakeupRequest call.

2012-07-02 Thread Robert Haas
Fix position of WalSndWakeupRequest call. This avoids discriminating against wal_sync_method = open_sync or open_datasync. Fujii Masao, reviewed by Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3bb592bb20d02093d6488a57c7c4ee94803ddc9a Modified Files

[COMMITTERS] pgsql: Assorted message style improvements

2012-07-02 Thread Peter Eisentraut
Assorted message style improvements Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2b44306315cf84479f735b12f78499616172dbb9 Modified Files -- src/backend/access/spgist/spgutils.c |2 +- src/backend/access/transam/xlog.c |2 +- src/backend/util

[COMMITTERS] pgsql: Assorted message style improvements

2012-07-02 Thread Peter Eisentraut
Assorted message style improvements Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5e59e6a6483ea9ec8149f3ca2a37959115216852 Modified Files -- src/backend/access/spgist/spgutils.c |2 +- src/backend/access/transam/xlog.c |2 +- src/backe

[COMMITTERS] pgsql: Add missing space in event_source GUC description.

2012-07-02 Thread Peter Eisentraut
Add missing space in event_source GUC description. This has apparently been wrong since event_source was added. Alexander Lakhin Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/2a15249956b741afafb9f7b581a752bd236db40c Modified Files -- src/backen

[COMMITTERS] pgsql: Fix to_date's handling of year 519.

2012-07-02 Thread Tom Lane
Fix to_date's handling of year 519. A thinko in commit 029dfdf1157b6d837a7b7211cd35b00c6bcd767c caused the year 519 to be handled differently from either adjacent year, which was not the intention AFAICS. Report and diagnosis by Marc Cousin. In passing, remove redundant re-tests of year value.

[COMMITTERS] pgsql: Fix to_date's handling of year 519.

2012-07-02 Thread Tom Lane
Fix to_date's handling of year 519. A thinko in commit 029dfdf1157b6d837a7b7211cd35b00c6bcd767c caused the year 519 to be handled differently from either adjacent year, which was not the intention AFAICS. Report and diagnosis by Marc Cousin. In passing, remove redundant re-tests of year value.

[COMMITTERS] pgsql: Work a little harder on comments for walsender wakeup patch.

2012-07-02 Thread Robert Haas
Work a little harder on comments for walsender wakeup patch. Per gripe from Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/82cdd2df759efe2b43183ee954b4a2e10b2c59f4 Modified Files -- src/backend/access/transam/xlog.c | 12 ++-- 1 files

Re: [COMMITTERS] pgsql: Make walsender more responsive.

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 11:06 AM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Jul 2, 2012 at 10:34 AM, Tom Lane wrote: >>> (I got a good laugh out of the idea of "contented locks".) > >> Uh... what? I thought the meaning of that was perfectly clear. > > My dictionary defines "contented" as

Re: [COMMITTERS] pgsql: Make walsender more responsive.

2012-07-02 Thread Tom Lane
Robert Haas writes: > On Mon, Jul 2, 2012 at 10:34 AM, Tom Lane wrote: >> (I got a good laugh out of the idea of "contented locks".) > Uh... what? I thought the meaning of that was perfectly clear. My dictionary defines "contented" as "happy and at ease". I think the word intended here is "co

Re: [COMMITTERS] pgsql: Make walsender more responsive.

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 10:34 AM, Tom Lane wrote: > Robert Haas writes: >> Make walsender more responsive. ... >> Andres Freund. Review and stylistic cleanup by me. > > The comments could have used a bit more copy-editing. > > (I got a good laugh out of the idea of "contented locks".) Uh... what

Re: [COMMITTERS] pgsql: Make walsender more responsive.

2012-07-02 Thread Tom Lane
Robert Haas writes: > Make walsender more responsive. ... > Andres Freund. Review and stylistic cleanup by me. The comments could have used a bit more copy-editing. (I got a good laugh out of the idea of "contented locks".) regards, tom lane -- Sent via pgsql-committe

[COMMITTERS] pgsql: Make commit_delay much smarter.

2012-07-02 Thread Robert Haas
Make commit_delay much smarter. Instead of letting every backend participating in a group commit wait independently, have the first one that becomes ready to flush WAL wait for the configured delay, and let all the others wait just long enough for that first process to complete its flush. This gr

[COMMITTERS] pgsql: Make walsender more responsive.

2012-07-02 Thread Robert Haas
Make walsender more responsive. Per testing by Andres Freund, this improves replication performance and reduces replication latency and latency jitter. I was a bit concerned about moving more work into XLogInsert, but testing seems to show that it's not a problem in practice. Along the way, impr