Re: [COMMITTERS] pgsql: Prevent (auto)vacuum from truncating first page of populated mat

2013-05-02 Thread Tom Lane
Kevin Grittner writes: > Prevent (auto)vacuum from truncating first page of populated matview. > Per report from Fujii Masao, with regression test using his example. What happens when VACUUM is applied to an unscannable matview? I remain of the opinion that this is a band-aid on an unsustainable

[COMMITTERS] pgsql: 9.3 release notes: suggested improvements from Jeff Janes and J

2013-05-02 Thread Bruce Momjian
9.3 release notes: suggested improvements from Jeff Janes and Josh Berkus Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c8f61ebdc6e0a260efeef432239d4d2e8202a30d Modified Files -- doc/src/sgml/release-9.3.sgml | 14 ++ 1 files changed, 10 i

[COMMITTERS] pgsql: Prevent (auto)vacuum from truncating first page of populated mat

2013-05-02 Thread Kevin Grittner
Prevent (auto)vacuum from truncating first page of populated matview. Per report from Fujii Masao, with regression test using his example. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b69ec7cc990fd8da75ed4c232899503217d7b9ae Modified Files -- src/back

Re: [COMMITTERS] pgsql: pg_test_fsync: update output to show usecs/op clearer

2013-05-02 Thread Greg Stark
On Thu, May 2, 2013 at 4:44 PM, Dimitri Fontaine wrote: > Use unicode super power and ouput µsec, as it's meant to be? Then google > is useful again, for the smaller number of people who would need it. The SI abbreviation would be µs actually. I don't think it's worth spending an U+03B9 of time

Re: [COMMITTERS] pgsql: pg_test_fsync: update output to show usecs/op clearer

2013-05-02 Thread Bruce Momjian
On Thu, May 2, 2013 at 06:41:53PM +0200, Dimitri Fontaine wrote: > Bruce Momjian writes: > > My point is that tools would need to adjust to output not knowing if > > they are getting UTF8 output, e.g.: > > Ah, yes. Or use "LANG=C pg_test_fsync" or the documented stanza that > always works in scr

Re: [COMMITTERS] pgsql: pg_test_fsync: update output to show usecs/op clearer

2013-05-02 Thread Dimitri Fontaine
Bruce Momjian writes: > My point is that tools would need to adjust to output not knowing if > they are getting UTF8 output, e.g.: Ah, yes. Or use "LANG=C pg_test_fsync" or the documented stanza that always works in scripts as it forces the output to something predictable? -- Dimitri Fontaine h

Re: [COMMITTERS] pgsql: pg_test_fsync: update output to show usecs/op clearer

2013-05-02 Thread Bruce Momjian
On Thu, May 2, 2013 at 06:29:34PM +0200, Dimitri Fontaine wrote: > Bruce Momjian writes: > > Uh, yeah, I think it does. I question whether a command-line diagnostic > > tool really should use it though. It might also make grep of the result > > difficult. > > Hey, it's 2013 outside. Just sayin

Re: [COMMITTERS] pgsql: pg_test_fsync: update output to show usecs/op clearer

2013-05-02 Thread Dimitri Fontaine
Bruce Momjian writes: > Uh, yeah, I think it does. I question whether a command-line diagnostic > tool really should use it though. It might also make grep of the result > difficult. Hey, it's 2013 outside. Just saying: $ echo 'µsec' | grep µsec µsec $ echo 'µsec' | awk '/µsec/' µs

Re: [COMMITTERS] pgsql: pg_test_fsync: update output to show usecs/op clearer

2013-05-02 Thread Bruce Momjian
On Thu, May 2, 2013 at 06:13:11PM +0200, Andres Freund wrote: > On 2013-05-02 12:09:22 -0400, Bruce Momjian wrote: > > On Thu, May 2, 2013 at 05:44:07PM +0200, Dimitri Fontaine wrote: > > > Peter Geoghegan writes: > > > > On Thu, May 2, 2013 at 7:27 AM, Bruce Momjian wrote: > > > >> pg_test_fsy

Re: [COMMITTERS] pgsql: pg_test_fsync: update output to show usecs/op clearer

2013-05-02 Thread Andres Freund
On 2013-05-02 12:09:22 -0400, Bruce Momjian wrote: > On Thu, May 2, 2013 at 05:44:07PM +0200, Dimitri Fontaine wrote: > > Peter Geoghegan writes: > > > On Thu, May 2, 2013 at 7:27 AM, Bruce Momjian wrote: > > >> pg_test_fsync: update output to show usecs/op clearer > > > > > > I don't think that

Re: [COMMITTERS] pgsql: pg_test_fsync: update output to show usecs/op clearer

2013-05-02 Thread Bruce Momjian
On Thu, May 2, 2013 at 05:44:07PM +0200, Dimitri Fontaine wrote: > Peter Geoghegan writes: > > On Thu, May 2, 2013 at 7:27 AM, Bruce Momjian wrote: > >> pg_test_fsync: update output to show usecs/op clearer > > > > I don't think that this is an improvement. Not everyone knows that > > usec is sh

Re: [COMMITTERS] pgsql: pg_test_fsync: update output to show usecs/op clearer

2013-05-02 Thread Bruce Momjian
On Thu, May 2, 2013 at 08:38:39AM -0700, Peter Geoghegan wrote: > On Thu, May 2, 2013 at 7:27 AM, Bruce Momjian wrote: > > pg_test_fsync: update output to show usecs/op clearer > > I don't think that this is an improvement. Not everyone knows that > usec is shorthand for microsecond. If I Google

Re: [COMMITTERS] pgsql: pg_test_fsync: update output to show usecs/op clearer

2013-05-02 Thread Dimitri Fontaine
Peter Geoghegan writes: > On Thu, May 2, 2013 at 7:27 AM, Bruce Momjian wrote: >> pg_test_fsync: update output to show usecs/op clearer > > I don't think that this is an improvement. Not everyone knows that > usec is shorthand for microsecond. Use unicode super power and ouput µsec, as it's mean

Re: [COMMITTERS] pgsql: pg_test_fsync: update output to show usecs/op clearer

2013-05-02 Thread Peter Geoghegan
On Thu, May 2, 2013 at 7:27 AM, Bruce Momjian wrote: > pg_test_fsync: update output to show usecs/op clearer I don't think that this is an improvement. Not everyone knows that usec is shorthand for microsecond. If I Google usec, I see something about the United States Enrichment Corporation, but

[COMMITTERS] pgsql: Fix thinko in comment.

2013-05-02 Thread Heikki Linnakangas
Fix thinko in comment. WAL segment means a 16 MB physical WAL file; this comment meant a logical 4 GB log file. Amit Langote. Apply to backbranches only, as the comment is gone in master. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7fa56e636e42d1bc969483e

[COMMITTERS] pgsql: Fix thinko in comment.

2013-05-02 Thread Heikki Linnakangas
Fix thinko in comment. WAL segment means a 16 MB physical WAL file; this comment meant a logical 4 GB log file. Amit Langote. Apply to backbranches only, as the comment is gone in master. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5f14acdebc86269ae8a7f78

[COMMITTERS] pgsql: Fix thinko in comment.

2013-05-02 Thread Heikki Linnakangas
Fix thinko in comment. WAL segment means a 16 MB physical WAL file; this comment meant a logical 4 GB log file. Amit Langote. Apply to backbranches only, as the comment is gone in master. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/e1d1d8099300bbc55cd44af

[COMMITTERS] pgsql: pg_test_fsync: update output to show usecs/op clearer

2013-05-02 Thread Bruce Momjian
pg_test_fsync: update output to show usecs/op clearer Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/095018bc32b70eff95bdf3c2959e6eef09dcfa6a Modified Files -- contrib/pg_test_fsync/pg_test_fsync.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(