[COMMITTERS] pgsql: Code review of recycling WAL segments in a restartpoint.

2013-06-03 Thread Heikki Linnakangas
Code review of recycling WAL segments in a restartpoint. Seems cleaner to get the currently-replayed TLI in the same call to GetXLogReplayRecPtr that we get the WAL position. Make it more clear in the comment what the code does when recovery has already ended (RecoveryInProgress() will set

[COMMITTERS] pgsql: Additional spelling corrections

2013-06-03 Thread Stephen Frost
Additional spelling corrections A few more minor spelling corrections, no functional changes. Thom Brown Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f129615fe72f70868a86862b663dd7d78dd5cb71 Modified Files -- src/backend/access/hash/README |

[COMMITTERS] pgsql: Put back allow_system_table_mods check in heap_create().

2013-06-03 Thread Heikki Linnakangas
Put back allow_system_table_mods check in heap_create(). This reverts commit a475c6036752c26dca538632b68fd2cc592976b7. Erik Rijkers reported back in January 2013 that after the patch, if you do pg_dump -t myschema.mytable to dump a single table, and restore that in a database where myschema does

[COMMITTERS] pgsql: Add semicolons to eval'd strings to hide a minor Perl behavioral

2013-06-03 Thread Tom Lane
Add semicolons to eval'd strings to hide a minor Perl behavioral change. eval q{foo} used to complain that the error was on line 2 of the eval'd string, because eval internally tacked on \n; so that the end of the erroneous command was indeed on line 2. But as of Perl 5.18 it more sanely says

[COMMITTERS] pgsql: Add semicolons to eval'd strings to hide a minor Perl behavioral

2013-06-03 Thread Tom Lane
Add semicolons to eval'd strings to hide a minor Perl behavioral change. eval q{foo} used to complain that the error was on line 2 of the eval'd string, because eval internally tacked on \n; so that the end of the erroneous command was indeed on line 2. But as of Perl 5.18 it more sanely says

[COMMITTERS] pgsql: Add semicolons to eval'd strings to hide a minor Perl behavioral

2013-06-03 Thread Tom Lane
Add semicolons to eval'd strings to hide a minor Perl behavioral change. eval q{foo} used to complain that the error was on line 2 of the eval'd string, because eval internally tacked on \n; so that the end of the erroneous command was indeed on line 2. But as of Perl 5.18 it more sanely says

[COMMITTERS] pgsql: Add semicolons to eval'd strings to hide a minor Perl behavioral

2013-06-03 Thread Tom Lane
Add semicolons to eval'd strings to hide a minor Perl behavioral change. eval q{foo} used to complain that the error was on line 2 of the eval'd string, because eval internally tacked on \n; so that the end of the erroneous command was indeed on line 2. But as of Perl 5.18 it more sanely says