[COMMITTERS] pgsql: Fix PQconninfoParse error message handling

2013-07-15 Thread Peter Eisentraut
Fix PQconninfoParse error message handling The returned error message already includes a newline, but the callers were adding their own when printing it out. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/bdbb1d673834ef7af16d97158d9d0006b17949f7 Modified Fil

[COMMITTERS] pgsql: Fix PQconninfoParse error message handling

2013-07-15 Thread Peter Eisentraut
Fix PQconninfoParse error message handling The returned error message already includes a newline, but the callers were adding their own when printing it out. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/233bfe06735411f08d231764dfd3a6fcf7aef9a3 Modified Files

[COMMITTERS] pgsql: Check get_tle_by_resno() result before deref

2013-07-15 Thread Stephen Frost
Check get_tle_by_resno() result before deref When creating a sort to support a group by, we need to look up the target entry in the target list by the resno using get_tle_by_resno(). This particular code-path didn't check the result prior to attempting to dereference it, while all other callers di

[COMMITTERS] pgsql: Tab completion for \lo_import

2013-07-15 Thread Robert Haas
Tab completion for \lo_import Josh Kupershmidt Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4403a9d7913043d99de9e13a9b54c57ed0c4501c Modified Files -- src/bin/psql/tab-complete.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- Sent via

[COMMITTERS] pgsql: Assert that syscache lookups don't happen outside transactions.

2013-07-15 Thread Robert Haas
Assert that syscache lookups don't happen outside transactions. Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/42c80c696e9c8323841180029cc62741c21bd356 Modified Files -- src/backend/utils/cache/catcache.c |4 1 file changed, 4 inse

[COMMITTERS] pgsql: Regression tests for LOCK TABLE.

2013-07-15 Thread Robert Haas
Regression tests for LOCK TABLE. Robins Tharakan, reviewed by Szymon Guz, substantially revised by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ac33c7e2c1304dffcf107065d7fc04232a8a94fa Modified Files -- src/test/regress/expected/lock.out | 62 ++

[COMMITTERS] pgsql: Clean up pg_basebackup libpq usage

2013-07-15 Thread Stephen Frost
Clean up pg_basebackup libpq usage When using libpq, it's generally preferrable to just use the strings which are in the PQ structures instead of copying them out, so do that instead in BaseBackup(), eliminating the strcpy()'s used there. Also, in ReceiveAndUnpackTarFile(), check the string lengt

[COMMITTERS] pgsql: vacuumlo: Use a cursor to limit client-side memory usage.

2013-07-15 Thread Robert Haas
vacuumlo: Use a cursor to limit client-side memory usage. This prevents the client from gobbling up too much memory when the number of large objects to be removed is very large. Andrew Dunstan, reviewed by Josh Kupershmidt Branch -- master Details --- http://git.postgresql.org/pg/commit

[COMMITTERS] pgsql: Correct off-by-one when reading from pipe

2013-07-15 Thread Stephen Frost
Correct off-by-one when reading from pipe In pg_basebackup.c:reached_end_position(), we're reading from an internal pipe with our own background process but we're possibly reading more bytes than will actually fit into our buffer due to an off-by-one error. As we're reading from an internal pipe

[COMMITTERS] pgsql: Correct off-by-one when reading from pipe

2013-07-15 Thread Stephen Frost
Correct off-by-one when reading from pipe In pg_basebackup.c:reached_end_position(), we're reading from an internal pipe with our own background process but we're possibly reading more bytes than will actually fit into our buffer due to an off-by-one error. As we're reading from an internal pipe

[COMMITTERS] pgsql: Correct off-by-one when reading from pipe

2013-07-15 Thread Stephen Frost
Correct off-by-one when reading from pipe In pg_basebackup.c:reached_end_position(), we're reading from an internal pipe with our own background process but we're possibly reading more bytes than will actually fit into our buffer due to an off-by-one error. As we're reading from an internal pipe