[COMMITTERS] pgsql: Don't abort pg_basebackup when receiving empty WAL block

2013-11-11 Thread Magnus Hagander
Don't abort pg_basebackup when receiving empty WAL block This can happen exactly at the switch of a logical WAL file (segment number ending in FE), when running pg_basebackup connected to a standby server, and would cause the backup to abort with the error message streaming header too small.

Re: [COMMITTERS] pgsql: doc: Clarify under what circumstances pg_dump needs superuser ac

2013-11-11 Thread Thom Brown
On 8 November 2013 20:12, Robert Haas rh...@postgresql.org wrote: doc: Clarify under what circumstances pg_dump needs superuser access. Inspired by, but different from, a patch from Ivan Lezhnjov IV Branch -- master Details ---

[COMMITTERS] pgsql: Don't abort pg_basebackup when receiving empty WAL block

2013-11-11 Thread Magnus Hagander
Don't abort pg_basebackup when receiving empty WAL block This is a similar fix as c6ec8793aa59d1842082e14b4b4aae7d4bd883fd 9.2. This should never happen in 9.3 and newer since the special case cannot happen there, but this patch synchronizes up the code so there is no confusion on why they're

[COMMITTERS] pgsql: Don't abort pg_basebackup when receiving empty WAL block

2013-11-11 Thread Magnus Hagander
Don't abort pg_basebackup when receiving empty WAL block This is a similar fix as c6ec8793aa59d1842082e14b4b4aae7d4bd883fd 9.2. This should never happen in 9.3 and newer since the special case cannot happen there, but this patch synchronizes up the code so there is no confusion on why they're

Re: [COMMITTERS] pgsql: Fix whitespace issues found by git diff --check, add gitattribut

2013-11-11 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: Fix whitespace issues found by git diff --check, add gitattributes Set per file type attributes in .gitattributes to fine-tune whitespace checks. With the associated cleanups, the tree is now clean for git Hmm, I thought the .gitattributes file would

[COMMITTERS] pgsql: Re-allow duplicate aliases within aliased JOINs.

2013-11-11 Thread Tom Lane
Re-allow duplicate aliases within aliased JOINs. Although the SQL spec forbids duplicate table aliases, historically we've allowed queries like SELECT ... FROM tab1 x CROSS JOIN (tab2 x CROSS JOIN tab3 y) z on the grounds that the aliased join (z) hides the aliases within it, therefore there

[COMMITTERS] pgsql: Re-allow duplicate aliases within aliased JOINs.

2013-11-11 Thread Tom Lane
Re-allow duplicate aliases within aliased JOINs. Although the SQL spec forbids duplicate table aliases, historically we've allowed queries like SELECT ... FROM tab1 x CROSS JOIN (tab2 x CROSS JOIN tab3 y) z on the grounds that the aliased join (z) hides the aliases within it, therefore there

[COMMITTERS] pgsql: Fix ruleutils pretty-printing to not generate trailing whitespac

2013-11-11 Thread Tom Lane
Fix ruleutils pretty-printing to not generate trailing whitespace. The pretty-printing logic in ruleutils.c operates by inserting a newline and some indentation whitespace into strings that are already valid SQL. This naturally results in leaving some trailing whitespace before the newline in

[COMMITTERS] pgsql: Fix ruleutils pretty-printing to not generate trailing whitespac

2013-11-11 Thread Tom Lane
Fix ruleutils pretty-printing to not generate trailing whitespace. The pretty-printing logic in ruleutils.c operates by inserting a newline and some indentation whitespace into strings that are already valid SQL. This naturally results in leaving some trailing whitespace before the newline in

[COMMITTERS] pgsql: Fix failure with whole-row reference to a subquery.

2013-11-11 Thread Tom Lane
Fix failure with whole-row reference to a subquery. Simple oversight in commit 1cb108efb0e60d87e4adec38e7636b6e8efbeb57 --- recursively examining a subquery output column is only sane if the original Var refers to a single output column. Found by Kevin Grittner. Branch -- REL9_2_STABLE

[COMMITTERS] pgsql: Fix failure with whole-row reference to a subquery.

2013-11-11 Thread Tom Lane
Fix failure with whole-row reference to a subquery. Simple oversight in commit 1cb108efb0e60d87e4adec38e7636b6e8efbeb57 --- recursively examining a subquery output column is only sane if the original Var refers to a single output column. Found by Kevin Grittner. Branch -- REL9_3_STABLE

[COMMITTERS] pgsql: Fix failure with whole-row reference to a subquery.

2013-11-11 Thread Tom Lane
Fix failure with whole-row reference to a subquery. Simple oversight in commit 1cb108efb0e60d87e4adec38e7636b6e8efbeb57 --- recursively examining a subquery output column is only sane if the original Var refers to a single output column. Found by Kevin Grittner. Branch -- master Details