Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Fujii Masao
On Sun, Feb 2, 2014 at 8:19 AM, Thom Brown wrote: > On 1 February 2014 04:50, Robert Haas wrote: >> doc/src/sgml/high-availability.sgml| 94 +- > > s/configuration a replication slot/configuring a replication/ > > >> doc/src/sgml/ref/pg_receivexlog.sgml > > s/paramter/parameter/

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Fujii Masao
On Sat, Feb 1, 2014 at 6:37 PM, Andres Freund wrote: > On 2014-02-01 18:33:08 +0900, Fujii Masao wrote: >> On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund wrote: >> > On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: >> >> This patch changed basebackup.c so that it skips pg_replslot. It's OK >> >> t

[COMMITTERS] pgsql: Fix typos in docs and comments.

2014-02-01 Thread Fujii Masao
Fix typos in docs and comments. Thom Brown Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/63be3b78f6e1d92c7f02d4f73a55dd5cefab923b Modified Files -- doc/src/sgml/high-availability.sgml |2 +- doc/src/sgml/ref/pg_receivexlog.sgml |2 +- src/backen

[COMMITTERS] pgsql: Fix makefile syntax.

2014-02-01 Thread Andrew Dunstan
Fix makefile syntax. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/1670557ab0e494b80ed85da6e53b8304bffe11ee Modified Files -- src/interfaces/libpq/Makefile |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committ

[COMMITTERS] pgsql: Fix makefile syntax.

2014-02-01 Thread Andrew Dunstan
Fix makefile syntax. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9abed7d1cb1e219254bcf4b92afd02c11337e7a3 Modified Files -- src/interfaces/libpq/Makefile |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mai

[COMMITTERS] pgsql: Fix makefile syntax.

2014-02-01 Thread Andrew Dunstan
Fix makefile syntax. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/55c018896f86eb0991d84972f2a899d68bf82c0b Modified Files -- src/interfaces/libpq/Makefile |8 1 file changed, 4 insertions(+), 4 deletions(-) -- Sent via pgsql-commi

[COMMITTERS] pgsql: Fix makefile syntax.

2014-02-01 Thread Andrew Dunstan
Fix makefile syntax. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c73423d9772ef322fd84f76af5340f2b19337c21 Modified Files -- src/interfaces/libpq/Makefile |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committ

[COMMITTERS] pgsql: Fix makefile syntax.

2014-02-01 Thread Andrew Dunstan
Fix makefile syntax. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/308dd5b0dc6b4219d7c35004922cc84052cd Modified Files -- src/interfaces/libpq/Makefile |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committ

[COMMITTERS] pgsql: Fix makefile syntax.

2014-02-01 Thread Andrew Dunstan
Fix makefile syntax. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c07702995ab48284f730c1ebc9ae066ff14469d0 Modified Files -- src/interfaces/libpq/Makefile |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committ

Re: [COMMITTERS] pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.

2014-02-01 Thread Andrew Dunstan
On 02/01/2014 07:14 PM, Tom Lane wrote: Andrew Dunstan writes: Copy the libpq DLL to the bin directory on Mingw and Cygwin. AFAICT, this patch set is completely broken. The buildfarm shows that every build attempt on the 8.4 branch has failed since it went in. This is because MKDIR_P isn't

Re: [COMMITTERS] pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.

2014-02-01 Thread Tom Lane
Andrew Dunstan writes: > Copy the libpq DLL to the bin directory on Mingw and Cygwin. AFAICT, this patch set is completely broken. The buildfarm shows that every build attempt on the 8.4 branch has failed since it went in. This is because MKDIR_P isn't defined in that branch; you need to use $(

[COMMITTERS] pgsql: Fix some wide-character bugs in the text-search parser.

2014-02-01 Thread Tom Lane
Fix some wide-character bugs in the text-search parser. In p_isdigit and other character class test functions generated by the p_iswhat macro, the code path for non-C locales with multibyte encodings contained a bogus pointer cast that would accidentally fail to malfunction if types wchar_t and wi

[COMMITTERS] pgsql: Fix some wide-character bugs in the text-search parser.

2014-02-01 Thread Tom Lane
Fix some wide-character bugs in the text-search parser. In p_isdigit and other character class test functions generated by the p_iswhat macro, the code path for non-C locales with multibyte encodings contained a bogus pointer cast that would accidentally fail to malfunction if types wchar_t and wi

[COMMITTERS] pgsql: Fix some wide-character bugs in the text-search parser.

2014-02-01 Thread Tom Lane
Fix some wide-character bugs in the text-search parser. In p_isdigit and other character class test functions generated by the p_iswhat macro, the code path for non-C locales with multibyte encodings contained a bogus pointer cast that would accidentally fail to malfunction if types wchar_t and wi

[COMMITTERS] pgsql: Fix some wide-character bugs in the text-search parser.

2014-02-01 Thread Tom Lane
Fix some wide-character bugs in the text-search parser. In p_isdigit and other character class test functions generated by the p_iswhat macro, the code path for non-C locales with multibyte encodings contained a bogus pointer cast that would accidentally fail to malfunction if types wchar_t and wi

[COMMITTERS] pgsql: Fix some wide-character bugs in the text-search parser.

2014-02-01 Thread Tom Lane
Fix some wide-character bugs in the text-search parser. In p_isdigit and other character class test functions generated by the p_iswhat macro, the code path for non-C locales with multibyte encodings contained a bogus pointer cast that would accidentally fail to malfunction if types wchar_t and wi

[COMMITTERS] pgsql: Fix some wide-character bugs in the text-search parser.

2014-02-01 Thread Tom Lane
Fix some wide-character bugs in the text-search parser. In p_isdigit and other character class test functions generated by the p_iswhat macro, the code path for non-C locales with multibyte encodings contained a bogus pointer cast that would accidentally fail to malfunction if types wchar_t and wi

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Thom Brown
On 1 February 2014 04:50, Robert Haas wrote: > doc/src/sgml/high-availability.sgml| 94 +- s/configuration a replication slot/configuring a replication/ > doc/src/sgml/ref/pg_receivexlog.sgml s/paramter/parameter/ > src/backend/replication/slot.c | 1066 +

[COMMITTERS] pgsql: fix whitespace

2014-02-01 Thread Andrew Dunstan
fix whitespace Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/d7b5a31ce9243248074f1445de9b0ea25895affc Modified Files -- src/Makefile.shlib |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql

[COMMITTERS] pgsql: fix whitespace

2014-02-01 Thread Andrew Dunstan
fix whitespace Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c8158a2eed8eb060c524620c8314bec30ac94c99 Modified Files -- src/Makefile.shlib |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-commit

[COMMITTERS] pgsql: fix whitespace

2014-02-01 Thread Andrew Dunstan
fix whitespace Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7fe4e357d2e1f72ced069d2bb9562b4be2f4fdf5 Modified Files -- src/Makefile.shlib |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql

[COMMITTERS] pgsql: fix whitespace

2014-02-01 Thread Andrew Dunstan
fix whitespace Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/141119c2a78efbb6dae5b0f37f9c07c2b9f9c8cb Modified Files -- src/Makefile.shlib |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql

[COMMITTERS] pgsql: fix whitespace

2014-02-01 Thread Andrew Dunstan
fix whitespace Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/cfebd60d826a4c34f240913ee9c76d4e9ac0afa9 Modified Files -- src/Makefile.shlib |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql

[COMMITTERS] pgsql: Fix some more bugs in signal handlers and process shutdown logic

2014-02-01 Thread Tom Lane
Fix some more bugs in signal handlers and process shutdown logic. WalSndKill was doing things exactly backwards: it should first clear MyWalSnd (to stop signal handlers from touching MyWalSnd->latch), then disown the latch, and only then mark the WalSnd struct unused by clearing its pid field. Al

[COMMITTERS] pgsql: Fix some more bugs in signal handlers and process shutdown logic

2014-02-01 Thread Tom Lane
Fix some more bugs in signal handlers and process shutdown logic. WalSndKill was doing things exactly backwards: it should first clear MyWalSnd (to stop signal handlers from touching MyWalSnd->latch), then disown the latch, and only then mark the WalSnd struct unused by clearing its pid field. Al

[COMMITTERS] pgsql: Fix some more bugs in signal handlers and process shutdown logic

2014-02-01 Thread Tom Lane
Fix some more bugs in signal handlers and process shutdown logic. WalSndKill was doing things exactly backwards: it should first clear MyWalSnd (to stop signal handlers from touching MyWalSnd->latch), then disown the latch, and only then mark the WalSnd struct unused by clearing its pid field. Al

[COMMITTERS] pgsql: Fix some more bugs in signal handlers and process shutdown logic

2014-02-01 Thread Tom Lane
Fix some more bugs in signal handlers and process shutdown logic. WalSndKill was doing things exactly backwards: it should first clear MyWalSnd (to stop signal handlers from touching MyWalSnd->latch), then disown the latch, and only then mark the WalSnd struct unused by clearing its pid field. Al

[COMMITTERS] pgsql: Don't use deprecated dllwrap on Cygwin.

2014-02-01 Thread Andrew Dunstan
Don't use deprecated dllwrap on Cygwin. The preferred method is to use "cc -shared", and this allows binaries to be rebased if required, unlike dllwrap. Backpatch to 9.0 where we have buildfarm coverage. There are still some issues with Cygwin, especially modern Cygwin, but this helps us get clo

[COMMITTERS] pgsql: Don't use deprecated dllwrap on Cygwin.

2014-02-01 Thread Andrew Dunstan
Don't use deprecated dllwrap on Cygwin. The preferred method is to use "cc -shared", and this allows binaries to be rebased if required, unlike dllwrap. Backpatch to 9.0 where we have buildfarm coverage. There are still some issues with Cygwin, especially modern Cygwin, but this helps us get clo

[COMMITTERS] pgsql: Don't use deprecated dllwrap on Cygwin.

2014-02-01 Thread Andrew Dunstan
Don't use deprecated dllwrap on Cygwin. The preferred method is to use "cc -shared", and this allows binaries to be rebased if required, unlike dllwrap. Backpatch to 9.0 where we have buildfarm coverage. There are still some issues with Cygwin, especially modern Cygwin, but this helps us get clo

[COMMITTERS] pgsql: Don't use deprecated dllwrap on Cygwin.

2014-02-01 Thread Andrew Dunstan
Don't use deprecated dllwrap on Cygwin. The preferred method is to use "cc -shared", and this allows binaries to be rebased if required, unlike dllwrap. Backpatch to 9.0 where we have buildfarm coverage. There are still some issues with Cygwin, especially modern Cygwin, but this helps us get clo

[COMMITTERS] pgsql: Don't use deprecated dllwrap on Cygwin.

2014-02-01 Thread Andrew Dunstan
Don't use deprecated dllwrap on Cygwin. The preferred method is to use "cc -shared", and this allows binaries to be rebased if required, unlike dllwrap. Backpatch to 9.0 where we have buildfarm coverage. There are still some issues with Cygwin, especially modern Cygwin, but this helps us get clo

[COMMITTERS] pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.

2014-02-01 Thread Andrew Dunstan
Copy the libpq DLL to the bin directory on Mingw and Cygwin. This has long been done by the MSVC build system, and has caused confusion in the past when programs like psql have failed to start because they can't find the DLL. If it's in the same directory as it now will be they will find it. Back

[COMMITTERS] pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.

2014-02-01 Thread Andrew Dunstan
Copy the libpq DLL to the bin directory on Mingw and Cygwin. This has long been done by the MSVC build system, and has caused confusion in the past when programs like psql have failed to start because they can't find the DLL. If it's in the same directory as it now will be they will find it. Back

[COMMITTERS] pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.

2014-02-01 Thread Andrew Dunstan
Copy the libpq DLL to the bin directory on Mingw and Cygwin. This has long been done by the MSVC build system, and has caused confusion in the past when programs like psql have failed to start because they can't find the DLL. If it's in the same directory as it now will be they will find it. Back

[COMMITTERS] pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.

2014-02-01 Thread Andrew Dunstan
Copy the libpq DLL to the bin directory on Mingw and Cygwin. This has long been done by the MSVC build system, and has caused confusion in the past when programs like psql have failed to start because they can't find the DLL. If it's in the same directory as it now will be they will find it. Back

[COMMITTERS] pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.

2014-02-01 Thread Andrew Dunstan
Copy the libpq DLL to the bin directory on Mingw and Cygwin. This has long been done by the MSVC build system, and has caused confusion in the past when programs like psql have failed to start because they can't find the DLL. If it's in the same directory as it now will be they will find it. Back

[COMMITTERS] pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.

2014-02-01 Thread Andrew Dunstan
Copy the libpq DLL to the bin directory on Mingw and Cygwin. This has long been done by the MSVC build system, and has caused confusion in the past when programs like psql have failed to start because they can't find the DLL. If it's in the same directory as it now will be they will find it. Back

[COMMITTERS] pgsql: arrays: tighten checks for multi-dimensional input

2014-02-01 Thread Bruce Momjian
arrays: tighten checks for multi-dimensional input Previously an input array string that started with a single-element array dimension would then later accept a multi-dimensional segment. BACKWARD INCOMPATIBILITY Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d0ee

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Andres Freund
On 2014-02-01 18:33:08 +0900, Fujii Masao wrote: > On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund wrote: > > On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: > >> This patch changed basebackup.c so that it skips pg_replslot. It's OK > >> to skip all files in that directory, but an empty pg_replslot

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Fujii Masao
On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund wrote: > On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: >> On Sat, Feb 1, 2014 at 12:50 PM, Robert Haas wrote: >> > Introduce replication slots. >> > >> > Replication slots are a crash-safe data structure which can be created >> > on either a master

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Andres Freund
On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: > On Sat, Feb 1, 2014 at 12:50 PM, Robert Haas wrote: > > Introduce replication slots. > > > > Replication slots are a crash-safe data structure which can be created > > on either a master or a standby to prevent premature removal of > > write-ahead