[COMMITTERS] pgsql: Fix typo

2014-02-13 Thread Peter Eisentraut
Fix typo Stefan Kaltenbrunner Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0f2ca0075c4bd42351cd48b3e6889f11f0e03e65 Modified Files -- src/include/mb/pg_wchar.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mai

[COMMITTERS] pgsql: Add C comment about problems with CHAR() space trimming

2014-02-13 Thread Bruce Momjian
Add C comment about problems with CHAR() space trimming Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9c57d11fca3b87daa741151f75085e2554ee310f Modified Files -- src/backend/utils/adt/varchar.c | 12 1 file changed, 12 insertions(+) -- S

[COMMITTERS] pgsql: Clean up error cases in psql's COPY TO STDOUT/FROM STDIN code.

2014-02-13 Thread Tom Lane
Clean up error cases in psql's COPY TO STDOUT/FROM STDIN code. Adjust handleCopyOut() to stop trying to write data once it's failed one time. For typical cases such as out-of-disk-space or broken-pipe, additional attempts aren't going to do anything but waste time, and in any case clean truncatio

[COMMITTERS] pgsql: Clean up error cases in psql's COPY TO STDOUT/FROM STDIN code.

2014-02-13 Thread Tom Lane
Clean up error cases in psql's COPY TO STDOUT/FROM STDIN code. Adjust handleCopyOut() to stop trying to write data once it's failed one time. For typical cases such as out-of-disk-space or broken-pipe, additional attempts aren't going to do anything but waste time, and in any case clean truncatio

[COMMITTERS] pgsql: Clean up error cases in psql's COPY TO STDOUT/FROM STDIN code.

2014-02-13 Thread Tom Lane
Clean up error cases in psql's COPY TO STDOUT/FROM STDIN code. Adjust handleCopyOut() to stop trying to write data once it's failed one time. For typical cases such as out-of-disk-space or broken-pipe, additional attempts aren't going to do anything but waste time, and in any case clean truncatio

[COMMITTERS] pgsql: Clean up error cases in psql's COPY TO STDOUT/FROM STDIN code.

2014-02-13 Thread Tom Lane
Clean up error cases in psql's COPY TO STDOUT/FROM STDIN code. Adjust handleCopyOut() to stop trying to write data once it's failed one time. For typical cases such as out-of-disk-space or broken-pipe, additional attempts aren't going to do anything but waste time, and in any case clean truncatio

[COMMITTERS] pgsql: Clean up error cases in psql's COPY TO STDOUT/FROM STDIN code.

2014-02-13 Thread Tom Lane
Clean up error cases in psql's COPY TO STDOUT/FROM STDIN code. Adjust handleCopyOut() to stop trying to write data once it's failed one time. For typical cases such as out-of-disk-space or broken-pipe, additional attempts aren't going to do anything but waste time, and in any case clean truncatio

[COMMITTERS] pgsql: Clean up error cases in psql's COPY TO STDOUT/FROM STDIN code.

2014-02-13 Thread Tom Lane
Clean up error cases in psql's COPY TO STDOUT/FROM STDIN code. Adjust handleCopyOut() to stop trying to write data once it's failed one time. For typical cases such as out-of-disk-space or broken-pipe, additional attempts aren't going to do anything but waste time, and in any case clean truncatio

Re: [COMMITTERS] pgsql: pgindent: preserve blank lines around #else/#endif

2014-02-13 Thread Alvaro Herrera
Bruce Momjian wrote: > On Thu, Feb 13, 2014 at 03:52:02PM -0500, Tom Lane wrote: > > >> else if (def->defnamespace == NULL) > > >> continue; > > >> + > > >> else if (pg_strcasecmp(def->defnamespace, namspace) != 0) > > >> continue; > > >> > > >> This seems an odd change to be making. > > > > > I

[COMMITTERS] pgsql: docs: improve CREATE FUNCTION docs about language case and quoti

2014-02-13 Thread Bruce Momjian
docs: improve CREATE FUNCTION docs about language case and quoting Report from Marc Mamin Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/de4b6558be4285d8186e16f33ab474d619bb0cf6 Modified Files -- doc/src/sgml/ref/create_function.sgml |6 +++--- 1 fil

Re: [COMMITTERS] pgsql: pgindent: preserve blank lines around #else/#endif

2014-02-13 Thread Bruce Momjian
On Thu, Feb 13, 2014 at 03:52:02PM -0500, Tom Lane wrote: > >> else if (def->defnamespace == NULL) > >> continue; > >> + > >> else if (pg_strcasecmp(def->defnamespace, namspace) != 0) > >> continue; > >> > >> This seems an odd change to be making. > > > I just tested pgindent in head against that

Re: [COMMITTERS] pgsql: pgindent: preserve blank lines around #else/#endif

2014-02-13 Thread Tom Lane
Bruce Momjian writes: > On Thu, Feb 13, 2014 at 04:07:21PM -0300, Alvaro Herrera wrote: >> BTW did this commit, or other recent pgindent tweaks, have more >> implications than we were aware of? I just tried running HEAD's >> pgindent in 9.3 (in individual files) and among other changes I saw this

[COMMITTERS] pgsql: pgcrypto: clarify 'md5' (hash) table entry

2014-02-13 Thread Bruce Momjian
pgcrypto: clarify 'md5' (hash) table entry Per suggestion from Peter Eisentraut Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/474cb24df7f6f85a936e87314edeb2deb92365cd Modified Files -- doc/src/sgml/pgcrypto.sgml |2 +- 1 file changed, 1 insertion(+)

Re: [COMMITTERS] pgsql: pgindent: preserve blank lines around #else/#endif

2014-02-13 Thread Alvaro Herrera
Bruce Momjian wrote: > On Thu, Feb 13, 2014 at 03:54:54PM -0300, Alvaro Herrera wrote: > > Bruce Momjian wrote: > > > pgindent: preserve blank lines around #else/#endif > > > > > > This requires a new version of pg_bsd_indent, version 1.3, to be > > > downloaded. > > > > This is a bit of a mess.

Re: [COMMITTERS] pgsql: pgindent: preserve blank lines around #else/#endif

2014-02-13 Thread Bruce Momjian
On Thu, Feb 13, 2014 at 04:07:21PM -0300, Alvaro Herrera wrote: > Alvaro Herrera wrote: > > Bruce Momjian wrote: > > > pgindent: preserve blank lines around #else/#endif > > > > > > This requires a new version of pg_bsd_indent, version 1.3, to be > > > downloaded. > > > > This is a bit of a mess

Re: [COMMITTERS] pgsql: pgindent: preserve blank lines around #else/#endif

2014-02-13 Thread Bruce Momjian
On Thu, Feb 13, 2014 at 03:54:54PM -0300, Alvaro Herrera wrote: > Bruce Momjian wrote: > > pgindent: preserve blank lines around #else/#endif > > > > This requires a new version of pg_bsd_indent, version 1.3, to be > > downloaded. > > This is a bit of a mess. I now can't use 9.3's pgindent beca

Re: [COMMITTERS] pgsql: pgindent: preserve blank lines around #else/#endif

2014-02-13 Thread Alvaro Herrera
Bruce Momjian wrote: > pgindent: preserve blank lines around #else/#endif > > This requires a new version of pg_bsd_indent, version 1.3, to be > downloaded. This is a bit of a mess. I now can't use 9.3's pgindent because it wants to have pg_bsd_indent 1.2 installed, but I only have 1.3 because

Re: [COMMITTERS] pgsql: pgindent: preserve blank lines around #else/#endif

2014-02-13 Thread Alvaro Herrera
Alvaro Herrera wrote: > Bruce Momjian wrote: > > pgindent: preserve blank lines around #else/#endif > > > > This requires a new version of pg_bsd_indent, version 1.3, to be > > downloaded. > > This is a bit of a mess. I now can't use 9.3's pgindent because it > wants to have pg_bsd_indent 1.2 i

[COMMITTERS] pgsql: Fix length checking for Unicode identifiers containing escapes (

2014-02-13 Thread Tom Lane
Fix length checking for Unicode identifiers containing escapes (U&"..."). We used the length of the input string, not the de-escaped string, as the trigger for NAMEDATALEN truncation. AFAICS this would only result in sometimes printing a phony truncation warning; but it's just luck that there was

[COMMITTERS] pgsql: Fix length checking for Unicode identifiers containing escapes (

2014-02-13 Thread Tom Lane
Fix length checking for Unicode identifiers containing escapes (U&"..."). We used the length of the input string, not the de-escaped string, as the trigger for NAMEDATALEN truncation. AFAICS this would only result in sometimes printing a phony truncation warning; but it's just luck that there was

[COMMITTERS] pgsql: Fix length checking for Unicode identifiers containing escapes (

2014-02-13 Thread Tom Lane
Fix length checking for Unicode identifiers containing escapes (U&"..."). We used the length of the input string, not the de-escaped string, as the trigger for NAMEDATALEN truncation. AFAICS this would only result in sometimes printing a phony truncation warning; but it's just luck that there was

[COMMITTERS] pgsql: Fix length checking for Unicode identifiers containing escapes (

2014-02-13 Thread Tom Lane
Fix length checking for Unicode identifiers containing escapes (U&"..."). We used the length of the input string, not the de-escaped string, as the trigger for NAMEDATALEN truncation. AFAICS this would only result in sometimes printing a phony truncation warning; but it's just luck that there was

[COMMITTERS] pgsql: Fix length checking for Unicode identifiers containing escapes (

2014-02-13 Thread Tom Lane
Fix length checking for Unicode identifiers containing escapes (U&"..."). We used the length of the input string, not the de-escaped string, as the trigger for NAMEDATALEN truncation. AFAICS this would only result in sometimes printing a phony truncation warning; but it's just luck that there was

[COMMITTERS] pgsql: Fix length checking for Unicode identifiers containing escapes (

2014-02-13 Thread Tom Lane
Fix length checking for Unicode identifiers containing escapes (U&"..."). We used the length of the input string, not the de-escaped string, as the trigger for NAMEDATALEN truncation. AFAICS this would only result in sometimes printing a phony truncation warning; but it's just luck that there was

[COMMITTERS] pgsql: pg_upgrade: mention the need for tablespace snapshots in docs

2014-02-13 Thread Bruce Momjian
pg_upgrade: mention the need for tablespace snapshots in docs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3f735ae831d3c249378280050b104ff751dfc668 Modified Files -- doc/src/sgml/pgupgrade.sgml |7 --- 1 file changed, 4 insertions(+), 3 deletio