Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-18 Thread Andres Freund
On 2014-02-18 22:23:59 +0200, Heikki Linnakangas wrote: > On 02/18/2014 09:39 PM, Alvaro Herrera wrote: > >Heikki Linnakangas wrote: > >>Add a GUC to report whether data page checksums are enabled. > > > >Is there are reason this wasn't back-patched to 9.3? I think it should > >be. Thirded. > I

Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-18 Thread Heikki Linnakangas
On 02/18/2014 09:39 PM, Alvaro Herrera wrote: Heikki Linnakangas wrote: Add a GUC to report whether data page checksums are enabled. Is there are reason this wasn't back-patched to 9.3? I think it should be. I considered it a new feature, so not back-patching was the default. If you want t

Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-18 Thread Peter Geoghegan
On Tue, Feb 18, 2014 at 11:39 AM, Alvaro Herrera wrote: > Is there are reason this wasn't back-patched to 9.3? I think it should > be. +1. -- Peter Geoghegan -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgre

Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-18 Thread Alvaro Herrera
Heikki Linnakangas wrote: > Add a GUC to report whether data page checksums are enabled. Is there are reason this wasn't back-patched to 9.3? I think it should be. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent

[COMMITTERS] pgsql: Remove broken code that tried to handle OVERLAPS with a single a

2014-02-18 Thread Tom Lane
Remove broken code that tried to handle OVERLAPS with a single argument. The SQL standard says that OVERLAPS should have a two-element row constructor on each side. The original coding of OVERLAPS support in our grammar attempted to extend that by allowing a single-element row constructor, which

[COMMITTERS] pgsql: Remove broken code that tried to handle OVERLAPS with a single a

2014-02-18 Thread Tom Lane
Remove broken code that tried to handle OVERLAPS with a single argument. The SQL standard says that OVERLAPS should have a two-element row constructor on each side. The original coding of OVERLAPS support in our grammar attempted to extend that by allowing a single-element row constructor, which

[COMMITTERS] pgsql: Remove broken code that tried to handle OVERLAPS with a single a

2014-02-18 Thread Tom Lane
Remove broken code that tried to handle OVERLAPS with a single argument. The SQL standard says that OVERLAPS should have a two-element row constructor on each side. The original coding of OVERLAPS support in our grammar attempted to extend that by allowing a single-element row constructor, which

[COMMITTERS] pgsql: Remove broken code that tried to handle OVERLAPS with a single a

2014-02-18 Thread Tom Lane
Remove broken code that tried to handle OVERLAPS with a single argument. The SQL standard says that OVERLAPS should have a two-element row constructor on each side. The original coding of OVERLAPS support in our grammar attempted to extend that by allowing a single-element row constructor, which

[COMMITTERS] pgsql: Remove broken code that tried to handle OVERLAPS with a single a

2014-02-18 Thread Tom Lane
Remove broken code that tried to handle OVERLAPS with a single argument. The SQL standard says that OVERLAPS should have a two-element row constructor on each side. The original coding of OVERLAPS support in our grammar attempted to extend that by allowing a single-element row constructor, which

[COMMITTERS] pgsql: Remove broken code that tried to handle OVERLAPS with a single a

2014-02-18 Thread Tom Lane
Remove broken code that tried to handle OVERLAPS with a single argument. The SQL standard says that OVERLAPS should have a two-element row constructor on each side. The original coding of OVERLAPS support in our grammar attempted to extend that by allowing a single-element row constructor, which

[COMMITTERS] pgsql: Disable RandomizedBaseAddress on MSVC builds

2014-02-18 Thread Magnus Hagander
Disable RandomizedBaseAddress on MSVC builds The ASLR in Windows 8/Windows 2012 can break PostgreSQL's shared memory. It doesn't fail every time (which is explained by the Random part in ASLR), but can fail with errors abut failing to reserve shared memory region. MauMau, reviewed by Craig Ringer

[COMMITTERS] pgsql: Disable RandomizedBaseAddress on MSVC builds

2014-02-18 Thread Magnus Hagander
Disable RandomizedBaseAddress on MSVC builds The ASLR in Windows 8/Windows 2012 can break PostgreSQL's shared memory. It doesn't fail every time (which is explained by the Random part in ASLR), but can fail with errors abut failing to reserve shared memory region. MauMau, reviewed by Craig Ringer

[COMMITTERS] pgsql: Disable RandomizedBaseAddress on MSVC builds

2014-02-18 Thread Magnus Hagander
Disable RandomizedBaseAddress on MSVC builds The ASLR in Windows 8/Windows 2012 can break PostgreSQL's shared memory. It doesn't fail every time (which is explained by the Random part in ASLR), but can fail with errors abut failing to reserve shared memory region. MauMau, reviewed by Craig Ringer