[COMMITTERS] pgsql: Add a pg_lsn data type, to represent an LSN.

2014-02-19 Thread Robert Haas
Add a pg_lsn data type, to represent an LSN. Robert Haas and Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7d03a83f4d0736ba869fa6f93973f7623a27038a Modified Files -- doc/src/sgml/datatype.sgml | 32 ++ src/backend/utils/a

[COMMITTERS] pgsql: pg_lsn macro naming and type behavior revisions.

2014-02-19 Thread Robert Haas
pg_lsn macro naming and type behavior revisions. Change pg_lsn_mi so that it can return negative values when subtracting LSNs, and clean up some perhaps ill-considered macro names. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/844a28a9dd1a48045ad1db9246da5e2783c9bd

[COMMITTERS] pgsql: Further code review for pg_lsn data type.

2014-02-19 Thread Robert Haas
Further code review for pg_lsn data type. Change input function error messages to be more consistent with what is done elsewhere. Remove a bunch of redundant type casts, so that the compiler will warn us if we screw up. Don't pass LSNs by value on platforms where a Datum is only 32 bytes, per bu

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-19 Thread Bernd Helmle
--On 18. Februar 2014 22:23:59 +0200 Heikki Linnakangas wrote: I considered it a new feature, so not back-patching was the default. If you want to back-patch it, I won't object. That was my original feeling, too, but +1 for backpatching. -- Thanks Bernd -- Sent via pgsql-commi

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-19 Thread David Fetter
On Tue, Feb 18, 2014 at 04:39:27PM -0300, Alvaro Herrera wrote: > Heikki Linnakangas wrote: > > Add a GUC to report whether data page checksums are enabled. > > Is there are reason this wasn't back-patched to 9.3? I think it should > be. +1 for back-patching. Cheers, David. -- David Fetter ht

[COMMITTERS] pgsql: Tag refs/tags/REL8_4_20 was created

2014-02-19 Thread pgsql
Tag refs/tags/REL8_4_20 was created. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Tag refs/tags/REL9_1_12 was created

2014-02-19 Thread pgsql
Tag refs/tags/REL9_1_12 was created. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Tag refs/tags/REL9_3_3 was created

2014-02-19 Thread pgsql
Tag refs/tags/REL9_3_3 was created. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Tag refs/tags/REL9_0_16 was created

2014-02-19 Thread pgsql
Tag refs/tags/REL9_0_16 was created. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Tag refs/tags/REL9_2_7 was created

2014-02-19 Thread pgsql
Tag refs/tags/REL9_2_7 was created. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Switch various builtin functions to use pg_lsn instead of text.

2014-02-19 Thread Robert Haas
Switch various builtin functions to use pg_lsn instead of text. The functions in slotfuncs.c don't exist in any released version, but the changes to xlogfuncs.c represent backward-incompatibilities. Per discussion, we're hoping that the queries using these functions are few enough and simple enoug

[COMMITTERS] pgsql: Document pg_replslot in storage.sgml.

2014-02-19 Thread Robert Haas
Document pg_replslot in storage.sgml. Per an observation from Amit Kapila. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7b3cf9ba9d3d12ad95c0a06cef04f9097a9c65cf Modified Files -- doc/src/sgml/storage.sgml |5 + 1 file changed, 5 insertions(+)

[COMMITTERS] pgsql: Fix some missing .gitignore and "make clean" items in ecpg.

2014-02-19 Thread Tom Lane
Fix some missing .gitignore and "make clean" items in ecpg. Some of the files we optionally link in from elsewhere weren't ignored and/or weren't cleaned up at "make clean". Noted while testing on a machine that needs our version of snprintf.c. Branch -- master Details --- http://git.po

[COMMITTERS] pgsql: Avoid using dllwrap to build pgevent in Mingw builds.

2014-02-19 Thread Tom Lane
Avoid using dllwrap to build pgevent in Mingw builds. If this works, we can get rid of configure's support for locating dllwrap ... but let's see what the buildfarm says, first. Hiroshi Inoue Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4f5f485d10cad372a3a0cd8dd7

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-19 Thread Michael Paquier
On Thu, Feb 20, 2014 at 1:01 AM, David Fetter wrote: > On Tue, Feb 18, 2014 at 04:39:27PM -0300, Alvaro Herrera wrote: >> Heikki Linnakangas wrote: >> > Add a GUC to report whether data page checksums are enabled. >> >> Is there are reason this wasn't back-patched to 9.3? I think it should >> be.

Re: [COMMITTERS] pgsql: Further code review for pg_lsn data type.

2014-02-19 Thread Andres Freund
Hi, On 2014-02-19 15:10:52 +, Robert Haas wrote: > Change input function error messages to be more consistent with what is > done elsewhere. Remove a bunch of redundant type casts, so that the > compiler will warn us if we screw up. Don't pass LSNs by value on > platforms where a Datum is on

[COMMITTERS] pgsql: Remove inappropriate EXPORTS line.

2014-02-19 Thread Tom Lane
Remove inappropriate EXPORTS line. Looks like this gets added later ... Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ae5266f25910d6e084692a7cdbd02b9e52800046 Modified Files -- src/bin/pgevent/exports.txt |2 -- 1 file changed, 2 deletions(-) --

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-19 Thread Peter Geoghegan
On Wed, Feb 19, 2014 at 4:49 PM, Michael Paquier wrote: >> +1 for back-patching. > Back-patching would be interesting for existing applications, but -1 > as it is a new feature :) I think that it rises to the level of an omission in 9.3 that now requires correction. Many of our users couldn't run

Re: [COMMITTERS] pgsql: Further code review for pg_lsn data type.

2014-02-19 Thread Heikki Linnakangas
On 02/20/2014 02:56 AM, Andres Freund wrote: On 2014-02-19 15:10:52 +, Robert Haas wrote: Change input function error messages to be more consistent with what is done elsewhere. Remove a bunch of redundant type casts, so that the compiler will warn us if we screw up. Don't pass LSNs by val

Re: [COMMITTERS] pgsql: Further code review for pg_lsn data type.

2014-02-19 Thread Andres Freund
On 2014-02-20 08:25:01 +0200, Heikki Linnakangas wrote: > On 02/20/2014 02:56 AM, Andres Freund wrote: > >On 2014-02-19 15:10:52 +, Robert Haas wrote: > >>Change input function error messages to be more consistent with what is > >>done elsewhere. Remove a bunch of redundant type casts, so that