[COMMITTERS] pgsql: Fix WAL replay of locking an updated tuple

Fix WAL replay of locking an updated tuple We were resetting the tuple's HEAP_HOT_UPDATED flag as well as t_ctid on WAL replay of a tuple-lock operation, which is incorrect when the tuple is already updated. Back-patch to 9.3. The clearing of both header elements was there previously, but since

[COMMITTERS] pgsql: Fix WAL replay of locking an updated tuple

Fix WAL replay of locking an updated tuple We were resetting the tuple's HEAP_HOT_UPDATED flag as well as t_ctid on WAL replay of a tuple-lock operation, which is incorrect when the tuple is already updated. Back-patch to 9.3. The clearing of both header elements was there previously, but since

Re: [COMMITTERS] pgsql: Fix WAL replay of locking an updated tuple

Alvaro Herrera writes: > Fix WAL replay of locking an updated tuple The test added by this patch certainly looks like it's backwards. Shouldn't you be clearing HOT_UPDATED only if the tuple is *not* XMAX_IS_LOCKED_ONLY? If the code is actually correct as written, then I think that test macro is

Re: [COMMITTERS] pgsql: Introduce replication slots.

Hi, Vik Faering noticed a couple of oversights in the replication slot function reference, and I noticed some more, including using the text type instead of name, while looking. Patch attached. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ Postgre

[COMMITTERS] pgsql: doc: bgw_main takes a Datum argument, not void *.

doc: bgw_main takes a Datum argument, not void *. Per report from James Harper. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9b4bd35aa1f185b3ad5b2e3d51a524f5bb77f577 Modified Files -- doc/src/sgml/bgworker.sgml |4 ++-- 1 file changed, 2 ins

[COMMITTERS] pgsql: doc: bgw_main takes a Datum argument, not void *.

doc: bgw_main takes a Datum argument, not void *. Per report from James Harper. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4333eee82d399df8f724faa331827dcfae1fdf28 Modified Files -- doc/src/sgml/bgworker.sgml |4 ++-- 1 file changed, 2 insertions

Re: [COMMITTERS] pgsql: Fix WAL replay of locking an updated tuple

Tom Lane wrote: > Alvaro Herrera writes: > > Fix WAL replay of locking an updated tuple > > The test added by this patch certainly looks like it's backwards. > Shouldn't you be clearing HOT_UPDATED only if the tuple is *not* > XMAX_IS_LOCKED_ONLY? > > If the code is actually correct as written,

Re: [COMMITTERS] pgsql: Fix WAL replay of locking an updated tuple

On 2014-02-27 09:41:03 -0500, Tom Lane wrote: > Alvaro Herrera writes: > > Fix WAL replay of locking an updated tuple > > The test added by this patch certainly looks like it's backwards. > Shouldn't you be clearing HOT_UPDATED only if the tuple is *not* > XMAX_IS_LOCKED_ONLY? If it's not XMAX_I

[COMMITTERS] pgsql: Remove dependency on database encoding in citext regression test

Remove dependency on database encoding in citext regression test. Testing convert_to(..., 'ISO-8859-1') fails if there isn't a conversion function available from the database encoding to ISO-8859-1. This has been broken since day one, but the breakage was hidden by pg_do_encoding_conversion's fai

[COMMITTERS] pgsql: Allow BASE_BACKUP to be throttled

Allow BASE_BACKUP to be throttled A new MAX_RATE option allows imposing a limit to the network transfer rate from the server side. This is useful to limit the stress that taking a base backup has on the server. pg_basebackup is now able to specify a value to the server, too. Author: Antonin Hou

[COMMITTERS] pgsql: pgbench: Fix help message

pgbench: Fix help message Add NUM placeholder to -t option in help message. It got lost in 79cddb18419778be3202c971b3f21cdd90f7b719. Author: Fabien COELHO Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/192d8e04bd3112965d47bb4dc6747ee984abaf07 Modified Files