[COMMITTERS] pgsql: Documentation corrections for pg_replication_slots.

2014-04-30 Thread Robert Haas
Documentation corrections for pg_replication_slots. Thomas Reiss, with changes to the catalog_xmin language by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/65fb5ff13009ef34ff95300d3e03540cf872e494 Modified Files -- doc/src/sgml/catalogs.sgml | 2

[COMMITTERS] pgsql: Improve error messages in reorderbuffer.c.

2014-04-30 Thread Tom Lane
Improve error messages in reorderbuffer.c. Be more clear about failure cases in relfilenode->relation lookup, and fix some other places that were inconsistent or not per our message style guidelines. Andres Freund and Tom Lane Branch -- master Details --- http://git.postgresql.org/pg/co

[COMMITTERS] pgsql: Consistently allow reading of messages from a detached shm_mq.

2014-04-30 Thread Robert Haas
Consistently allow reading of messages from a detached shm_mq. This was intended to work always, but the previous code only allowed it if at least one message was successfully read by the receiver before the sender detached the queue. Report by Petr Jelinek. Patch by me. Branch -- master D

[COMMITTERS] pgsql: Rationalize common/relpath.[hc].

2014-04-30 Thread Tom Lane
Rationalize common/relpath.[hc]. Commit a73018392636ce832b09b5c31f6ad1f18a4643ea created rather a mess by putting dependencies on backend-only include files into include/common. We really shouldn't do that. To clean it up: * Move TABLESPACE_VERSION_DIRECTORY back to its longtime home in catalog/

[COMMITTERS] pgsql: Check for interrupts and stack overflow during rule/view dumps.

2014-04-30 Thread Tom Lane
Check for interrupts and stack overflow during rule/view dumps. Since ruleutils.c recurses, it could be driven to stack overflow by deeply nested constructs. Very large queries might also take long enough to deparse that a check for interrupts seems like a good idea. Stick appropriate tests into

[COMMITTERS] pgsql: Check for interrupts and stack overflow during rule/view dumps.

2014-04-30 Thread Tom Lane
Check for interrupts and stack overflow during rule/view dumps. Since ruleutils.c recurses, it could be driven to stack overflow by deeply nested constructs. Very large queries might also take long enough to deparse that a check for interrupts seems like a good idea. Stick appropriate tests into

[COMMITTERS] pgsql: Check for interrupts and stack overflow during rule/view dumps.

2014-04-30 Thread Tom Lane
Check for interrupts and stack overflow during rule/view dumps. Since ruleutils.c recurses, it could be driven to stack overflow by deeply nested constructs. Very large queries might also take long enough to deparse that a check for interrupts seems like a good idea. Stick appropriate tests into

[COMMITTERS] pgsql: Check for interrupts and stack overflow during rule/view dumps.

2014-04-30 Thread Tom Lane
Check for interrupts and stack overflow during rule/view dumps. Since ruleutils.c recurses, it could be driven to stack overflow by deeply nested constructs. Very large queries might also take long enough to deparse that a check for interrupts seems like a good idea. Stick appropriate tests into

[COMMITTERS] pgsql: Check for interrupts and stack overflow during rule/view dumps.

2014-04-30 Thread Tom Lane
Check for interrupts and stack overflow during rule/view dumps. Since ruleutils.c recurses, it could be driven to stack overflow by deeply nested constructs. Very large queries might also take long enough to deparse that a check for interrupts seems like a good idea. Stick appropriate tests into

[COMMITTERS] pgsql: Check for interrupts and stack overflow during rule/view dumps.

2014-04-30 Thread Tom Lane
Check for interrupts and stack overflow during rule/view dumps. Since ruleutils.c recurses, it could be driven to stack overflow by deeply nested constructs. Very large queries might also take long enough to deparse that a check for interrupts seems like a good idea. Stick appropriate tests into

[COMMITTERS] pgsql: Reduce indentation/parenthesization of set operations in rule/vi

2014-04-30 Thread Tom Lane
Reduce indentation/parenthesization of set operations in rule/view dumps. A query such as "SELECT x UNION SELECT y UNION SELECT z UNION ..." produces a left-deep nested parse tree, which we formerly showed in its full nested glory and with all the possible parentheses. This does little for readab

[COMMITTERS] pgsql: Reduce indentation/parenthesization of set operations in rule/vi

2014-04-30 Thread Tom Lane
Reduce indentation/parenthesization of set operations in rule/view dumps. A query such as "SELECT x UNION SELECT y UNION SELECT z UNION ..." produces a left-deep nested parse tree, which we formerly showed in its full nested glory and with all the possible parentheses. This does little for readab

[COMMITTERS] pgsql: Limit overall indentation in rule/view dumps.

2014-04-30 Thread Tom Lane
Limit overall indentation in rule/view dumps. Continuing to indent no matter how deeply nested we get doesn't really do anything for readability; what's worse, it results in O(N^2) total whitespace, which can become a performance and memory-consumption issue. To address this, once we get past 40

[COMMITTERS] pgsql: Limit overall indentation in rule/view dumps.

2014-04-30 Thread Tom Lane
Limit overall indentation in rule/view dumps. Continuing to indent no matter how deeply nested we get doesn't really do anything for readability; what's worse, it results in O(N^2) total whitespace, which can become a performance and memory-consumption issue. To address this, once we get past 40

[COMMITTERS] pgsql: Fix indentation of JOIN clauses in rule/view dumps.

2014-04-30 Thread Tom Lane
Fix indentation of JOIN clauses in rule/view dumps. The code attempted to outdent JOIN clauses further left than the parent FROM keyword, which was odd in any case, and led to inconsistent formatting since in simple cases the clauses couldn't be moved any further left than that. And it left a per

[COMMITTERS] pgsql: Fix indentation of JOIN clauses in rule/view dumps.

2014-04-30 Thread Tom Lane
Fix indentation of JOIN clauses in rule/view dumps. The code attempted to outdent JOIN clauses further left than the parent FROM keyword, which was odd in any case, and led to inconsistent formatting since in simple cases the clauses couldn't be moved any further left than that. And it left a per

[COMMITTERS] pgsql: Fix uninitialized-variable warnings induced by recent commit.

2014-04-30 Thread Tom Lane
Fix uninitialized-variable warnings induced by recent commit. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5358bfdc98a47d26649ae094dab88842a0603968 Modified Files -- src/bin/psql/print.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --

[COMMITTERS] pgsql: Add missing SYSTEMQUOTEs

2014-04-30 Thread Heikki Linnakangas
Add missing SYSTEMQUOTEs Some popen() calls were missing SYSTEMQUOTEs, which caused initdb and pg_upgrade to fail on Windows, if the installation path contained both spaces and @ signs. Patch by Nikhil Deshpande. Backpatch to all supported versions. Branch -- REL9_1_STABLE Details --- h

[COMMITTERS] pgsql: Add missing SYSTEMQUOTEs

2014-04-30 Thread Heikki Linnakangas
Add missing SYSTEMQUOTEs Some popen() calls were missing SYSTEMQUOTEs, which caused initdb and pg_upgrade to fail on Windows, if the installation path contained both spaces and @ signs. Patch by Nikhil Deshpande. Backpatch to all supported versions. Branch -- REL9_3_STABLE Details --- h

[COMMITTERS] pgsql: Add missing SYSTEMQUOTEs

2014-04-30 Thread Heikki Linnakangas
Add missing SYSTEMQUOTEs Some popen() calls were missing SYSTEMQUOTEs, which caused initdb and pg_upgrade to fail on Windows, if the installation path contained both spaces and @ signs. Patch by Nikhil Deshpande. Backpatch to all supported versions. Branch -- master Details --- http://g

[COMMITTERS] pgsql: Add missing SYSTEMQUOTEs

2014-04-30 Thread Heikki Linnakangas
Add missing SYSTEMQUOTEs Some popen() calls were missing SYSTEMQUOTEs, which caused initdb and pg_upgrade to fail on Windows, if the installation path contained both spaces and @ signs. Patch by Nikhil Deshpande. Backpatch to all supported versions. Branch -- REL9_0_STABLE Details --- h

[COMMITTERS] pgsql: Add missing SYSTEMQUOTEs

2014-04-30 Thread Heikki Linnakangas
Add missing SYSTEMQUOTEs Some popen() calls were missing SYSTEMQUOTEs, which caused initdb and pg_upgrade to fail on Windows, if the installation path contained both spaces and @ signs. Patch by Nikhil Deshpande. Backpatch to all supported versions. Branch -- REL8_4_STABLE Details --- h

[COMMITTERS] pgsql: Add missing SYSTEMQUOTEs

2014-04-30 Thread Heikki Linnakangas
Add missing SYSTEMQUOTEs Some popen() calls were missing SYSTEMQUOTEs, which caused initdb and pg_upgrade to fail on Windows, if the installation path contained both spaces and @ signs. Patch by Nikhil Deshpande. Backpatch to all supported versions. Branch -- REL9_2_STABLE Details --- h