[COMMITTERS] pgsql: Issue a WARNING about invalid rule file format in contrib/unacce

2014-06-30 Thread Tom Lane
Issue a WARNING about invalid rule file format in contrib/unaccent. We were already issuing a WARNING, albeit only elog not ereport, for duplicate source strings; so warning rather than just being stoically silent seems like the best thing to do here. Arguably both of these complaints should be u

[COMMITTERS] pgsql: Allow multi-character source strings in contrib/unaccent.

2014-06-30 Thread Tom Lane
Allow multi-character source strings in contrib/unaccent. This could be useful in languages where diacritic signs are represented as separate characters; more generally it supports using unaccent dictionaries for substring substitutions beyond narrowly conceived "diacritic removal". In any case, s

[COMMITTERS] pgsql: Allow empty replacement strings in contrib/unaccent.

2014-06-30 Thread Tom Lane
Allow empty replacement strings in contrib/unaccent. This is useful in languages where diacritic signs are represented as separate characters; it's also one step towards letting unaccent be used for arbitrary substring substitutions. In passing, improve the user documentation for unaccent, which

[COMMITTERS] pgsql: pg_upgrade: update C comments about pg_dumpall

2014-06-30 Thread Bruce Momjian
pg_upgrade: update C comments about pg_dumpall There were some C comments that hadn't been updated from the switch of using only pg_dumpall to using pg_dump and pg_dumpall, so update them. Also, don't bother using --schema-only for pg_dumpall --globals-only. Backpatch through 9.4 Branch --

[COMMITTERS] pgsql: pg_upgrade: update C comments about pg_dumpall

2014-06-30 Thread Bruce Momjian
pg_upgrade: update C comments about pg_dumpall There were some C comments that hadn't been updated from the switch of using only pg_dumpall to using pg_dump and pg_dumpall, so update them. Also, don't bother using --schema-only for pg_dumpall --globals-only. Backpatch through 9.4 Branch --

[COMMITTERS] pgsql: Don't prematurely free the BufferAccessStrategy in pgstat_heap()

2014-06-30 Thread Noah Misch
Don't prematurely free the BufferAccessStrategy in pgstat_heap(). This function continued to use it after heap_endscan() freed it. In passing, don't explicit create a strategy here. Instead, use the one created by heap_beginscan_strat(), if any. Back-patch to 9.2, where use of a BufferAccessStr

[COMMITTERS] pgsql: Don't prematurely free the BufferAccessStrategy in pgstat_heap()

2014-06-30 Thread Noah Misch
Don't prematurely free the BufferAccessStrategy in pgstat_heap(). This function continued to use it after heap_endscan() freed it. In passing, don't explicit create a strategy here. Instead, use the one created by heap_beginscan_strat(), if any. Back-patch to 9.2, where use of a BufferAccessStr

[COMMITTERS] pgsql: Don't prematurely free the BufferAccessStrategy in pgstat_heap()

2014-06-30 Thread Noah Misch
Don't prematurely free the BufferAccessStrategy in pgstat_heap(). This function continued to use it after heap_endscan() freed it. In passing, don't explicit create a strategy here. Instead, use the one created by heap_beginscan_strat(), if any. Back-patch to 9.2, where use of a BufferAccessStr

[COMMITTERS] pgsql: Don't prematurely free the BufferAccessStrategy in pgstat_heap()

2014-06-30 Thread Noah Misch
Don't prematurely free the BufferAccessStrategy in pgstat_heap(). This function continued to use it after heap_endscan() freed it. In passing, don't explicit create a strategy here. Instead, use the one created by heap_beginscan_strat(), if any. Back-patch to 9.2, where use of a BufferAccessStr

Re: [COMMITTERS] pgsql: Check interrupts during logical decoding more frequently.

2014-06-30 Thread Andres Freund
On 2014-06-30 10:10:24 -0400, Tom Lane wrote: > Andres Freund writes: > > Check interrupts during logical decoding more frequently. > > FWIW, I think it's usually better style to put CHECK_FOR_INTERRUPTS > at the tops of loops rather than the bottoms. If you put it at the > bottom, it's easily b

Re: [COMMITTERS] pgsql: Check interrupts during logical decoding more frequently.

2014-06-30 Thread Tom Lane
Andres Freund writes: > Check interrupts during logical decoding more frequently. FWIW, I think it's usually better style to put CHECK_FOR_INTERRUPTS at the tops of loops rather than the bottoms. If you put it at the bottom, it's easily bypassed unintentionally by a "continue" somewhere in the m

[COMMITTERS] pgsql: Check interrupts during logical decoding more frequently.

2014-06-30 Thread Andres Freund
Check interrupts during logical decoding more frequently. When reading large amounts of preexisting WAL during logical decoding using the SQL interface we possibly could fail to check interrupts in due time. Similarly the same could happen on systems with a very high WAL volume while creating a ne

[COMMITTERS] pgsql: Fix typos in the cluster_name commit.

2014-06-30 Thread Andres Freund
Fix typos in the cluster_name commit. Thom Brown and Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6647f59fd256927aaf9e35929b5c284d10d18839 Modified Files -- doc/src/sgml/config.sgml |2 +- doc/src/sgml/monitoring.sgml |2 +- 2 fi

[COMMITTERS] pgsql: Check interrupts during logical decoding more frequently.

2014-06-30 Thread Andres Freund
Check interrupts during logical decoding more frequently. When reading large amounts of preexisting WAL during logical decoding using the SQL interface we possibly could fail to check interrupts in due time. Similarly the same could happen on systems with a very high WAL volume while creating a ne

Re: [COMMITTERS] pgsql: Add cluster_name GUC which is included in process titles if set.

2014-06-30 Thread Thom Brown
On 29 June 2014 13:24, Andres Freund wrote: > Add cluster_name GUC which is included in process titles if set. > > When running several postgres clusters on one OS instance it's often > inconveniently hard to identify which "postgres" process belongs to > which postgres instance. > > Add the clus

[COMMITTERS] pgsql: Fix and enhance the assertion of no palloc's in a critical secti

2014-06-30 Thread Heikki Linnakangas
Fix and enhance the assertion of no palloc's in a critical section. The assertion failed if WAL_DEBUG or LWLOCK_STATS was enabled; fix that by using separate memory contexts for the allocations made within those code blocks. This patch introduces a mechanism for marking any memory context as allo

[COMMITTERS] pgsql: Revert the assertion of no palloc's in critical section.

2014-06-30 Thread Heikki Linnakangas
Revert the assertion of no palloc's in critical section. Per discussion, it still fires too often to be safe to enable in production. Keep it in master, so that we find the issues, but disable it in the stable branch. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commi