Bruce Momjian writes:
> pg_upgrade: prevent automatic oid assignment
One or another of these pg_upgrade changes broke the Windows build.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
pg_upgrade: prevent automatic oid assignment
Prevent automatic oid assignment when in binary upgrade mode. Also
throw an error when contrib/pg_upgrade_support functions are called when
not in binary upgrade mode.
This prevent automatically-assigned oids from conflicting with later
pre-assigned
rename macro isTempOrToastNamespace to isTempOrTempToastNamespace
Done for clarity
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/73fe87503f23144a27f0bdecc55587deb5aa425f
Modified Files
--
src/backend/catalog/namespace.c| 10 +-
src/backend
pg_upgrade: use CTE query rather than temp table
Now that 8.3 is not supported, we can use a CTE and not temp tables.
This allows for auto-oid assignment protection in a future patch.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/5d16332e96977d8166ea631891f6e2cf3f
pg_upgrade docs: update docs for 8.3 support removal
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/e8c81b1b8e51475dd5a787660e6754c4bafbff47
Modified Files
--
doc/src/sgml/pgupgrade.sgml | 84 ++-
1 file changed,
revert "Throw error for ALTER TABLE RESET of an invalid option"
Reverts commits 73d78e11a0f7183c80b93eefbbb6026fe9664015 and
b0488e5c4fbfdce8acc989bdc17d9f0ec09ac281. Also reverts pg_upgrade
changes.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/6cb74a67e26523eb24
On Mon, Aug 25, 2014 at 07:44:06PM -0400, Tom Lane wrote:
> A larger point is that we could easily consider RESET as meaning
> "remove this option *if it's applied to this relation*", which would
> mean that resetting a nonexistent option shouldn't be an error.
> If we don't define the action that
pg_upgrade: remove support for 8.3 old clusters
This trims down the code, and is in preparation for hardening pg_upgrade
against auto-oid assignment.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/2209b3923a7afe0b6033ecfea972219df252ca8e
Modified Files
---
Bruce Momjian writes:
> On Mon, Aug 25, 2014 at 11:30:53PM +0200, Andres Freund wrote:
>> I still think this is a bad idea and should rather be reverted.
> Uh, which idea don't you like. I thought the discussion had a clear
> conclusion.
The discussion seemed to have a consensus that an error w
On Mon, Aug 25, 2014 at 11:30:53PM +0200, Andres Freund wrote:
> On 2014-08-25 21:06:43 +, Bruce Momjian wrote:
> > Throw error for ALTER TABLE RESET of an invalid option
> >
> > Also adjust pg_upgrade to not use this method for optional TOAST table
> > creation.
> >
> > Patch by Fabrízio de
On 2014-08-25 21:06:43 +, Bruce Momjian wrote:
> Throw error for ALTER TABLE RESET of an invalid option
>
> Also adjust pg_upgrade to not use this method for optional TOAST table
> creation.
>
> Patch by Fabrízio de Royes Mello
I still think this is a bad idea and should rather be reverted.
pg_upgrade: add SET log_min_error_statement = warning
Add to commit 73d78e11a0f7183c80b93eefbbb6026fe9664015
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/b0488e5c4fbfdce8acc989bdc17d9f0ec09ac281
Modified Files
--
contrib/pg_upgrade/dump.c |2 ++
1
Throw error for ALTER TABLE RESET of an invalid option
Also adjust pg_upgrade to not use this method for optional TOAST table
creation.
Patch by Fabrízio de Royes Mello
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/73d78e11a0f7183c80b93eefbbb6026fe9664015
Modifie
pg_ctl, pg_upgrade: allow multiple -o/-O options, append them
Report by Pavel Raiskup
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/ebe30ad59bb2d127f576be07e036a473999c4b80
Modified Files
--
contrib/pg_upgrade/option.c| 24 ++
upgrade docs: highlight pg_upgrade, warn about globals preservation
Also, remove OID preservation mention, mention non-text dump formats
Backpatch through 9.4
Branch
--
REL9_4_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/3a3d3f9ec01f1f7333e3bbcd5ba9398fd19ad8d9
Modified
DefineType: return base type OID, not its array
Event triggers want to know the OID of the interesting object created,
which is the main type. The array created as part of the operation is
just a subsidiary object which is not of much interest.
Branch
--
master
Details
---
http://git.po
upgrade docs: highlight pg_upgrade, warn about globals preservation
Also, remove OID preservation mention, mention non-text dump formats
Backpatch through 9.4
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/bf1c866597a0e59a30b13a66f3ae505655b61853
Modified Files
-
Have CREATE TABLE AS and REFRESH return an OID
Other DDL commands are already returning the OID, which is required for
future additional event trigger work. This is merely making these
commands in line with the rest of utility command support.
Branch
--
master
Details
---
http://git.pos
Revert XactLockTableWait context setup in conditional multixact wait
There's no point in setting up a context error callback when doing
conditional lock acquisition, because we never actually wait and so the
able wouldn't be able to see it.
Backpatch to 9.4, where this was added.
Branch
--
R
Use newly added InvalidCommandId instead of 0
The symbol was added by 71901ab6d; the original code was introduced by
6868ed749. Development of both overlapped which is why we apparently
failed to notice.
This is a (very slight) behavior change, so I'm not backpatching this to
9.4 for now, even t
Revert XactLockTableWait context setup in conditional multixact wait
There's no point in setting up a context error callback when doing
conditional lock acquisition, because we never actually wait and so the
user wouldn't be able to see the context message anywhere. In fact,
this is more in line
Oops, forgot to "git add" one last change
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/ac41769fd9dca9f4a6ee5fa859a56c08e8bb95fe
Modified Files
--
src/backend/commands/tablecmds.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
--
More psprintf goodness
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/d6d6020f1cf33a63bbae59d370b75fa5e98017f0
Modified Files
--
src/backend/parser/gram.y |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--
Sent via pgsql-committers mailing
Editorial review of SET UNLOGGED
Add a succint comment explaining why it's correct to change the
persistence in this way. Also s/loggedness/persistence/ because native
speakers didn't like the latter term.
Fabrízio and Álvaro
Branch
--
master
Details
---
http://git.postgresql.org/pg/co
Add regression tests for SELECT FOR UPDATE/SHARE NOWAIT.
Thomas Munro
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/9ee16b49f0aac819bd4823d9b94485ef608b34e8
Modified Files
--
src/test/isolation/expected/nowait-2.out | 43
src/test
On 2014-08-25 12:57:45 -0400, Tom Lane wrote:
> Andres Freund writes:
> > Fix typos in some error messages thrown by extension scripts when fed to
> > psql.
> > Some of the many error messages introduced in 458857cc missed 'FROM
> > unpackaged'. Also e016b724 and 45ffeb7e forgot to quote extensio
Fix typos in some error messages thrown by extension scripts when fed to psql.
Some of the many error messages introduced in 458857cc missed 'FROM
unpackaged'. Also e016b724 and 45ffeb7e forgot to quote extension
version numbers.
Backpatch to 9.1, just like 458857cc which introduced the messages.
Andres Freund writes:
> Fix typos in some error messages thrown by extension scripts when fed to psql.
> Some of the many error messages introduced in 458857cc missed 'FROM
> unpackaged'. Also e016b724 and 45ffeb7e forgot to quote extension
> version numbers.
You seem to have missed the 9.4 branc
Fix typos in some error messages thrown by extension scripts when fed to psql.
Some of the many error messages introduced in 458857cc missed 'FROM
unpackaged'. Also e016b724 and 45ffeb7e forgot to quote extension
version numbers.
Backpatch to 9.1, just like 458857cc which introduced the messages.
Fix typos in some error messages thrown by extension scripts when fed to psql.
Some of the many error messages introduced in 458857cc missed 'FROM
unpackaged'. Also e016b724 and 45ffeb7e forgot to quote extension
version numbers.
Backpatch to 9.1, just like 458857cc which introduced the messages.
Backpatch: Fix typo in update scripts for some contrib modules.
Backpatch as discussed in 20140702192641.gd22...@awork2.anarazel.de
ff. as the error messages are user facing and possibly confusing.
Original commit: 6f9e39bc9993c18686f0950f9b9657c7c97c7450
Branch
--
REL9_2_STABLE
Details
---
Fix typos in some error messages thrown by extension scripts when fed to psql.
Some of the many error messages introduced in 458857cc missed 'FROM
unpackaged'. Also e016b724 and 45ffeb7e forgot to quote extension
version numbers.
Backpatch to 9.1, just like 458857cc which introduced the messages.
Backpatch: Fix typo in update scripts for some contrib modules.
Backpatch as discussed in 20140702192641.gd22...@awork2.anarazel.de
ff. as the error messages are user facing and possibly confusing.
Original commit: 6f9e39bc9993c18686f0950f9b9657c7c97c7450
Branch
--
REL9_3_STABLE
Details
---
Fix typos in some error messages thrown by extension scripts when fed to psql.
Some of the many error messages introduced in 458857cc missed 'FROM
unpackaged'. Also e016b724 and 45ffeb7e forgot to quote extension
version numbers.
Backpatch to 9.1, just like 458857cc which introduced the messages.
Don't track DEALLOCATE in pg_stat_statements.
We also don't track PREPARE, nor do we track planning time in general, so
let's ignore DEALLOCATE as well for consistency.
Backpatch to 9.4, but not further than that. Although it seems unlikely that
anyone is relying on the current behavior, this is
Don't track DEALLOCATE in pg_stat_statements.
We also don't track PREPARE, nor do we track planning time in general, so
let's ignore DEALLOCATE as well for consistency.
Backpatch to 9.4, but not further than that. Although it seems unlikely that
anyone is relying on the current behavior, this is
36 matches
Mail list logo
