[COMMITTERS] pgsql: Fix power_var_int() for large integer exponents.

2014-09-11 Thread Tom Lane
Fix power_var_int() for large integer exponents. The code for raising a NUMERIC value to an integer power wasn't very careful about large powers. It got an outright wrong answer for an exponent of INT_MIN, due to failure to consider overflow of the Abs(exp) operation; which is fixable by using an

[COMMITTERS] pgsql: Fix power_var_int() for large integer exponents.

2014-09-11 Thread Tom Lane
Fix power_var_int() for large integer exponents. The code for raising a NUMERIC value to an integer power wasn't very careful about large powers. It got an outright wrong answer for an exponent of INT_MIN, due to failure to consider overflow of the Abs(exp) operation; which is fixable by using an

[COMMITTERS] pgsql: Fix power_var_int() for large integer exponents.

2014-09-11 Thread Tom Lane
Fix power_var_int() for large integer exponents. The code for raising a NUMERIC value to an integer power wasn't very careful about large powers. It got an outright wrong answer for an exponent of INT_MIN, due to failure to consider overflow of the Abs(exp) operation; which is fixable by using an

[COMMITTERS] pgsql: Fix power_var_int() for large integer exponents.

2014-09-11 Thread Tom Lane
Fix power_var_int() for large integer exponents. The code for raising a NUMERIC value to an integer power wasn't very careful about large powers. It got an outright wrong answer for an exponent of INT_MIN, due to failure to consider overflow of the Abs(exp) operation; which is fixable by using an

[COMMITTERS] pgsql: Fix power_var_int() for large integer exponents.

2014-09-11 Thread Tom Lane
Fix power_var_int() for large integer exponents. The code for raising a NUMERIC value to an integer power wasn't very careful about large powers. It got an outright wrong answer for an exponent of INT_MIN, due to failure to consider overflow of the Abs(exp) operation; which is fixable by using an

[COMMITTERS] pgsql: Fix power_var_int() for large integer exponents.

2014-09-11 Thread Tom Lane
Fix power_var_int() for large integer exponents. The code for raising a NUMERIC value to an integer power wasn't very careful about large powers. It got an outright wrong answer for an exponent of INT_MIN, due to failure to consider overflow of the Abs(exp) operation; which is fixable by using an

Re: [COMMITTERS] pgsql: Fix JSON regression tests.

2014-09-11 Thread Stephen Frost
Hey Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Fix JSON regression tests. > > Commit 95d737ff45a38809130a2c633d9e6bc26c825036 neglected to update > expected/json_1.out. Per buildfarm. I had just been working on that- took me a bit to realize what was happening. Apologies. Thanks!

[COMMITTERS] pgsql: Fix JSON regression tests.

2014-09-11 Thread Tom Lane
Fix JSON regression tests. Commit 95d737ff45a38809130a2c633d9e6bc26c825036 neglected to update expected/json_1.out. Per buildfarm. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e3ec07280cc2bd4201f62cbde9a15a62eb54bc40 Modified Files -- src/test/regres

[COMMITTERS] pgsql: Fix vacuumdb --analyze-in-stages --all order

2014-09-11 Thread Peter Eisentraut
Fix vacuumdb --analyze-in-stages --all order When running vacuumdb --analyze-in-stages --all, it needs to run the first stage across all databases before the second one, instead of running all stages in a database before processing the next one. Also respect the --quiet option with --analyze-in-s

[COMMITTERS] pgsql: Fix vacuumdb --analyze-in-stages --all order

2014-09-11 Thread Peter Eisentraut
Fix vacuumdb --analyze-in-stages --all order When running vacuumdb --analyze-in-stages --all, it needs to run the first stage across all databases before the second one, instead of running all stages in a database before processing the next one. Also respect the --quiet option with --analyze-in-s

[COMMITTERS] pgsql: Add 'ignore_nulls' option to row_to_json

2014-09-11 Thread Stephen Frost
Add 'ignore_nulls' option to row_to_json Provide an option to skip NULL values in a row when generating a JSON object from that row with row_to_json. This can reduce the size of the JSON object in cases where columns are NULL without really reducing the information in the JSON object. This also

[COMMITTERS] pgsql: pg_upgrade: adjust C comments

2014-09-11 Thread Bruce Momjian
pg_upgrade: adjust C comments Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c3c75fcd7a03067d87b830e98e3698b683446762 Modified Files -- contrib/pg_upgrade/controldata.c | 50 +++--- 1 file changed, 25 insertions(+), 25 d

[COMMITTERS] pgsql: pg_upgrade: preserve the timestamp epoch

2014-09-11 Thread Bruce Momjian
pg_upgrade: preserve the timestamp epoch This is useful for replication tools like Slony and Skytools. This is a backpatch of a74a4aa23bb95b590ff01ee564219d2eacea3706. Report by Sergey Konoplev Backpatch through 9.3 Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/com

[COMMITTERS] pgsql: pg_upgrade: preserve the timestamp epoch

2014-09-11 Thread Bruce Momjian
pg_upgrade: preserve the timestamp epoch This is useful for replication tools like Slony and Skytools. This is a backpatch of a74a4aa23bb95b590ff01ee564219d2eacea3706. Report by Sergey Konoplev Backpatch through 9.3 Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/com

[COMMITTERS] pgsql: Remove dead InRecovery check.

2014-09-11 Thread Heikki Linnakangas
Remove dead InRecovery check. With the new B-tree incomplete split handling in 9.4, _bt_insert_parent is never called in recovery. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/aae7af3df8054d83b3080f94ca98a5698e8b3de0 Modified Files -- src/backend/acce

[COMMITTERS] pgsql: Remove dead InRecovery check.

2014-09-11 Thread Heikki Linnakangas
Remove dead InRecovery check. With the new B-tree incomplete split handling in 9.4, _bt_insert_parent is never called in recovery. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b8b4124011322b7e376f9e21b3d335a85a28f54c Modified Files -- src/backe

[COMMITTERS] pgsql: improve hash creation warning message

2014-09-11 Thread Bruce Momjian
improve hash creation warning message This improves the wording of commit 84aa8ba128a08e6fdebb2497c7a79ebf18093e12. Report by Kevin Grittner Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/849462a9fafbb30856e47f7862543b1aefa95796 Modified Files -- src/b

[COMMITTERS] pgsql: Add missing volatile qualifier.

2014-09-11 Thread Robert Haas
Add missing volatile qualifier. Yet another silly mistake in 0709b7ee72e4bc71ad07b7120acd117265ab51d0, again found by buildfarm member castoroides. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/68e66923ff629c324e219090860dc9e0e0a6f5d6 Modified Files --

Re: [COMMITTERS] pgsql: Simplify calculation of Poisson distributed delays in pgbench --

2014-09-11 Thread Heikki Linnakangas
On 09/11/2014 03:08 PM, Robert Haas wrote: On Thu, Sep 11, 2014 at 6:14 AM, Heikki Linnakangas wrote: Simplify calculation of Poisson distributed delays in pgbench --rate mode. The previous coding first generated a uniform random value between 0.0 and 1.0, then converted that to an integer bet

[COMMITTERS] pgsql: Fix Windows build.

2014-09-11 Thread Heikki Linnakangas
Fix Windows build. I renamed a variable, but missed an #ifdef WIN32 block. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/06b95334f8d16d975e3a68f2392599249ca99c93 Modified Files -- contrib/pgbench/pgbench.c |2 +- 1 file changed, 1 insertion(+

[COMMITTERS] pgsql: Fix Windows build.

2014-09-11 Thread Heikki Linnakangas
Fix Windows build. I renamed a variable, but missed an #ifdef WIN32 block. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/01a2bfd172b21ce86894bfa00f6896f504607ab4 Modified Files -- contrib/pgbench/pgbench.c |2 +- 1 file changed, 1 insertion(+), 1 de

Re: [COMMITTERS] pgsql: Simplify calculation of Poisson distributed delays in pgbench --

2014-09-11 Thread Robert Haas
On Thu, Sep 11, 2014 at 6:14 AM, Heikki Linnakangas wrote: > Simplify calculation of Poisson distributed delays in pgbench --rate mode. > > The previous coding first generated a uniform random value between 0.0 and > 1.0, then converted that to an integer between 1 and 1, and divided that > ag

[COMMITTERS] pgsql: Silence compiler warning on Windows.

2014-09-11 Thread Heikki Linnakangas
Silence compiler warning on Windows. David Rowley. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0ed41529f6ab92b836336fdd096f924838eea1d7 Modified Files -- src/backend/utils/adt/arrayfuncs.c |3 +++ 1 file changed, 3 insertions(+) -- Sent via pgs

[COMMITTERS] pgsql: Simplify calculation of Poisson distributed delays in pgbench --

2014-09-11 Thread Heikki Linnakangas
Simplify calculation of Poisson distributed delays in pgbench --rate mode. The previous coding first generated a uniform random value between 0.0 and 1.0, then converted that to an integer between 1 and 1, and divided that again by 1. Those conversions are unnecessary; we can use the doubl

[COMMITTERS] pgsql: Simplify calculation of Poisson distributed delays in pgbench --

2014-09-11 Thread Heikki Linnakangas
Simplify calculation of Poisson distributed delays in pgbench --rate mode. The previous coding first generated a uniform random value between 0.0 and 1.0, then converted that to an integer between 1 and 1, and divided that again by 1. Those conversions are unnecessary; we can use the doubl

[COMMITTERS] pgsql: Change the way latency is calculated with pgbench --rate option.

2014-09-11 Thread Heikki Linnakangas
Change the way latency is calculated with pgbench --rate option. The reported latency values now include the "schedule lag" time, that is, the time between the transaction's scheduled start time and the time it actually started. This relates better to a model where requests arrive at a certain rat

[COMMITTERS] pgsql: Change the way latency is calculated with pgbench --rate option.

2014-09-11 Thread Heikki Linnakangas
Change the way latency is calculated with pgbench --rate option. The reported latency values now include the "schedule lag" time, that is, the time between the transaction's scheduled start time and the time it actually started. This relates better to a model where requests arrive at a certain rat

Re: [COMMITTERS] pgsql: Add new psql help topics, accessible to both --help and \?.

2014-09-11 Thread Andres Freund
On 2014-09-11 09:52:20 +0900, Michael Paquier wrote: > > I'd not mind a review, but I'll push this soon. Doesn't seem worth > > reverting the entire psql patch when the fix is as localized as this. We > > might conceivably want to change the behaviour of optional_argument, but > > as there's only o