[COMMITTERS] pgsql: Add unicode_*_linestyle to \? variables

2014-09-22 Thread Stephen Frost
Add unicode_*_linestyle to \? variables In a2dabf0 we added the ability to have single or double unicode linestyle for the border, column, or header. Unfortunately, the \? variables output was not updated for these new psql variables. This corrects that oversight. Patch by Pavel Stehule. Branc

[COMMITTERS] pgsql: Log ALTER SYSTEM statements as DDL

2014-09-22 Thread Stephen Frost
Log ALTER SYSTEM statements as DDL Per discussion in bug #11350, log ALTER SYSTEM commands at the log_statement=ddl level, rather than at the log_statement=all level. Pointed out by Tomonari Katsumata. Back-patch to 9.4 where ALTER SYSTEM was introduced. Branch -- REL9_4_STABLE Details ---

[COMMITTERS] pgsql: Log ALTER SYSTEM statements as DDL

2014-09-22 Thread Stephen Frost
Log ALTER SYSTEM statements as DDL Per discussion in bug #11350, log ALTER SYSTEM commands at the log_statement=ddl level, rather than at the log_statement=all level. Pointed out by Tomonari Katsumata. Back-patch to 9.4 where ALTER SYSTEM was introduced. Branch -- master Details --- ht

[COMMITTERS] pgsql: Process withCheckOption exprs in setrefs.c

2014-09-22 Thread Stephen Frost
Process withCheckOption exprs in setrefs.c While withCheckOption exprs had been handled in many cases by happenstance, they need to be handled during set_plan_references and more specifically down in set_plan_refs for ModifyTable plan nodes. This is to ensure that the opfuncid's are set for operat

[COMMITTERS] pgsql: Process withCheckOption exprs in setrefs.c

2014-09-22 Thread Stephen Frost
Process withCheckOption exprs in setrefs.c While withCheckOption exprs had been handled in many cases by happenstance, they need to be handled during set_plan_references and more specifically down in set_plan_refs for ModifyTable plan nodes. This is to ensure that the opfuncid's are set for operat

[COMMITTERS] pgsql: Remove most volatile qualifiers from xlog.c

2014-09-22 Thread Andres Freund
Remove most volatile qualifiers from xlog.c For the reason outlined in df4077cda2e also remove volatile qualifiers from xlog.c. Some of these uses of volatile have been added after noticing problems back when spinlocks didn't imply compiler barriers. So they are a good test - in fact removing the

[COMMITTERS] pgsql: Remove volatile qualifiers from lwlock.c.

2014-09-22 Thread Robert Haas
Remove volatile qualifiers from lwlock.c. Now that spinlocks (hopefully!) act as compiler barriers, as of commit 0709b7ee72e4bc71ad07b7120acd117265ab51d0, this should be safe. This serves as a demonstration of the new coding style, and may be optimized better on some machines as well. Branch ---

[COMMITTERS] pgsql: Fix compiler warning.

2014-09-22 Thread Robert Haas
Fix compiler warning. It is meaningless to declare a pass-by-value return type const. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e38da8d6b1bd494b72a6f84310d30b55b3f67c3e Modified Files -- src/backend/commands/policy.c |4 ++-- 1 file changed, 2 i

[COMMITTERS] pgsql: Fix mishandling of CreateEventTrigStmt's eventname field.

2014-09-22 Thread Robert Haas
Fix mishandling of CreateEventTrigStmt's eventname field. It's a string, not a scalar. Petr Jelinek Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/763ba1b0f2aa8353e3e3b02bc6bd965deb4575e0 Modified Files -- src/backend/nodes/copyfuncs.c |2 +- src/b

[COMMITTERS] pgsql: Fix mishandling of CreateEventTrigStmt's eventname field.

2014-09-22 Thread Robert Haas
Fix mishandling of CreateEventTrigStmt's eventname field. It's a string, not a scalar. Petr Jelinek Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/e35db342aa6a67181d54b09cb80d088805a5f408 Modified Files -- src/backend/nodes/copyfuncs.c |2 +

[COMMITTERS] pgsql: Fix mishandling of CreateEventTrigStmt's eventname field.

2014-09-22 Thread Robert Haas
Fix mishandling of CreateEventTrigStmt's eventname field. It's a string, not a scalar. Petr Jelinek Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/e3e065d3779d82640e93298c06106c16c1948090 Modified Files -- src/backend/nodes/copyfuncs.c |2 +

[COMMITTERS] pgsql: Remove postgres --help blurb about the removed -A option.

2014-09-22 Thread Andres Freund
Remove postgres --help blurb about the removed -A option. I missed this in 3bdcf6a5a755503. Noticed by Merlin Moncure Discussion: cahyxu0yc7upeevzqrowtnrop9dxteupyjb0og4qunbipmev...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0926ef43c160cc8334d3e

[COMMITTERS] pgsql: Improve code around the recently added rm_identify rmgr callback

2014-09-22 Thread Andres Freund
Improve code around the recently added rm_identify rmgr callback. There are four weaknesses in728f152e07f998d2cb4fe5f24ec8da2c3bda98f2: * append_init() in heapdesc.c was ugly and required that rm_identify return values are only valid till the next call. Instead just add a couple more switch()