[COMMITTERS] Re: pgsql: doc: restrictions on alter database moving default tablespace

2014-10-20 Thread Noah Misch
On Sat, Oct 18, 2014 at 02:23:46PM +, Bruce Momjian wrote: > doc: restrictions on alter database moving default tablespace > > Mention tablespace must be empty and no one connected to the database. The database must not contain any object explicitly assigned to its future default tablespace,

[COMMITTERS] pgsql: Don't duplicate log_checkpoint messages for both of restart and

2014-10-20 Thread Andres Freund
Don't duplicate log_checkpoint messages for both of restart and checkpoints. The duplication originated in cdd46c765, where restartpoints were introduced. In LogCheckpointStart's case the duplication actually lead to the compiler's format string checking not to be effective because the format str

[COMMITTERS] pgsql: Renumber CHECKPOINT_* flags.

2014-10-20 Thread Andres Freund
Renumber CHECKPOINT_* flags. Commit 7dbb6069382 added a new CHECKPOINT_FLUSH_ALL flag. As that commit needed to be backpatched I didn't change the numeric values of the existing flags as that could lead to nastly problems if any external code issued checkpoints. That's not a concern on master, so

[COMMITTERS] pgsql: Flush unlogged table's buffers when copying or moving databases.

2014-10-20 Thread Andres Freund
Flush unlogged table's buffers when copying or moving databases. CREATE DATABASE and ALTER DATABASE .. SET TABLESPACE copy the source database directory on the filesystem level. To ensure the on disk state is consistent they block out users of the affected database and force a checkpoint to flush

[COMMITTERS] pgsql: Flush unlogged table's buffers when copying or moving databases.

2014-10-20 Thread Andres Freund
Flush unlogged table's buffers when copying or moving databases. CREATE DATABASE and ALTER DATABASE .. SET TABLESPACE copy the source database directory on the filesystem level. To ensure the on disk state is consistent they block out users of the affected database and force a checkpoint to flush

[COMMITTERS] pgsql: Flush unlogged table's buffers when copying or moving databases.

2014-10-20 Thread Andres Freund
Flush unlogged table's buffers when copying or moving databases. CREATE DATABASE and ALTER DATABASE .. SET TABLESPACE copy the source database directory on the filesystem level. To ensure the on disk state is consistent they block out users of the affected database and force a checkpoint to flush

[COMMITTERS] pgsql: Flush unlogged table's buffers when copying or moving databases.

2014-10-20 Thread Andres Freund
Flush unlogged table's buffers when copying or moving databases. CREATE DATABASE and ALTER DATABASE .. SET TABLESPACE copy the source database directory on the filesystem level. To ensure the on disk state is consistent they block out users of the affected database and force a checkpoint to flush

[COMMITTERS] pgsql: Flush unlogged table's buffers when copying or moving databases.

2014-10-20 Thread Andres Freund
Flush unlogged table's buffers when copying or moving databases. CREATE DATABASE and ALTER DATABASE .. SET TABLESPACE copy the source database directory on the filesystem level. To ensure the on disk state is consistent they block out users of the affected database and force a checkpoint to flush

[COMMITTERS] pgsql: pg_test_fsync: Update output format

2014-10-20 Thread Peter Eisentraut
pg_test_fsync: Update output format Apparently, computers are now a bit faster than when this was first added, so we need to make room for a digit or two in the ops/sec format. While we're at it, adjust some of the other output for a more consistent line length. Branch -- master Details ---

[COMMITTERS] pgsql: Correct volatility markings of a few json functions.

2014-10-20 Thread Andrew Dunstan
Correct volatility markings of a few json functions. json_agg and json_object_agg and their associated transition functions should have been marked as stable rather than immutable, as they call IO functions indirectly. Changing this probably isn't going to make much difference, as you can't use an

[COMMITTERS] pgsql: Correct volatility markings of a few json functions.

2014-10-20 Thread Andrew Dunstan
Correct volatility markings of a few json functions. json_agg and json_object_agg and their associated transition functions should have been marked as stable rather than immutable, as they call IO functions indirectly. Changing this probably isn't going to make much difference, as you can't use an

[COMMITTERS] pgsql: Fix mishandling of FieldSelect-on-whole-row-Var in nested latera

2014-10-20 Thread Tom Lane
Fix mishandling of FieldSelect-on-whole-row-Var in nested lateral queries. If an inline-able SQL function taking a composite argument is used in a LATERAL subselect, and the composite argument is a lateral reference, the planner could fail with "variable not found in subplan target list", as seen

[COMMITTERS] pgsql: Fix mishandling of FieldSelect-on-whole-row-Var in nested latera

2014-10-20 Thread Tom Lane
Fix mishandling of FieldSelect-on-whole-row-Var in nested lateral queries. If an inline-able SQL function taking a composite argument is used in a LATERAL subselect, and the composite argument is a lateral reference, the planner could fail with "variable not found in subplan target list", as seen

[COMMITTERS] pgsql: Fix mishandling of FieldSelect-on-whole-row-Var in nested latera

2014-10-20 Thread Tom Lane
Fix mishandling of FieldSelect-on-whole-row-Var in nested lateral queries. If an inline-able SQL function taking a composite argument is used in a LATERAL subselect, and the composite argument is a lateral reference, the planner could fail with "variable not found in subplan target list", as seen

[COMMITTERS] pgsql: Fix file-identification comment in contrib/pgcrypto/pgcrypto--1.

2014-10-20 Thread Tom Lane
Fix file-identification comment in contrib/pgcrypto/pgcrypto--1.2.sql. Cosmetic oversight in commit 32984d8fc3dbb90a3fafb69fece0134f1ea790f9. Marko Tiikkaja Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/488a7c9ccff54f947d5a51f00efe873f4bae909a Modified Files

[COMMITTERS] pgsql: Fix typos.

2014-10-20 Thread Robert Haas
Fix typos. David Rowley Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bc279c92f0c213b7bc9a1aef9773aa9a3a9cd0e3 Modified Files -- src/backend/replication/walsender.c|2 +- src/bin/pg_basebackup/receivelog.c |2 +- src/interfaces/ec

[COMMITTERS] pgsql: Fix typos.

2014-10-20 Thread Robert Haas
Fix typos. Etsuro Fujita Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0f565c074311d202f4524d1fd104b28c5a6adaf2 Modified Files -- src/backend/utils/adt/pgstatfuncs.c |2 +- src/backend/utils/adt/tsgistidx.c |4 ++-- src/backend/utils/adt/tsquer