[COMMITTERS] pgsql: Tag refs/tags/REL9_4_0 was created

2014-12-16 Thread pgsql
Tag refs/tags/REL9_4_0 was created. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix off-by-one loop count in MapArrayTypeName, and get rid of st

2014-12-16 Thread Tom Lane
Fix off-by-one loop count in MapArrayTypeName, and get rid of static array. MapArrayTypeName would copy up to NAMEDATALEN-1 bytes of the base type name, which of course is wrong: after prepending '_' there is only room for NAMEDATALEN-2 bytes. Aside from being the wrong result, this case would le

[COMMITTERS] pgsql: Fix off-by-one loop count in MapArrayTypeName, and get rid of st

2014-12-16 Thread Tom Lane
Fix off-by-one loop count in MapArrayTypeName, and get rid of static array. MapArrayTypeName would copy up to NAMEDATALEN-1 bytes of the base type name, which of course is wrong: after prepending '_' there is only room for NAMEDATALEN-2 bytes. Aside from being the wrong result, this case would le

[COMMITTERS] pgsql: Fix off-by-one loop count in MapArrayTypeName, and get rid of st

2014-12-16 Thread Tom Lane
Fix off-by-one loop count in MapArrayTypeName, and get rid of static array. MapArrayTypeName would copy up to NAMEDATALEN-1 bytes of the base type name, which of course is wrong: after prepending '_' there is only room for NAMEDATALEN-2 bytes. Aside from being the wrong result, this case would le

[COMMITTERS] pgsql: Fix off-by-one loop count in MapArrayTypeName, and get rid of st

2014-12-16 Thread Tom Lane
Fix off-by-one loop count in MapArrayTypeName, and get rid of static array. MapArrayTypeName would copy up to NAMEDATALEN-1 bytes of the base type name, which of course is wrong: after prepending '_' there is only room for NAMEDATALEN-2 bytes. Aside from being the wrong result, this case would le

[COMMITTERS] pgsql: Fix off-by-one loop count in MapArrayTypeName, and get rid of st

2014-12-16 Thread Tom Lane
Fix off-by-one loop count in MapArrayTypeName, and get rid of static array. MapArrayTypeName would copy up to NAMEDATALEN-1 bytes of the base type name, which of course is wrong: after prepending '_' there is only room for NAMEDATALEN-2 bytes. Aside from being the wrong result, this case would le

[COMMITTERS] pgsql: Fix off-by-one loop count in MapArrayTypeName, and get rid of st

2014-12-16 Thread Tom Lane
Fix off-by-one loop count in MapArrayTypeName, and get rid of static array. MapArrayTypeName would copy up to NAMEDATALEN-1 bytes of the base type name, which of course is wrong: after prepending '_' there is only room for NAMEDATALEN-2 bytes. Aside from being the wrong result, this case would le

[COMMITTERS] pgsql: Suppress bogus statistics when pgbench failed to complete any tr

2014-12-16 Thread Tom Lane
Suppress bogus statistics when pgbench failed to complete any transactions. Code added in 9.4 would attempt to divide by zero in such cases. Noted while testing fix for missing-pclose problem. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/de8e46f5f5785f4016aabf2aa2

[COMMITTERS] pgsql: Suppress bogus statistics when pgbench failed to complete any tr

2014-12-16 Thread Tom Lane
Suppress bogus statistics when pgbench failed to complete any transactions. Code added in 9.4 would attempt to divide by zero in such cases. Noted while testing fix for missing-pclose problem. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f2a3cdb6dbe4984c7b5

[COMMITTERS] pgsql: Fix file descriptor leak after failure of a \setshell command in

2014-12-16 Thread Tom Lane
Fix file descriptor leak after failure of a \setshell command in pgbench. If the called command fails to return data, runShellCommand forgot to pclose() the pipe before returning. This is fairly harmless in the current code, because pgbench would then abandon further processing of that client thr

[COMMITTERS] pgsql: Fix file descriptor leak after failure of a \setshell command in

2014-12-16 Thread Tom Lane
Fix file descriptor leak after failure of a \setshell command in pgbench. If the called command fails to return data, runShellCommand forgot to pclose() the pipe before returning. This is fairly harmless in the current code, because pgbench would then abandon further processing of that client thr

[COMMITTERS] pgsql: Fix file descriptor leak after failure of a \setshell command in

2014-12-16 Thread Tom Lane
Fix file descriptor leak after failure of a \setshell command in pgbench. If the called command fails to return data, runShellCommand forgot to pclose() the pipe before returning. This is fairly harmless in the current code, because pgbench would then abandon further processing of that client thr

[COMMITTERS] pgsql: Fix file descriptor leak after failure of a \setshell command in

2014-12-16 Thread Tom Lane
Fix file descriptor leak after failure of a \setshell command in pgbench. If the called command fails to return data, runShellCommand forgot to pclose() the pipe before returning. This is fairly harmless in the current code, because pgbench would then abandon further processing of that client thr

[COMMITTERS] pgsql: Fix file descriptor leak after failure of a \setshell command in

2014-12-16 Thread Tom Lane
Fix file descriptor leak after failure of a \setshell command in pgbench. If the called command fails to return data, runShellCommand forgot to pclose() the pipe before returning. This is fairly harmless in the current code, because pgbench would then abandon further processing of that client thr

[COMMITTERS] pgsql: Fix file descriptor leak after failure of a \setshell command in

2014-12-16 Thread Tom Lane
Fix file descriptor leak after failure of a \setshell command in pgbench. If the called command fails to return data, runShellCommand forgot to pclose() the pipe before returning. This is fairly harmless in the current code, because pgbench would then abandon further processing of that client thr

[COMMITTERS] pgsql: Fix some jsonb issues found by Coverity in recent commits.

2014-12-16 Thread Andrew Dunstan
Fix some jsonb issues found by Coverity in recent commits. Mostly these issues concern the non-use of function results. These have been changed to use (void) pushJsonbValue(...) instead of assigning the result to a variable that gets overwritten before it is used. There is a larger issue that we

[COMMITTERS] pgsql: Misc comment typo fixes.

2014-12-16 Thread Heikki Linnakangas
Misc comment typo fixes. Backpatch the applicable parts, just to make backpatching future patches easier. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4d65e16a6ff609701a8780d3cddbae02c6e20926 Modified Files -- src/backend/lib/binaryheap.c|

[COMMITTERS] pgsql: Misc comment typo fixes.

2014-12-16 Thread Heikki Linnakangas
Misc comment typo fixes. Backpatch the applicable parts, just to make backpatching future patches easier. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ce864d3276a29fc39155348e6e5ca282d1e51d2d Modified Files -- src/backend/lib/binaryheap.c

[COMMITTERS] pgsql: Misc comment typo fixes.

2014-12-16 Thread Heikki Linnakangas
Misc comment typo fixes. Backpatch the applicable parts, just to make backpatching future patches easier. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ea78d1381e01d96bb7d6426f25b8033fd11b9c14 Modified Files -- src/backend/lib/binaryheap.c |

[COMMITTERS] pgsql: Fix incorrect comment about XLogRecordBlockHeader.data_length fi

2014-12-16 Thread Heikki Linnakangas
Fix incorrect comment about XLogRecordBlockHeader.data_length field. It does not include the possible full-page image. While at it, reformat the comment slightly to make it more readable. Reported by Rahila Syed Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/da9f6a