[COMMITTERS] pgsql: pg_event_trigger_dropped_objects: Add name/args output columns

2014-12-30 Thread Alvaro Herrera
pg_event_trigger_dropped_objects: Add name/args output columns These columns can be passed to pg_get_object_address() and used to reconstruct the dropped objects identities in a remote server containing similar objects, so that the drop can be replicated. Reviewed by Stephen Frost, Heikki Linnaka

[COMMITTERS] pgsql: Add pg_identify_object_as_address

2014-12-30 Thread Alvaro Herrera
Add pg_identify_object_as_address This function returns object type and objname/objargs arrays, which can be passed to pg_get_object_address. This is especially useful because the textual representation can be copied to a remote server in order to obtain the corresponding OID-based address. In e

Re: [COMMITTERS] pgsql: Use TypeName to represent type names in certain commands

2014-12-30 Thread Heikki Linnakangas
On 12/30/2014 07:21 PM, Alvaro Herrera wrote: Heikki Linnakangas wrote: There is one instance of the old message left in pg_get_object_address. Should change that too for consistency, and to reduce translation work. Hm, I couldn't find it ... care to provide a line number? Never mind, I must

[COMMITTERS] pgsql: Fix object_address expected output

2014-12-30 Thread Alvaro Herrera
Fix object_address expected output Per pink buildfarm Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5b447ad3a98aa6f059ba467eb10a832eb1544985 Modified Files -- src/test/regress/expected/object_address.out | 14 +++--- 1 file changed, 7 insertio

Re: [COMMITTERS] pgsql: Use TypeName to represent type names in certain commands

2014-12-30 Thread Alvaro Herrera
Heikki Linnakangas wrote: > On 12/30/2014 06:58 PM, Alvaro Herrera wrote: > >-errmsg("name list length must be %d", 1))); > >+errmsg("name list length must be exactly %d", 1))); > > Seems silly to pass constant 1 as an argument. (Yeah, it was silly b

Re: [COMMITTERS] pgsql: Use TypeName to represent type names in certain commands

2014-12-30 Thread Heikki Linnakangas
On 12/30/2014 06:58 PM, Alvaro Herrera wrote: -errmsg("name list length must be %d", 1))); +errmsg("name list length must be exactly %d", 1))); Seems silly to pass constant 1 as an argument. (Yeah, it was silly before this commit too.) There is

[COMMITTERS] pgsql: Use TypeName to represent type names in certain commands

2014-12-30 Thread Alvaro Herrera
Use TypeName to represent type names in certain commands In COMMENT, DROP, SECURITY LABEL, and the new pg_get_object_address function, we were representing types as a list of names, same as other objects; but types are special objects that require their own representation to be totally accurate.

[COMMITTERS] pgsql: Revert the GinMaxItemSize calculation so that we fit 3 tuples pe

2014-12-30 Thread Heikki Linnakangas
Revert the GinMaxItemSize calculation so that we fit 3 tuples per page. Commit 36a35c55 changed the divisor from 3 to 6, for no apparent reason. Reducing GinMaxItemSize like that created a dump/reload hazard: loading a 9.3 database to 9.4 might fail with "index row size XXX exceeds maximum 1352 fo

[COMMITTERS] pgsql: Revert the GinMaxItemSize calculation so that we fit 3 tuples pe

2014-12-30 Thread Heikki Linnakangas
Revert the GinMaxItemSize calculation so that we fit 3 tuples per page. Commit 36a35c55 changed the divisor from 3 to 6, for no apparent reason. Reducing GinMaxItemSize like that created a dump/reload hazard: loading a 9.3 database to 9.4 might fail with "index row size XXX exceeds maximum 1352 fo

[COMMITTERS] pgsql: Fix resource leak pointed out by Coverity.

2014-12-30 Thread Tatsuo Ishii
Fix resource leak pointed out by Coverity. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3b5a89c4820fb11c337838c1ad71e8e93f2937d1 Modified Files -- contrib/pgbench/pgbench.c |2 ++ 1 file changed, 2 insertions(+) -- Sent via pgsql-committers maili

[COMMITTERS] pgsql: Fix resource leak pointed out by Coverity.

2014-12-30 Thread Tatsuo Ishii
Fix resource leak pointed out by Coverity. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9b74f35744b68f6f1b3338f2053aa6b8d641f9dd Modified Files -- contrib/pgbench/pgbench.c |9 + 1 file changed, 9 insertions(+) -- Sent via pgsql-co

[COMMITTERS] pgsql: Fix resource leak pointed out by Coverity.

2014-12-30 Thread Tatsuo Ishii
Fix resource leak pointed out by Coverity. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/4db7eaae0f1aca8503f8a638a2775c1a3e0a17bb Modified Files -- contrib/pgbench/pgbench.c |2 ++ 1 file changed, 2 insertions(+) -- Sent via pgsql-committer

[COMMITTERS] pgsql: Fix resource leak pointed out by Coverity.

2014-12-30 Thread Tatsuo Ishii
Fix resource leak pointed out by Coverity. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/4c136b0b6389ce24838cc78eda5d213c15ac93fe Modified Files -- contrib/pgbench/pgbench.c |2 ++ 1 file changed, 2 insertions(+) -- Sent via pgsql-committer

[COMMITTERS] pgsql: Fix resource leak pointed out by Coverity.

2014-12-30 Thread Tatsuo Ishii
Fix resource leak pointed out by Coverity. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/458e8bc653ab7f25de432762c89272540abfeaeb Modified Files -- contrib/pgbench/pgbench.c |2 ++ 1 file changed, 2 insertions(+) -- Sent via pgsql-committer

[COMMITTERS] pgsql: Fix resource leak pointed out by Coverity.

2014-12-30 Thread Tatsuo Ishii
Fix resource leak pointed out by Coverity. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ed0e03283579eb6c79be7c98f050cf6c447a9986 Modified Files -- contrib/pgbench/pgbench.c |2 ++ 1 file changed, 2 insertions(+) -- Sent via pgsql-committer