Re: [COMMITTERS] pgsql: Add stats for min, max, mean, stddev times to pg_stat_statements

2015-03-27 Thread Tom Lane
I wrote: > Andrew Dunstan writes: >> However, it is moaning about the code in the sqrtd() function. I'm >> wondering if we shouldn't just rip that out and use the library sqrt() >> function. It's not called for every statement processed, only each time >> the function is called (for each row).

[COMMITTERS] pgsql: Fix whitespace

2015-03-27 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/16bbb96a2b48d0f525b7fb2f6a001b16719467a9 Modified Files -- src/bin/psql/print.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-comm

Re: [COMMITTERS] pgsql: Add stats for min, max, mean, stddev times to pg_stat_statements

2015-03-27 Thread Tom Lane
Andrew Dunstan writes: > However, it is moaning about the code in the sqrtd() function. I'm > wondering if we shouldn't just rip that out and use the library sqrt() > function. It's not called for every statement processed, only each time > the function is called (for each row). [ looks... ]

Re: [COMMITTERS] pgsql: Add stats for min, max, mean, stddev times to pg_stat_statements

2015-03-27 Thread Petr Jelinek
On 27/03/15 23:26, Andrew Dunstan wrote: On 03/27/2015 05:53 PM, Tom Lane wrote: Andrew Dunstan writes: Add stats for min, max, mean, stddev times to pg_stat_statements. The buildfarm is quite unhappy with this patch. Kinda looks like it was never tested on 32-bit machines. I have comm

Re: [COMMITTERS] pgsql: Add stats for min, max, mean, stddev times to pg_stat_statements

2015-03-27 Thread Andrew Dunstan
On 03/27/2015 05:53 PM, Tom Lane wrote: Andrew Dunstan writes: Add stats for min, max, mean, stddev times to pg_stat_statements. The buildfarm is quite unhappy with this patch. Kinda looks like it was never tested on 32-bit machines. I have committed a fix which

Re: [COMMITTERS] pgsql: Add stats for min, max, mean, stddev times to pg_stat_statements

2015-03-27 Thread Tom Lane
Andrew Dunstan writes: > Add stats for min, max, mean, stddev times to pg_stat_statements. The buildfarm is quite unhappy with this patch. Kinda looks like it was never tested on 32-bit machines. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-commi

[COMMITTERS] pgsql: Add index-only scan support to btree_gist.

2015-03-27 Thread Heikki Linnakangas
Add index-only scan support to btree_gist. inet, cidr, and timetz indexes still cannot support index-only scans, because they don't store the original unmodified value in the index, but a derived approximate value. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e09b

[COMMITTERS] pgsql: Fix portability issues with stddev in pg_stat_statements

2015-03-27 Thread Andrew Dunstan
Fix portability issues with stddev in pg_stat_statements Stddev is calculated on the fly, and the code in commit 717f70953264 was using Float8GetDatumFast() inappropriately to convert the result to a Datum. Mea culpa. It now uses Float8GetDatum(). Branch -- master Details --- http://git.

[COMMITTERS] pgsql: Add stats for min, max, mean, stddev times to pg_stat_statements

2015-03-27 Thread Andrew Dunstan
Add stats for min, max, mean, stddev times to pg_stat_statements. The new fields are min_time, max_time, mean_time and stddev_time. Based on an original patch from Mitsumasa KONDO, modified by me. Reviewed by Petr Jelínek. Branch -- master Details --- http://git.postgresql.org/pg/commi