[COMMITTERS] pgsql: Fix spelling of author's name

2015-04-07 Thread Simon Riggs
Fix spelling of author's name Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1cdf4d0b6ac41e200d904d3fe293e43e07fd3e3c Modified Files -- doc/src/sgml/release-9.4.sgml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers

[COMMITTERS] pgsql: Fix spelling of author's name

2015-04-07 Thread Simon Riggs
Fix spelling of author's name Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/8e003bc6afd2847a8458841e8ca35b94f4a59a66 Modified Files -- doc/src/sgml/release-9.4.sgml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-comm

[COMMITTERS] pgsql: Fix process startup in pg_rewind.

2015-04-07 Thread Heikki Linnakangas
Fix process startup in pg_rewind. Don't allow pg_rewind to run as root on Unix platforms, as any new or replaced files in the data directory would become owned by root. On Windows, it can run under a user that has Administrator rights, but a restricted token needs to be used. This is the same we d

[COMMITTERS] pgsql: Remove variable shadowing

2015-04-07 Thread Alvaro Herrera
Remove variable shadowing Commit a2e35b53 should have removed the variable declaration in the inner block, but didn't. As a result, the returned address might end up not being what was intended. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4e17e32f53c2de4a862ee5e

[COMMITTERS] pgsql: Fix reporting of missing or invalid command line arguments in pg

2015-04-07 Thread Heikki Linnakangas
Fix reporting of missing or invalid command line arguments in pg_rewind. pg_fatal never returns, so a multi-line message cannot be printed by calling it twice. Michael Paquier and Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ee075fcb130f834bd5913940b9

[COMMITTERS] pgsql: Fix assorted inconsistent function declarations.

2015-04-07 Thread Tom Lane
Fix assorted inconsistent function declarations. While gcc doesn't complain if you declare a function "static" and then define it not-static, other compilers do; and in any case the code is highly misleading this way. Add the missing "static" keywords to a couple of recent patches. Per buildfarm

[COMMITTERS] pgsql: Fix assorted inconsistent function declarations.

2015-04-07 Thread Tom Lane
Fix assorted inconsistent function declarations. While gcc doesn't complain if you declare a function "static" and then define it not-static, other compilers do; and in any case the code is highly misleading this way. Add the missing "static" keywords to a couple of recent patches. Per buildfarm

[COMMITTERS] pgsql: Fix assorted inconsistent function declarations.

2015-04-07 Thread Tom Lane
Fix assorted inconsistent function declarations. While gcc doesn't complain if you declare a function "static" and then define it not-static, other compilers do; and in any case the code is highly misleading this way. Add the missing "static" keywords to a couple of recent patches. Per buildfarm

[COMMITTERS] pgsql: Fix assorted inconsistent function declarations.

2015-04-07 Thread Tom Lane
Fix assorted inconsistent function declarations. While gcc doesn't complain if you declare a function "static" and then define it not-static, other compilers do; and in any case the code is highly misleading this way. Add the missing "static" keywords to a couple of recent patches. Per buildfarm

[COMMITTERS] pgsql: Fix assorted inconsistent function declarations.

2015-04-07 Thread Tom Lane
Fix assorted inconsistent function declarations. While gcc doesn't complain if you declare a function "static" and then define it not-static, other compilers do; and in any case the code is highly misleading this way. Add the missing "static" keywords to a couple of recent patches. Per buildfarm

[COMMITTERS] pgsql: Fix assorted inconsistent function declarations.

2015-04-07 Thread Tom Lane
Fix assorted inconsistent function declarations. While gcc doesn't complain if you declare a function "static" and then define it not-static, other compilers do; and in any case the code is highly misleading this way. Add the missing "static" keywords to a couple of recent patches. Per buildfarm

[COMMITTERS] pgsql: Mark the second argument of pg_log as the translatable string in

2015-04-07 Thread Fujii Masao
Mark the second argument of pg_log as the translatable string in nls.mk. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b216ad7bf1a9308c97d2032d4793010e8c8aa7ec Modified Files -- src/bin/pg_rewind/nls.mk |2 +- 1 file changed, 1 insertion(+), 1 deleti

[COMMITTERS] pgsql: Make trace_sort control abbreviation debug output for the text o

2015-04-07 Thread Robert Haas
Make trace_sort control abbreviation debug output for the text opclass. This is consistent with what the new numeric suppor for abbreviated keys now does, and seems much more convenient than having a separate compiler define to control this debug output. Peter Geoghegan Branch -- master Det

Re: [COMMITTERS] pgsql: Mark the second argument of pg_log as the translatable string in

2015-04-07 Thread Michael Paquier
On Wed, Apr 8, 2015 at 11:06 AM, Fujii Masao wrote: > Mark the second argument of pg_log as the translatable string in nls.mk. nls.mk is still missing file_ops.c in GETTEXT_FILES as it contains some calls to pg_fatal. -- Michael -- Sent via pgsql-committers mailing list (pgsql-committers@post

[COMMITTERS] pgsql: Add file_ops.c to GETTEXT_FILES in nls.mk.

2015-04-07 Thread Fujii Masao
Add file_ops.c to GETTEXT_FILES in nls.mk. Since file_ops.c contains translatable strings, it should have been listed in GETTEXT_FILES. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/29407f97746ba2543b1845afe8ae22af09d43e45 Modified Files -- src/bin/pg_

Re: [COMMITTERS] pgsql: Mark the second argument of pg_log as the translatable string in

2015-04-07 Thread Fujii Masao
On Wed, Apr 8, 2015 at 1:35 PM, Michael Paquier wrote: > On Wed, Apr 8, 2015 at 11:06 AM, Fujii Masao wrote: >> Mark the second argument of pg_log as the translatable string in nls.mk. > > nls.mk is still missing file_ops.c in GETTEXT_FILES as it contains > some calls to pg_fatal. Oh, sorry. I w