Re: [COMMITTERS] pgsql: Add transforms feature

2015-04-27 Thread Peter Eisentraut
On 4/27/15 2:23 AM, Michael Paquier wrote: > On Mon, Apr 27, 2015 at 1:36 AM, Tom Lane wrote: >> Peter Eisentraut writes: >>> Add transforms feature >> >> I don't know why this patch is fooling around with compile/link flags, >> but it's broken at least prairiedog and some of the Windows critters

[COMMITTERS] pgsql: Fix vcbuild failures and chkpass dependency caused by 854adb8

2015-04-27 Thread Andrew Dunstan
Fix vcbuild failures and chkpass dependency caused by 854adb8 Switching the Windows build scripts to use forward slashes instead of backslashes has caused a couple of issues in VC builds: - The file tree list was not correctly generated, build script generating vcproj file missing tree dependenc

[COMMITTERS] pgsql: Improve qual pushdown for RLS and SB views

2015-04-27 Thread Stephen Frost
Improve qual pushdown for RLS and SB views The original security barrier view implementation, on which RLS is built, prevented all non-leakproof functions from being pushed down to below the view, even when the function was not receiving any data from the view. This optimization improves on that

Re: [COMMITTERS] pgsql: Add transforms feature

2015-04-27 Thread Alvaro Herrera
Peter Eisentraut wrote: > Add transforms feature > > This provides a mechanism for specifying conversions between SQL data > types and procedural languages. As examples, there are transforms > for hstore and ltree for PL/Perl and PL/Python. BF member olinguito is also failing the contrib test, b

[COMMITTERS] pgsql: Use a fd opened for read/write when syncing slots during startup

2015-04-27 Thread Andres Freund
Use a fd opened for read/write when syncing slots during startup. Some operating systems, including the reporter's windows, return EBADFD or similar when fsync() is invoked on a O_RDONLY file descriptor. Unfortunately RestoreSlotFromDisk() does exactly that; which causes failures after restarts in

[COMMITTERS] pgsql: Use a fd opened for read/write when syncing slots during startup

2015-04-27 Thread Andres Freund
Use a fd opened for read/write when syncing slots during startup. Some operating systems, including the reporter's windows, return EBADFD or similar when fsync() is invoked on a O_RDONLY file descriptor. Unfortunately RestoreSlotFromDisk() does exactly that; which causes failures after restarts in

Re: [COMMITTERS] pgsql: Add transforms feature

2015-04-27 Thread Andrew Dunstan
On 04/27/2015 08:21 AM, Peter Eisentraut wrote: On 4/27/15 2:23 AM, Michael Paquier wrote: On Mon, Apr 27, 2015 at 1:36 AM, Tom Lane wrote: Peter Eisentraut writes: Add transforms feature I don't know why this patch is fooling around with compile/link flags, but it's broken at least prairi

Re: [COMMITTERS] pgsql: Add transforms feature

2015-04-27 Thread Andrew Dunstan
On 04/27/2015 07:54 PM, Andrew Dunstan wrote: On 04/27/2015 08:21 AM, Peter Eisentraut wrote: On 4/27/15 2:23 AM, Michael Paquier wrote: On Mon, Apr 27, 2015 at 1:36 AM, Tom Lane wrote: Peter Eisentraut writes: Add transforms feature I don't know why this patch is fooling around with com

Re: [COMMITTERS] pgsql: Add transforms feature

2015-04-27 Thread Michael Paquier
On Tue, Apr 28, 2015 at 9:55 AM, Andrew Dunstan wrote: > w.r.t MSVC builds, it looks like we need entries in $contrib_extraincludes > in src/tools/msvc/Mkvcbuild.pm at the very least. If our goal is to put back to green the Windows nodes as quick as possible, we could bypass their build this way ,

Re: [COMMITTERS] pgsql: Add transforms feature

2015-04-27 Thread Tom Lane
Alvaro Herrera writes: > Peter Eisentraut wrote: >> Add transforms feature > BF member olinguito is also failing the contrib test, because plpython > is not compiled in that platform. Yeah. Even more specifically, olinguito does have --with-python in its configure flags, but then the plpython M