[COMMITTERS] pgsql: Recommend include_realm=1 in docs

2015-05-08 Thread Stephen Frost
Recommend include_realm=1 in docs As discussed, the default setting of include_realm=0 can be dangerous in multi-realm environments because it is then impossible to differentiate users with the same username but who are from two different realms. Recommend include_realm=1 and note that the defaul

[COMMITTERS] pgsql: Recommend include_realm=1 in docs

2015-05-08 Thread Stephen Frost
Recommend include_realm=1 in docs As discussed, the default setting of include_realm=0 can be dangerous in multi-realm environments because it is then impossible to differentiate users with the same username but who are from two different realms. Recommend include_realm=1 and note that the defaul

[COMMITTERS] pgsql: Change default for include_realm to 1

2015-05-08 Thread Stephen Frost
Change default for include_realm to 1 The default behavior for GSS and SSPI authentication methods has long been to strip the realm off of the principal, however, this is not a secure approach in multi-realm environments and the use-case for the parameter at all has been superseded by the regex-ba

[COMMITTERS] pgsql: Recommend include_realm=1 in docs

2015-05-08 Thread Stephen Frost
Recommend include_realm=1 in docs As discussed, the default setting of include_realm=0 can be dangerous in multi-realm environments because it is then impossible to differentiate users with the same username but who are from two different realms. Recommend include_realm=1 and note that the defaul

[COMMITTERS] pgsql: Recommend include_realm=1 in docs

2015-05-08 Thread Stephen Frost
Recommend include_realm=1 in docs As discussed, the default setting of include_realm=0 can be dangerous in multi-realm environments because it is then impossible to differentiate users with the same username but who are from two different realms. Recommend include_realm=1 and note that the defaul

[COMMITTERS] pgsql: Recommend include_realm=1 in docs

2015-05-08 Thread Stephen Frost
Recommend include_realm=1 in docs As discussed, the default setting of include_realm=0 can be dangerous in multi-realm environments because it is then impossible to differentiate users with the same username but who are from two different realms. Recommend include_realm=1 and note that the defaul

[COMMITTERS] pgsql: Modify pg_stat_get_activity to build a tuplestore

2015-05-08 Thread Stephen Frost
Modify pg_stat_get_activity to build a tuplestore This updates pg_stat_get_activity() to build a tuplestore for its results instead of using the old-style multiple-call method. This simplifies the function, though that wasn't the primary motivation for the change, which is that we may turn it int

[COMMITTERS] pgsql: Bump catversion for pg_file_settings

2015-05-08 Thread Stephen Frost
Bump catversion for pg_file_settings Pointed out by Andres (thanks!) Apologies for not including it in the initial patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4b342fb591ebb556cab18fc999c8710e9733e5bb Modified Files -- src/include/catalog/catv

Re: [COMMITTERS] pgsql: Add pg_file_settings view and function

2015-05-08 Thread Stephen Frost
* Andres Freund ([email protected]) wrote: > On 2015-05-08 23:09:42 +, Stephen Frost wrote: > > Add pg_file_settings view and function > > Modified Files > > -- > > doc/src/sgml/catalogs.sgml | 78 ++ > > src/backend/catalog/system_views.sql |6 ++

Re: [COMMITTERS] pgsql: Add pg_file_settings view and function

2015-05-08 Thread Andres Freund
On 2015-05-08 23:09:42 +, Stephen Frost wrote: > Add pg_file_settings view and function > Modified Files > -- > doc/src/sgml/catalogs.sgml | 78 ++ > src/backend/catalog/system_views.sql |6 ++ > src/backend/utils/misc/guc-file.l| 50 +

[COMMITTERS] pgsql: Add pg_file_settings view and function

2015-05-08 Thread Stephen Frost
Add pg_file_settings view and function The function and view added here provide a way to look at all settings in postgresql.conf, any #include'd files, and postgresql.auto.conf (which is what backs the ALTER SYSTEM command). The information returned includes the configuration file name, line numb

[COMMITTERS] pgsql: Fix two problems in infer_arbiter_indexes().

2015-05-08 Thread Andres Freund
Fix two problems in infer_arbiter_indexes(). The first is a pretty simple bug where a relcache entry is used after the relation is closed. In this particular situation it does not appear to have bad consequences unless compiled with RELCACHE_FORCE_RELEASE. The second is that infer_arbiter_indexes

[COMMITTERS] pgsql: Add macros to check if a filename is a WAL segment or other such

2015-05-08 Thread Heikki Linnakangas
Add macros to check if a filename is a WAL segment or other such file. We had many instances of the strlen + strspn combination to check for that. This makes the code a bit easier to read. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/179cdd098196338880bdbb39c39a78

[COMMITTERS] pgsql: At promotion, archive last segment from old timeline with .parti

2015-05-08 Thread Heikki Linnakangas
At promotion, archive last segment from old timeline with .partial suffix. Previously, we would archive the possible-incomplete WAL segment with its normal filename, but that causes trouble if the server owning that timeline is still running, and tries to archive the same segment later. It's not n

[COMMITTERS] pgsql: Fix whitespace

2015-05-08 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/16c73e773bc5f2eee6a71c5ec311b8691bf9e832 Modified Files -- src/backend/access/transam/multixact.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailin

Re: [COMMITTERS] pgsql: Teach autovacuum about multixact member wraparound.

2015-05-08 Thread Robert Haas
On Fri, May 8, 2015 at 1:23 PM, Kevin Grittner wrote: > Robert Haas wrote: > >> This patch leaves unsolved the problem of ensuring that emergency >> autovacuums are triggered even when autovacuum=off. We'll need >> to fix that via a separate patch. > > I think we also need something like your pr

[COMMITTERS] pgsql: Minor ON CONFLICT related comments and doc fixes.

2015-05-08 Thread Andres Freund
Minor ON CONFLICT related comments and doc fixes. Geoff Winkless, Stephen Frost, Peter Geoghegan and me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e8898e9169c851c2b8c98f981c1c4755a5758f8e Modified Files -- doc/src/sgml/ref/insert.sgml |4 ++

Re: [COMMITTERS] pgsql: Teach autovacuum about multixact member wraparound.

2015-05-08 Thread Kevin Grittner
Robert Haas wrote: > This patch leaves unsolved the problem of ensuring that emergency > autovacuums are triggered even when autovacuum=off. We'll need > to fix that via a separate patch. I think we also need something like your previously-posted multixact-truncate-race.patch as a follow-on.

[COMMITTERS] pgsql: Remove reference to src/tools/backend/index.html

2015-05-08 Thread Stephen Frost
Remove reference to src/tools/backend/index.html src/tools/backend was removed back in 63f1ccd, but backend/storage/lmgr/README didn't get the memo. Author: Amit Langote Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/195fbd40123b85ba8a44ca273b17d699e30ec6a8 Modifi