[COMMITTERS] pgsql: Add pgstattuple_approx() to the pgstattuple extension.

2015-05-12 Thread Andres Freund
Add pgstattuple_approx() to the pgstattuple extension. The new function allows to estimate bloat and other table level statics in a faster, but approximate, way. It does so by using information from the free space map for pages marked as all visible in the visibility map. The rest of the table is

[COMMITTERS] pgsql: PL/Python: Remove procedure cache invalidation

2015-05-12 Thread Peter Eisentraut
PL/Python: Remove procedure cache invalidation This was added to react to changes in the pg_transform catalog, but building with CLOBBER_CACHE_ALWAYS showed that PL/Python was not prepared for having its procedure cache cleared. Since this is a marginal use case, and we don't do this for other ca

[COMMITTERS] pgsql: Fix ON CONFLICT bugs that manifest when used in rules.

2015-05-12 Thread Andres Freund
Fix ON CONFLICT bugs that manifest when used in rules. Specifically the tlist and rti of the pseudo "excluded" relation weren't properly treated by expression_tree_walker, which lead to errors when excluded was referenced inside a rule because the varnos where not properly adjusted. Similar omiss

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-12 Thread Michael Paquier
On Wed, May 13, 2015 at 12:31 AM, Alvaro Herrera wrote: > Michael Paquier wrote: > >> Mind share more details about that? How would you detect that a given >> test in serial_schedule needs to be considered by test_ddl_deparse >> automatically? WIth a new type of keyword in a schedule file? This >>

[COMMITTERS] pgsql: Fix some errors from jsonb functions patch.

2015-05-12 Thread Andrew Dunstan
Fix some errors from jsonb functions patch. The catalog version should have been bumped, and the alternative regression result file was not up to date with the name of jsonb_pretty. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5c7df74204e2fb9440b576518d40fcf3ac65c

Re: [COMMITTERS] pgsql: Additional functions and operators for jsonb

2015-05-12 Thread Andrew Dunstan
On 05/12/2015 04:11 PM, Pavel Stehule wrote: Hi I did some tests, and I am not sure if this is not bug: postgres=# select '{"x":20}'::jsonb - 'x'::text; ERROR: unknown type of jsonb container --->>> it should be empty jsonb, not error Time: 0.971 ms postgres=# select '{"x":20, "y":30}'::jso

Re: [COMMITTERS] pgsql: Additional functions and operators for jsonb

2015-05-12 Thread Andrew Dunstan
On 05/12/2015 04:37 PM, Tom Lane wrote: Andrew Dunstan writes: Additional functions and operators for jsonb Buildfarm doesn't like this at all. Also, you should have bumped catversion, no? Yes, I should. OK. I'll look at what's wrong. cheers andrew -- Sent

Re: [COMMITTERS] pgsql: Additional functions and operators for jsonb

2015-05-12 Thread Tom Lane
Andrew Dunstan writes: > Additional functions and operators for jsonb Buildfarm doesn't like this at all. Also, you should have bumped catversion, no? regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your

Re: [COMMITTERS] pgsql: Additional functions and operators for jsonb

2015-05-12 Thread Pavel Stehule
Hi I did some tests, and I am not sure if this is not bug: postgres=# select '{"x":20}'::jsonb - 'x'::text; ERROR: unknown type of jsonb container --->>> it should be empty jsonb, not error Time: 0.971 ms postgres=# select '{"x":20, "y":30}'::jsonb - 'x'::text; ┌───┐ │ ?column? │ ╞═

[COMMITTERS] pgsql: Additional functions and operators for jsonb

2015-05-12 Thread Andrew Dunstan
Additional functions and operators for jsonb jsonb_pretty(jsonb) produces nicely indented json output. jsonb || jsonb concatenates two jsonb values. jsonb - text removes a key and its associated value from the json jsonb - int removes the designated array element jsonb - text[] removes a key and a

[COMMITTERS] pgsql: Add support for doing late row locking in FDWs.

2015-05-12 Thread Tom Lane
Add support for doing late row locking in FDWs. Previously, FDWs could only do "early row locking", that is lock a row as soon as it's fetched, even though local restriction/join conditions might discard the row later. This patch adds callbacks that allow FDWs to do late locking in the same way t

Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

2015-05-12 Thread Amit Kapila
On Tue, May 12, 2015 at 9:02 PM, Andrew Dunstan wrote: > > On 05/12/2015 10:33 AM, Heikki Linnakangas wrote: > >> On 05/12/2015 04:42 PM, Andrew Dunstan wrote: >> >>> + >>> + /* >>> +* Remove the existing symlink if any and Create the >>> symlink >>> +

[COMMITTERS] pgsql: pgbench: Don't fail during startup

2015-05-12 Thread Stephen Frost
pgbench: Don't fail during startup In pgbench, report, but ignore, any errors returned when attempting to vacuum/truncate the default tables during startup. If the tables are needed, we'll error out soon enough anyway. Per discussion with Tatsuo, David Rowley, Jim Nasby, Robert, Andres, Fujii, F

[COMMITTERS] pgsql: pg_basebackup -F t now succeeds with a long symlink target

2015-05-12 Thread Andrew Dunstan
pg_basebackup -F t now succeeds with a long symlink target Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/97e0aa697983cf7f7f79e69f2dc248fdefb7dbf6 Modified Files -- src/bin/pg_basebackup/t/010_pg_basebackup.pl |4 ++-- 1 file changed, 2 insertions(+),

Re: [COMMITTERS] pgsql: Improve speed of make check-world

2015-05-12 Thread Bruce Momjian
On Tue, May 12, 2015 at 12:24:17PM -0400, Bruce Momjian wrote: > > > Running 'make check' will output '1 2'. > > > > > > Now, of course many check's need temp-install, but the SGML build does > > > not. The attached diff uses a symbol defined in doc/src/sgml/Makefile > > > (GENERATED_SGML) to sup

[COMMITTERS] pgsql: doc build: use unique Makefile variable to control temp install

2015-05-12 Thread Bruce Momjian
doc build: use unique Makefile variable to control temp install Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ea12b3ca8cf4d5d4a35f6ca49f8e5128f716fa90 Modified Files -- doc/src/sgml/Makefile |2 ++ src/Makefile.global.in |2 +- 2 files changed,

Re: [COMMITTERS] pgsql: Improve speed of make check-world

2015-05-12 Thread Bruce Momjian
On Tue, May 12, 2015 at 11:01:49AM -0400, Bruce Momjian wrote: > > While you can't easily add rule action to an existing target, you can > > easily add dependencies by just mentioning the target multiple times, > > e.g. > > > > check: dep1 > > > > check: dep2 > > > >

Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

2015-05-12 Thread Andrew Dunstan
On 05/12/2015 10:33 AM, Heikki Linnakangas wrote: On 05/12/2015 04:42 PM, Andrew Dunstan wrote: + + /* +* Remove the existing symlink if any and Create the symlink +* under PGDATA. We need to use rmtree instead of rmdir as +* the

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-12 Thread Alvaro Herrera
Michael Paquier wrote: > Mind share more details about that? How would you detect that a given > test in serial_schedule needs to be considered by test_ddl_deparse > automatically? WIth a new type of keyword in a schedule file? This > looks like a different feature to me that's going to need more

[COMMITTERS] pgsql: "Fix" test_ddl_deparse regress test schedule

2015-05-12 Thread Alvaro Herrera
"Fix" test_ddl_deparse regress test schedule MSVC is not smart enough to figure it out, so dumb down the Makefile and remove the schedule file. Also add a .gitignore file. Author: Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/007c932e5aaf6d68087f1

Re: [COMMITTERS] pgsql: Improve speed of make check-world

2015-05-12 Thread Bruce Momjian
On Sat, May 9, 2015 at 02:02:15PM -0400, Bruce Momjian wrote: > Yes, I found this odd too. It is caused by this commit: > > commit dcae5faccab64776376d354decda0017c648bb53 > Author: Peter Eisentraut > Date: Thu Apr 23 08:59:52 2015 -0400 > > Improve speed of

[COMMITTERS] pgsql: doc: prevent SGML 'make check' from building temp install

2015-05-12 Thread Bruce Momjian
doc: prevent SGML 'make check' from building temp install Report by Alvaro Herrera Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e8c19263e45ce1f3133d2d403de9d380cdcd1fce Modified Files -- src/Makefile.global.in |2 ++ 1 file changed, 2 insertions(+

Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

2015-05-12 Thread Heikki Linnakangas
On 05/12/2015 04:42 PM, Andrew Dunstan wrote: + + /* +* Remove the existing symlink if any and Create the symlink +* under PGDATA. We need to use rmtree instead of rmdir as +* the link location might contain directories or files +

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-12 Thread Andrew Dunstan
On 05/12/2015 10:03 AM, Alvaro Herrera wrote: In any case, it is not good to keep the buildfarm machines broken for too long, and personally I would rather avoid adding one more hack in the MSVC build scripts. The MSVC build scripts *are* hacks themselves. Anyway, I'll look into it. Nobody

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-12 Thread Alvaro Herrera
Michael Paquier wrote: > On Tue, May 12, 2015 at 1:05 PM, Alvaro Herrera > wrote: > > Sure. I want to avoid doing that, though: we may want to generate a > > schedule based on src/test/regress/serial_schedule, so that newly added > > tests to the regular suite are automatically considered by thi

[COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

2015-05-12 Thread Andrew Dunstan
Map basebackup tablespaces using a tablespace_map file Windows can't reliably restore symbolic links from a tar format, so instead during backup start we create a tablespace_map file, which is used by the restoring postgres to create the correct links in pg_tblspc. The backup protocol also now has

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-12 Thread Andrew Dunstan
On 05/12/2015 12:05 AM, Alvaro Herrera wrote: Michael Paquier wrote: On Tue, May 12, 2015 at 11:43 AM, Michael Paquier wrote: On Tue, May 12, 2015 at 11:37 AM, Alvaro Herrera wrote: Michael Paquier wrote: On Tue, May 12, 2015 at 7:16 AM, Alvaro Herrera wrote: Not sure what's the real fix