Re: [COMMITTERS] pgsql: Optionally don't error out due to preexisting slots in commandli

2015-08-11 Thread Michael Paquier
On Mon, Jul 13, 2015 at 5:17 AM, Andres Freund wrote: > Optionally don't error out due to preexisting slots in commandline utilities. > > pg_receivexlog and pg_recvlogical error out when --create-slot is > specified and a slot with the same name already exists. In some cases, > especially with pg_

[COMMITTERS] pgsql: Fix some possible low-memory failures in regexp compilation.

2015-08-11 Thread Tom Lane
Fix some possible low-memory failures in regexp compilation. newnfa() failed to set the regex error state when malloc() fails. Several places in regcomp.c failed to check for an error after calling subre(). Each of these mistakes could lead to null-pointer-dereference crashes in memory-starved ba

[COMMITTERS] pgsql: Fix some possible low-memory failures in regexp compilation.

2015-08-11 Thread Tom Lane
Fix some possible low-memory failures in regexp compilation. newnfa() failed to set the regex error state when malloc() fails. Several places in regcomp.c failed to check for an error after calling subre(). Each of these mistakes could lead to null-pointer-dereference crashes in memory-starved ba

[COMMITTERS] pgsql: Fix some possible low-memory failures in regexp compilation.

2015-08-11 Thread Tom Lane
Fix some possible low-memory failures in regexp compilation. newnfa() failed to set the regex error state when malloc() fails. Several places in regcomp.c failed to check for an error after calling subre(). Each of these mistakes could lead to null-pointer-dereference crashes in memory-starved ba

[COMMITTERS] pgsql: Fix some possible low-memory failures in regexp compilation.

2015-08-11 Thread Tom Lane
Fix some possible low-memory failures in regexp compilation. newnfa() failed to set the regex error state when malloc() fails. Several places in regcomp.c failed to check for an error after calling subre(). Each of these mistakes could lead to null-pointer-dereference crashes in memory-starved ba

[COMMITTERS] pgsql: Fix some possible low-memory failures in regexp compilation.

2015-08-11 Thread Tom Lane
Fix some possible low-memory failures in regexp compilation. newnfa() failed to set the regex error state when malloc() fails. Several places in regcomp.c failed to check for an error after calling subre(). Each of these mistakes could lead to null-pointer-dereference crashes in memory-starved ba

[COMMITTERS] pgsql: Fix some possible low-memory failures in regexp compilation.

2015-08-11 Thread Tom Lane
Fix some possible low-memory failures in regexp compilation. newnfa() failed to set the regex error state when malloc() fails. Several places in regcomp.c failed to check for an error after calling subre(). Each of these mistakes could lead to null-pointer-dereference crashes in memory-starved ba

[COMMITTERS] pgsql: Fix some possible low-memory failures in regexp compilation.

2015-08-11 Thread Tom Lane
Fix some possible low-memory failures in regexp compilation. newnfa() failed to set the regex error state when malloc() fails. Several places in regcomp.c failed to check for an error after calling subre(). Each of these mistakes could lead to null-pointer-dereference crashes in memory-starved ba

[COMMITTERS] pgsql: Postpone extParam/allParam calculations until the very end of pl

2015-08-11 Thread Tom Lane
Postpone extParam/allParam calculations until the very end of planning. Until now we computed these Param ID sets at the end of subquery_planner, but that approach depends on subquery_planner returning a concrete Plan tree. We would like to switch over to returning one or more Paths for a subquer

[COMMITTERS] pgsql: Don't include rel.h when relcache.h is sufficient

2015-08-11 Thread Alvaro Herrera
Don't include rel.h when relcache.h is sufficient Trivial change to reduce exposure of rel.h. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4901b2f49536f439f79d067a9b30a7a837d6c72b Modified Files -- src/backend/replication/logical/reorderbuffer.c |

Re: [COMMITTERS] pgsql: Fix broken markup, and copy-edit a bit.

2015-08-11 Thread Andres Freund
On 2015-08-11 14:46:56 +, Tom Lane wrote: > Fix broken markup, and copy-edit a bit. > > Fix docs build failure introduced by commit 6fcd88511f8e69e3. > I failed to resist the temptation to rearrange the description of > pg_create_physical_replication_slot(), too. Thanks! Andres -- Sent vi

[COMMITTERS] pgsql: Fix broken markup, and copy-edit a bit.

2015-08-11 Thread Tom Lane
Fix broken markup, and copy-edit a bit. Fix docs build failure introduced by commit 6fcd88511f8e69e3. I failed to resist the temptation to rearrange the description of pg_create_physical_replication_slot(), too. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/750fc78

[COMMITTERS] pgsql: More fixes to allow pg_rewind tests to run on Msys.

2015-08-11 Thread Andrew Dunstan
More fixes to allow pg_rewind tests to run on Msys. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/15c3a1b45b480f6478555e9ddbc6093bd031d12c Modified Files -- src/bin/pg_rewind/RewindTest.pm|3 +++ src/bin/pg_rewind/t/004_pg_xlog_symlink.pl

[COMMITTERS] pgsql: Minor cleanups in slot related code.

2015-08-11 Thread Andres Freund
Minor cleanups in slot related code. Fix a bunch of typos, and remove two superflous includes. Author: Gurjeet Singh Discussion: CABwTF4Wh_dBCzTU=49pFXR6coR4NW1ynb+vBqT+Po=7fuq5...@mail.gmail.com Backpatch: 9.4 Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/

[COMMITTERS] pgsql: Minor cleanups in slot related code.

2015-08-11 Thread Andres Freund
Minor cleanups in slot related code. Fix a bunch of typos, and remove two superflous includes. Author: Gurjeet Singh Discussion: CABwTF4Wh_dBCzTU=49pFXR6coR4NW1ynb+vBqT+Po=7fuq5...@mail.gmail.com Backpatch: 9.4 Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/

[COMMITTERS] pgsql: Minor cleanups in slot related code.

2015-08-11 Thread Andres Freund
Minor cleanups in slot related code. Fix a bunch of typos, and remove two superflous includes. Author: Gurjeet Singh Discussion: CABwTF4Wh_dBCzTU=49pFXR6coR4NW1ynb+vBqT+Po=7fuq5...@mail.gmail.com Backpatch: 9.4 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3b425b7

[COMMITTERS] pgsql: Allow pg_create_physical_replication_slot() to reserve WAL.

2015-08-11 Thread Andres Freund
Allow pg_create_physical_replication_slot() to reserve WAL. When creating a physical slot it's often useful to immediately reserve the current WAL position instead of only doing after the first feedback message arrives. That e.g. allows slots to guarantee that all the WAL for a base backup will be

[COMMITTERS] pgsql: Introduce macros determining if a replication slot is physical o

2015-08-11 Thread Andres Freund
Introduce macros determining if a replication slot is physical or logical. These make the code a bit easier to read, and make it easier to add a more explicit notion of a slot's type at some point in the future. Author: Gurjeet Singh Discussion: CABwTF4Wh_dBCzTU=49pFXR6coR4NW1ynb+vBqT+Po=7fuq5...