[COMMITTERS] pgsql: Make extract() do something more reasonable with infinite dateti

2016-01-21 Thread Tom Lane
Make extract() do something more reasonable with infinite datetimes. Historically, extract() just returned zero for any case involving an infinite timestamp[tz] input; even cases in which the unit name was invalid. This is not very sensible. Instead, return infinity or -infinity as appropriate w

Re: [COMMITTERS] pgsql: Improve index AMs' opclass validation procedures.

2016-01-21 Thread Tom Lane
David Rowley writes: > I'm getting 3 new warnings with this change which mention about 32-bit > bit shifting then bitwise anding to a 64-bit variable. > The attached fixes the warnings Pushed, thanks. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-c

[COMMITTERS] pgsql: Suppress compiler warning.

2016-01-21 Thread Tom Lane
Suppress compiler warning. Given the limited range of i, these shifts should not cause any problem, but that apparently doesn't stop some compilers from whining about them. David Rowley Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d9b9289c837a98b78b948b597fabd9ab

Re: [COMMITTERS] pgsql: Improve index AMs' opclass validation procedures.

2016-01-21 Thread David Rowley
On 22 January 2016 at 13:47, Tom Lane wrote: > Improve index AMs' opclass validation procedures. > > The amvalidate functions added in commit 65c5fcd353a859da were on the > crude side. Improve them in a few ways: > > * Perform signature checking for operators and support functions. > > * Apply mo

[COMMITTERS] pgsql: Improve index AMs' opclass validation procedures.

2016-01-21 Thread Tom Lane
Improve index AMs' opclass validation procedures. The amvalidate functions added in commit 65c5fcd353a859da were on the crude side. Improve them in a few ways: * Perform signature checking for operators and support functions. * Apply more thorough checks for missing operators and functions, whe

[COMMITTERS] pgsql: Add defenses against putting expanded objects into Const nodes.

2016-01-21 Thread Tom Lane
Add defenses against putting expanded objects into Const nodes. Putting a reference to an expanded-format value into a Const node would be a bad idea for a couple of reasons. It'd be possible for the supposedly immutable Const to change value, if something modified the referenced variable ... in

[COMMITTERS] pgsql: Add defenses against putting expanded objects into Const nodes.

2016-01-21 Thread Tom Lane
Add defenses against putting expanded objects into Const nodes. Putting a reference to an expanded-format value into a Const node would be a bad idea for a couple of reasons. It'd be possible for the supposedly immutable Const to change value, if something modified the referenced variable ... in

[COMMITTERS] pgsql: Remove unused argument from ginInsertCleanup()

2016-01-21 Thread Fujii Masao
Remove unused argument from ginInsertCleanup() It's an oversight in commit dc943ad. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/38710a374ea9a29159ff12af7dbecd2959476447 Modified Files -- src/backend/access/gin/ginfast.c |8 ++-- src/backend/