[COMMITTERS] pgsql: Fix IsValidJsonNumber() to notice trailing non-alphanumeric garb

2016-02-02 Thread Tom Lane
Fix IsValidJsonNumber() to notice trailing non-alphanumeric garbage. Commit e09996ff8dee3f70 was one brick shy of a load: it didn't insist that the detected JSON number be the whole of the supplied string. This allowed inputs such as "2016-01-01" to be misdetected as valid JSON numbers. Per bug #

[COMMITTERS] pgsql: Fix IsValidJsonNumber() to notice trailing non-alphanumeric garb

2016-02-02 Thread Tom Lane
Fix IsValidJsonNumber() to notice trailing non-alphanumeric garbage. Commit e09996ff8dee3f70 was one brick shy of a load: it didn't insist that the detected JSON number be the whole of the supplied string. This allowed inputs such as "2016-01-01" to be misdetected as valid JSON numbers. Per bug #

[COMMITTERS] pgsql: Fix IsValidJsonNumber() to notice trailing non-alphanumeric garb

2016-02-02 Thread Tom Lane
Fix IsValidJsonNumber() to notice trailing non-alphanumeric garbage. Commit e09996ff8dee3f70 was one brick shy of a load: it didn't insist that the detected JSON number be the whole of the supplied string. This allowed inputs such as "2016-01-01" to be misdetected as valid JSON numbers. Per bug #

[COMMITTERS] pgsql: Fix IsValidJsonNumber() to notice trailing non-alphanumeric garb

2016-02-02 Thread Tom Lane
Fix IsValidJsonNumber() to notice trailing non-alphanumeric garbage. Commit e09996ff8dee3f70 was one brick shy of a load: it didn't insist that the detected JSON number be the whole of the supplied string. This allowed inputs such as "2016-01-01" to be misdetected as valid JSON numbers. Per bug #

Re: [COMMITTERS] pgsql: Add support for systemd service notifications

2016-02-02 Thread Tom Lane
Peter Eisentraut writes: > Add support for systemd service notifications ... btw, guaibasaurus thinks this broke the docs build. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://w

Re: [COMMITTERS] pgsql: Improve error reporting when location specified by postgres -D d

2016-02-02 Thread Tom Lane
Peter Eisentraut writes: > + if (configdir && stat(configdir, &stat_buf) != 0) > + { > + write_stderr("%s: could not access \"%s\": %s\n", > +progname, > +configdir, > +strerror(errno)); Perhaps "could not access directory ..."

[COMMITTERS] pgsql: Add support for systemd service notifications

2016-02-02 Thread Peter Eisentraut
Add support for systemd service notifications Insert sd_notify() calls at server start and stop for integration with systemd. This allows the use of systemd service units of type "notify", which greatly simplifies the systemd configuration. Reviewed-by: Pavel Stěhule Branch -- master Deta

[COMMITTERS] pgsql: Improve error reporting when location specified by postgres -D d

2016-02-02 Thread Peter Eisentraut
Improve error reporting when location specified by postgres -D does not exist Previously, the first error seen would be that postgresql.conf does not exist. But for the case where the whole directory does not exist, give an error message about that, together with a hint for how to create one. Br

[COMMITTERS] pgsql: Remove printQueryOpt.quote field.

2016-02-02 Thread Tom Lane
Remove printQueryOpt.quote field. This field was included in the original definition of the printQueryOpt struct in commit a45195a191eec367, but it was not used anywhere in that commit, nor since then. Spotted by Dickson S. Guedes. Branch -- master Details --- http://git.postgresql.org/

[COMMITTERS] pgsql: Don't test for system columns on join relations

2016-02-02 Thread Alvaro Herrera
Don't test for system columns on join relations create_foreignscan_plan needs to know whether any system columns are requested from a relation (this flag is needed by ForeignNext during execution). However, for join relations this is a pointless test, because it's not possible to request system c

[COMMITTERS] pgsql: Remove unnecessary "implementation of FOO operator" DESCR() entr

2016-02-02 Thread Tom Lane
Remove unnecessary "implementation of FOO operator" DESCR() entries. Apparently at least one committer hasn't gotten the word that these do not need to be maintained by hand, since initdb will create them automatically. Noted while fixing bug #13905. No catversion bump since the post-initdb state

[COMMITTERS] pgsql: Fix pg_description entries for jsonb_to_record() and jsonb_to_re

2016-02-02 Thread Tom Lane
Fix pg_description entries for jsonb_to_record() and jsonb_to_recordset(). All the other jsonb function descriptions refer to the arguments as being "jsonb", but these two said "json". Make it consistent. Per bug #13905 from Petru Florin Mihancea. No catversion bump --- we can't force one in th

[COMMITTERS] pgsql: Fix pg_description entries for jsonb_to_record() and jsonb_to_re

2016-02-02 Thread Tom Lane
Fix pg_description entries for jsonb_to_record() and jsonb_to_recordset(). All the other jsonb function descriptions refer to the arguments as being "jsonb", but these two said "json". Make it consistent. Per bug #13905 from Petru Florin Mihancea. No catversion bump --- we can't force one in th

[COMMITTERS] pgsql: Fix pg_description entries for jsonb_to_record() and jsonb_to_re

2016-02-02 Thread Tom Lane
Fix pg_description entries for jsonb_to_record() and jsonb_to_recordset(). All the other jsonb function descriptions refer to the arguments as being "jsonb", but these two said "json". Make it consistent. Per bug #13905 from Petru Florin Mihancea. No catversion bump --- we can't force one in th

[COMMITTERS] pgsql: Fix typo in comment

2016-02-02 Thread Magnus Hagander
Fix typo in comment Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/081f7fe11024d281e6aae0904a5ff03bfa6f0811 Modified Files -- src/bin/pg_basebackup/pg_recvlogical.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committe

[COMMITTERS] pgsql: Fix typo in comment

2016-02-02 Thread Magnus Hagander
Fix typo in comment Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/23f3cc36ed8188b0b8bf22daa4bb5b47d216c15d Modified Files -- src/bin/pg_basebackup/pg_recvlogical.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mail

[COMMITTERS] pgsql: Fix lossy KNN GiST when ordering operator returns non-float8 val

2016-02-02 Thread Teodor Sigaev
Fix lossy KNN GiST when ordering operator returns non-float8 value. KNN GiST with recheck flag should return to executor the same type as ordering operator, GiST detects this type by looking to return type of function which implements ordering operator. But occasionally detecting code works after

[COMMITTERS] pgsql: Fix lossy KNN GiST when ordering operator returns non-float8 val

2016-02-02 Thread Teodor Sigaev
Fix lossy KNN GiST when ordering operator returns non-float8 value. KNN GiST with recheck flag should return to executor the same type as ordering operator, GiST detects this type by looking to return type of function which implements ordering operator. But occasionally detecting code works after

[COMMITTERS] pgsql: Make all built-in lwlock tranche IDs fixed.

2016-02-02 Thread Robert Haas
Make all built-in lwlock tranche IDs fixed. This makes the values more stable, which seems like a good thing for anybody who needs to look at at them. Alexander Korotkov and Amit Kapila Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7191ce8bea0cb110a28faef178efa92b