[COMMITTERS] pgsql: Fix comments

2016-02-29 Thread Peter Eisentraut
Fix comments Some of these comments were copied and pasted without updating them, some of them were duplicates. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cc074bf6c1a5305a5e23067c6d9a377840add303 Modified Files --

[COMMITTERS] pgsql: UCS_to_most.pl: Make executable, for consistency with other scri

2016-02-29 Thread Peter Eisentraut
UCS_to_most.pl: Make executable, for consistency with other scripts Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9a3e06baa2e42a5018dcd6afda31255b4e772518 Modified Files -- src/backend/utils/mb/Unicode/UCS_to_most.pl | 0 1 file changed, 0

[COMMITTERS] pgsql: Add Unicode map generation scripts as rule prerequisites

2016-02-29 Thread Peter Eisentraut
Add Unicode map generation scripts as rule prerequisites That way, the rules will trigger when the scripts change. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bd6cf3f237c9aeb4dad1ac3ec2008c5768fe4c1b Modified Files --

[COMMITTERS] pgsql: Suppress scary-looking log messages from async-notify isolation

2016-02-29 Thread Tom Lane
Suppress scary-looking log messages from async-notify isolation test. I noticed that the async-notify test results in log messages like these: LOG: could not send data to client: Broken pipe FATAL: connection to client lost This is because it unceremoniously disconnects a client session that

[COMMITTERS] pgsql: Improve error message for rejecting RETURNING clauses with dropp

2016-02-29 Thread Tom Lane
Improve error message for rejecting RETURNING clauses with dropped columns. This error message was written with only ON SELECT rules in mind, but since then we also made RETURNING-clause targetlists go through the same logic. This means that you got a rather off-topic error message if you tried

[COMMITTERS] pgsql: Improve error message for rejecting RETURNING clauses with dropp

2016-02-29 Thread Tom Lane
Improve error message for rejecting RETURNING clauses with dropped columns. This error message was written with only ON SELECT rules in mind, but since then we also made RETURNING-clause targetlists go through the same logic. This means that you got a rather off-topic error message if you tried

[COMMITTERS] pgsql: Improve error message for rejecting RETURNING clauses with dropp

2016-02-29 Thread Tom Lane
Improve error message for rejecting RETURNING clauses with dropped columns. This error message was written with only ON SELECT rules in mind, but since then we also made RETURNING-clause targetlists go through the same logic. This means that you got a rather off-topic error message if you tried

[COMMITTERS] pgsql: Improve error message for rejecting RETURNING clauses with dropp

2016-02-29 Thread Tom Lane
Improve error message for rejecting RETURNING clauses with dropped columns. This error message was written with only ON SELECT rules in mind, but since then we also made RETURNING-clause targetlists go through the same logic. This means that you got a rather off-topic error message if you tried

[COMMITTERS] pgsql: Improve error message for rejecting RETURNING clauses with dropp

2016-02-29 Thread Tom Lane
Improve error message for rejecting RETURNING clauses with dropped columns. This error message was written with only ON SELECT rules in mind, but since then we also made RETURNING-clause targetlists go through the same logic. This means that you got a rather off-topic error message if you tried

[COMMITTERS] pgsql: Improve error message for rejecting RETURNING clauses with dropp

2016-02-29 Thread Tom Lane
Improve error message for rejecting RETURNING clauses with dropped columns. This error message was written with only ON SELECT rules in mind, but since then we also made RETURNING-clause targetlists go through the same logic. This means that you got a rather off-topic error message if you tried

[COMMITTERS] pgsql: Minor tweaks for new src/test/recovery

2016-02-29 Thread Alvaro Herrera
Minor tweaks for new src/test/recovery Author: Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5847397deca66fb4a4b3d2e0dcb3414dd5c4e180 Modified Files -- doc/src/sgml/install-windows.sgml | 7 --- src/test/README

[COMMITTERS] pgsql: Fix typos

2016-02-29 Thread Alvaro Herrera
Fix typos Author: Amit Langote Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/4ef26fff7b0e8e5b786887387bfa0ed67ea0ad29 Modified Files -- src/backend/replication/syncrep.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- Sent

[COMMITTERS] pgsql: Fix typos

2016-02-29 Thread Alvaro Herrera
Fix typos Author: Amit Langote Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/10b4852215a37915e55f034f919a6dc8bc72e988 Modified Files -- src/backend/replication/syncrep.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- Sent via

[COMMITTERS] pgsql: Fix typos

2016-02-29 Thread Alvaro Herrera
Fix typos Author: Amit Langote Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/0a3070baf3c48def1f7c46f57a6313adc26be4fa Modified Files -- src/backend/replication/syncrep.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- Sent

[COMMITTERS] pgsql: Fix typos

2016-02-29 Thread Alvaro Herrera
Fix typos Author: Amit Langote Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9ca3789191f80c6e6ac01c12171d4fba4c95f55d Modified Files -- src/backend/replication/syncrep.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- Sent

[COMMITTERS] pgsql: Fix typos

2016-02-29 Thread Alvaro Herrera
Fix typos Author: Amit Langote Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/0bd51dee6e9c15f9283224cb0a475c20b7ef3e86 Modified Files -- src/backend/replication/syncrep.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- Sent

[COMMITTERS] pgsql: Fix typos

2016-02-29 Thread Alvaro Herrera
Fix typos Author: Amit Langote Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/36d43f05109e944f431e85ff559727c411ab7089 Modified Files -- src/backend/replication/syncrep.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- Sent

[COMMITTERS] pgsql: doc: document MANPATH as /usr/local/pgsql/share/man

2016-02-29 Thread Alvaro Herrera
doc: document MANPATH as /usr/local/pgsql/share/man The docs were advising to use /usr/local/pgsql/man instead, but that's wrong. Reported-By: Slawomir Sudnik Backpatch-To: 9.1 Bug: #13894 Branch -- REL9_5_STABLE Details ---

[COMMITTERS] pgsql: doc: document MANPATH as /usr/local/pgsql/share/man

2016-02-29 Thread Alvaro Herrera
doc: document MANPATH as /usr/local/pgsql/share/man The docs were advising to use /usr/local/pgsql/man instead, but that's wrong. Reported-By: Slawomir Sudnik Backpatch-To: 9.1 Bug: #13894 Branch -- REL9_1_STABLE Details ---

[COMMITTERS] pgsql: doc: document MANPATH as /usr/local/pgsql/share/man

2016-02-29 Thread Alvaro Herrera
doc: document MANPATH as /usr/local/pgsql/share/man The docs were advising to use /usr/local/pgsql/man instead, but that's wrong. Reported-By: Slawomir Sudnik Backpatch-To: 9.1 Bug: #13894 Branch -- REL9_2_STABLE Details ---

[COMMITTERS] pgsql: doc: document MANPATH as /usr/local/pgsql/share/man

2016-02-29 Thread Alvaro Herrera
doc: document MANPATH as /usr/local/pgsql/share/man The docs were advising to use /usr/local/pgsql/man instead, but that's wrong. Reported-By: Slawomir Sudnik Backpatch-To: 9.1 Bug: #13894 Branch -- REL9_4_STABLE Details ---

[COMMITTERS] pgsql: doc: document MANPATH as /usr/local/pgsql/share/man

2016-02-29 Thread Alvaro Herrera
doc: document MANPATH as /usr/local/pgsql/share/man The docs were advising to use /usr/local/pgsql/man instead, but that's wrong. Reported-By: Slawomir Sudnik Backpatch-To: 9.1 Bug: #13894 Branch -- master Details ---

[COMMITTERS] pgsql: Make new isolationtester test more stable

2016-02-29 Thread Alvaro Herrera
Make new isolationtester test more stable The original coding of the test was relying too much on the ordering in which backends are awakened once an advisory lock which they wait for is released. Change the code so that each backend uses its own advisory lock instead, so that the output becomes

Re: [COMMITTERS] pgsql: Add isolationtester spec for old heapam.c bug

2016-02-29 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> guaibasaurus is not a particularly slow machine, and it's not using any >> special build flags AFAICT. So I'm not sure what to make of this case, >> except that it proves the timing problem can manifest on normal builds. >

Re: [COMMITTERS] pgsql: Add isolationtester spec for old heapam.c bug

2016-02-29 Thread Alvaro Herrera
Tom Lane wrote: > I wrote: > > Alvaro Herrera writes: > >> Add isolationtester spec for old heapam.c bug > > > Hmmm > > > http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=spoonbill=2016-02-27%2000%3A00%3A06 > > > This failure looks a lot like the

Re: [COMMITTERS] pgsql: Add isolationtester spec for old heapam.c bug

2016-02-29 Thread Tom Lane
I wrote: > Alvaro Herrera writes: >> Add isolationtester spec for old heapam.c bug > Hmmm > http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=spoonbill=2016-02-27%2000%3A00%3A06 > This failure looks a lot like the timing-related problems I was chasing > last

[COMMITTERS] pgsql: Remove useless unary plus.

2016-02-29 Thread Tom Lane
Remove useless unary plus. It's harmless, but might confuse readers. Seems to have been introduced in 6bc8ef0b7f1f1df3. Back-patch, just to avoid cosmetic cross-branch differences. Amit Langote Branch -- REL9_5_STABLE Details ---

[COMMITTERS] pgsql: Remove useless unary plus.

2016-02-29 Thread Tom Lane
Remove useless unary plus. It's harmless, but might confuse readers. Seems to have been introduced in 6bc8ef0b7f1f1df3. Back-patch, just to avoid cosmetic cross-branch differences. Amit Langote Branch -- master Details ---

[COMMITTERS] pgsql: Remove useless unary plus.

2016-02-29 Thread Tom Lane
Remove useless unary plus. It's harmless, but might confuse readers. Seems to have been introduced in 6bc8ef0b7f1f1df3. Back-patch, just to avoid cosmetic cross-branch differences. Amit Langote Branch -- REL9_4_STABLE Details ---

[COMMITTERS] pgsql: Fix build under OPTIMIZER_DEBUG.

2016-02-29 Thread Tom Lane
Fix build under OPTIMIZER_DEBUG. In commit 19a541143a09c067 I replaced RelOptInfo.width with RelOptInfo.reltarget.width, but I missed updating debug_print_rel() for that because it's not compiled by default. Reported by Salvador Fandino, patch by Michael Paquier. Branch -- master Details

[COMMITTERS] pgsql: Fix incorrect varlevelsup in security_barrier_replace_vars().

2016-02-29 Thread Dean Rasheed
Fix incorrect varlevelsup in security_barrier_replace_vars(). When converting an RTE with securityQuals into a security barrier subquery RTE, ensure that the Vars in the new subquery's targetlist all have varlevelsup = 0 so that they correctly refer to the underlying base relation being wrapped.

[COMMITTERS] pgsql: Fix incorrect varlevelsup in security_barrier_replace_vars().

2016-02-29 Thread Dean Rasheed
Fix incorrect varlevelsup in security_barrier_replace_vars(). When converting an RTE with securityQuals into a security barrier subquery RTE, ensure that the Vars in the new subquery's targetlist all have varlevelsup = 0 so that they correctly refer to the underlying base relation being wrapped.