[COMMITTERS] pgsql: Fix stupid omission in c4901a1e.

2016-03-18 Thread Andres Freund
Fix stupid omission in c4901a1e. Reported-By: Jeff Janes Discussion: CAMkU=1zgxrewoyacrp_chadeb+dpgpvykbyscj+6xp9gcov...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6eb2be15b5d24b98d334a9dd637f0edb37e2eb7e Modified Files -- src/backend

[COMMITTERS] pgsql: docs: Fix typo'd brin_summarize_new_values

2016-03-18 Thread Alvaro Herrera
docs: Fix typo'd brin_summarize_new_values I wrote "brin_summarize_new_pages" instead, in docs as well as in the commit message of commit ac443d1034d9. Bug: #14030 Reported-By: Chris Pacejo Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/853d40b60e593d81c01c3

Re: [COMMITTERS] pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()

2016-03-18 Thread Tom Lane
Teodor Sigaev writes: > GUC variable pg_trgm.similarity_threshold insead of set_limit() If that's to be an actual GUC variable, it's not okay for set_limit() to just do this: similarity_threshold = nlimit; It should go through SetConfigOption(); compare for example tsa_set_curcfg_byname

[COMMITTERS] pgsql: fix typo in comment

2016-03-18 Thread Teodor Sigaev
fix typo in comment Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ce91b9209f221f9555d340b40e02aaf8cdc777e4 Modified Files -- contrib/unaccent/generate_unaccent_rules.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers

[COMMITTERS] pgsql: Another comment update.

2016-03-18 Thread Robert Haas
Another comment update. I thought this was in my last commit, but I goofed. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f2b74b01d4a18241bd7560e74d527f3ba42d4738 Modified Files -- src/backend/postmaster/pgstat.c | 4 ++-- 1 file changed, 2 insertions(+

[COMMITTERS] pgsql: Fix "pg_bench -C -M prepared".

2016-03-18 Thread Tom Lane
Fix "pg_bench -C -M prepared". This didn't work because when we dropped and re-established a database connection, we did not bother to reset session-specific state such as the statements-are-prepared flags. The st->prepared[] array certainly needs to be flushed, and I cleared a couple of other fi

[COMMITTERS] pgsql: Fix missed update in _readForeignScan().

2016-03-18 Thread Tom Lane
Fix missed update in _readForeignScan(). Blatant fail in 0bf3ae88af330496517722e391e7c975e6bad219. Caught by buildfarm member mandrill. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/07aed46a6b3994508e5674301c85ebf5807905ea Modified Files -- src/backend

[COMMITTERS] pgsql: Use yylex_init not yylex_init_extra().

2016-03-18 Thread Tom Lane
Use yylex_init not yylex_init_extra(). Older versions of flex don't have the latter. Per buildfarm. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ff0a7e6167f475672d82d1cd7cd0d5e735154c4d Modified Files -- src/bin/psql/psqlscan.l | 4 +++- 1 file change

[COMMITTERS] pgsql: Suppress FLEX_NO_BACKUP check for psqlscanslash.l.

2016-03-18 Thread Tom Lane
Suppress FLEX_NO_BACKUP check for psqlscanslash.l. The existing infrastructure for FLEX_NO_BACKUP doesn't work reliably when two lexers are built in parallel in the same directory. We can probably fix that, but as a short-term workaround, just don't make the check for psqlscanslash.l. Per buildf

[COMMITTERS] pgsql: Split psql's lexer into two separate .l files for SQL and backsl

2016-03-18 Thread Tom Lane
Split psql's lexer into two separate .l files for SQL and backslash cases. This gets us to a point where psqlscan.l can be used by other frontend programs for the same purpose psql uses it for, ie to detect when it's collected a complete SQL command from input that is divided across line boundarie

[COMMITTERS] pgsql: Fix "pg_bench -C -M prepared".

2016-03-18 Thread Tom Lane
Fix "pg_bench -C -M prepared". This didn't work because when we dropped and re-established a database connection, we did not bother to reset session-specific state such as the statements-are-prepared flags. The st->prepared[] array certainly needs to be flushed, and I cleared a couple of other fi

[COMMITTERS] pgsql: Be more careful about out-of-range dates and timestamps.

2016-03-18 Thread Tom Lane
Be more careful about out-of-range dates and timestamps. Tighten the semantics of boundary-case timestamptz so that we allow timestamps >= '4714-11-24 00:00+00 BC' and < 'ENDYEAR-01-01 00:00+00 AD' exactly, no more and no less, but it is allowed to enter timestamps within that range using non-GMT

[COMMITTERS] pgsql: Fix a typo

2016-03-18 Thread Teodor Sigaev
Fix a typo Erik Rijkers Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/61d2ebdbf9155d80f83281d8c5729c8f8f0949bc Modified Files -- doc/src/sgml/func.sgml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mail

Re: [COMMITTERS] pgsql: Convert psql's flex lexer to be re-entrant, and make it compile

2016-03-18 Thread Michael Paquier
On Sat, Mar 19, 2016 at 10:22 AM, Tom Lane wrote: > Also, stop compiling psqlscan as part of mainloop.c, and make it a > standalone build target instead. This is a lot cleaner than before, though > it doesn't really change much in practice as of this commit. (I'm not sure > whether the MSVC buil

[COMMITTERS] pgsql: Various minor corrections of and improvements to comments.

2016-03-18 Thread Robert Haas
Various minor corrections of and improvements to comments. Aleksander Alekseev Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2d8a1e22b109680204cb015a30e5a733a233ed64 Modified Files -- contrib/pg_trgm/trgm_gin.c | 4 ++-- contrib/pg_trgm/trgm_op