Refer to a TOKEN_USER payload as a "token user," not as a "user token".
This corrects messages for can't-happen errors. The corresponding "user
token" appears in the HANDLE argument of GetTokenInformation().
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/c22650cd64
Copyedit comments and documentation.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/4ad6f13500cd9a3ca0652e43232f9515319e55e2
Modified Files
--
config/c-compiler.m4 | 2 +-
contrib/pgstattuple/pgstatapprox.c| 2 +-
doc/src/sgm
On 2016-04-01 14:36, Erik Rijkers wrote:
On 2016-04-01 15:49, Teodor Sigaev wrote:
Bloom index contrib module
doc/src/sgml/bloom.sgml | 218 ++
The size of example table (in bloom.sgml):
CREATE TABLE tbloom AS
SELECT
random()::int as i1,
random()::int as i2
test_slot_timelines: Fix alternate expected output
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/f07d18b6e94da6ef93dc4e00096f1e7542814fdb
Modified Files
--
src/test/modules/test_slot_timelines/expected/load_extension_1.out | 2 +-
1 file changed, 1 inser
Omit null rows when setting the threshold for what's a most-common value.
As with the previous patch, large numbers of null rows could skew this
calculation unfavorably, causing us to discard values that have a
legitimate claim to be MCVs, since our definition of MCV is that it's
most common among
pgbench: Remove unused parameter
For some reason this parameter was introduced as unused in 3da0dfb4b146,
and has never been used for anything. Remove it.
Author: Fabien Coelho
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/5cb882675ae239db9d00b16a9467c4f900fb10b6
Omit null rows when applying the Haas-Stokes estimator for ndistinct.
Previously, we included null rows in the values of n and N that went
into the formula, which amounts to considering null as a value in its
own right; but the d and f1 values do not include nulls. This is
inconsistent, and it co
Fix logical_decoding_timelines test crashes
In the test_slot_timelines test module, we were abusing passing NULL
values which was received as zeroes in x86, but this breaks in ARM
(buildfarm member hamster) by crashing instead. Fix the breakage by
marking these functions as STRICT; the InvalidXid
Fixes in bloom contrib module missed during review
- macroses llike (var & FLAG) are changed to ((var & FLAG) != 0)
- do not copy uninitialized part of notFullPage array to page
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/27f3bbfad46e694fcbf2fa39cb621110d46ec95c
Alvaro Herrera writes:
> Alvaro Herrera wrote:
>> Tom Lane wrote:
>>> Actually, I think the general convention is to NOT quote type names
>>> in error messages.
>> Ok, I'll change it.
> Done.
Thanks. Should we make a push to get rid of hard-wired type names in
other messages? There's still qu
Teodor Sigaev writes:
> Bloom index contrib module
skink provided some pretty suggestive evidence about why this
is unstable:
==32446== VALGRINDERROR-BEGIN
==32446== Conditional jump or move depends on uninitialised value(s)
==32446==at 0x4E2E71: writeDelta (generic_xlog.c:137)
==32446==
Alvaro Herrera wrote:
> Tom Lane wrote:
> > Actually, I think the general convention is to NOT quote type names
> > in error messages. Certainly that's so when using format_type_be()
> > to produce a name for a not-known-at-compile-time type. I would
> > argue that these messages should be writt
Type names should not be quoted
Our actual convention, contrary to what I said in 59a2111b23f, is not to
quote type names, as evidenced by unquoted use of format_type_be()
result value in error messages. Remove quotes from recently tweaked
messages accordingly.
Per note from Tom Lane
Branch
---
Get rid of minus zero in box regression test.
Commit acdf2a8b added a test case involving minus zero as a box endpoint.
This is not very portable, as evidenced by the several older buildfarm
members that are failing on the test because they print minus zero as
just "0". If there were any signific
Fix oversight in getParamDescriptions(), and improve comments.
When getParamDescriptions was changed to handle out-of-memory better
by cribbing error recovery logic from getRowDescriptions/getAnotherTuple,
somebody omitted to copy the stanza about checking for excess data in
the message. But you
Fix English in bloom module documentation
Author: Erik Rijkers
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/a361c22ebfa8c87683f07f83f55a8456e7892e6d
Modified Files
--
doc/src/sgml/bloom.sgml | 72 ++---
1 fil
Several non-x86 members of pgbuildfarm aren't happy with it, we are
investigating the problem
Teodor Sigaev wrote:
Bloom index contrib module
Module provides new access method. It is actually a simple Bloom filter
implemented as pgsql's index. It could give some benefits on search
with large n
On 2016-04-01 15:49, Teodor Sigaev wrote:
Bloom index contrib module
Module provides new access method. It is actually a simple Bloom filter
implemented as pgsql's index. It could give some benefits on search
with large number of columns.
doc/src/sgml/bloom.sgml | 218 +
Bloom index contrib module
Module provides new access method. It is actually a simple Bloom filter
implemented as pgsql's index. It could give some benefits on search
with large number of columns.
Module is a single way to test generic WAL interface committed earlier.
Author: Teodor Sigaev, Alex
Fix typo in generic wal docs
Markus Nullmeier
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/4e56e5a6de766a6983ce723b1945d68a4e098a06
Modified Files
--
doc/src/sgml/generic-wal.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
Sent via
Add Generic WAL interface
This interface is designed to give an access to WAL for extensions which
could implement new access method, for example. Previously it was
impossible because restoring from custom WAL would need to access system
catalog to find a redo custom function. This patch suggests
21 matches
Mail list logo
