Re: [COMMITTERS] pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

2016-04-03 Thread Andres Freund
On 2016-04-04 08:42:02 +0200, Andres Freund wrote: > On 2016-04-04 07:31:46 +0100, Simon Riggs wrote: > > On 4 April 2016 at 07:24, Andres Freund wrote: > > > > > On 2016-04-04 06:19:04 +, Simon Riggs wrote: > > > > Avoid archiving XLOG_RUNNING_XACTS on idle server > > > > > > > > If archive_

Re: [COMMITTERS] pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

2016-04-03 Thread Andres Freund
On 2016-04-04 07:31:46 +0100, Simon Riggs wrote: > On 4 April 2016 at 07:24, Andres Freund wrote: > > > On 2016-04-04 06:19:04 +, Simon Riggs wrote: > > > Avoid archiving XLOG_RUNNING_XACTS on idle server > > > > > > If archive_timeout > 0 we should avoid logging XLOG_RUNNING_XACTS if > > idl

Re: [COMMITTERS] pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

2016-04-03 Thread Simon Riggs
On 4 April 2016 at 07:24, Andres Freund wrote: > On 2016-04-04 06:19:04 +, Simon Riggs wrote: > > Avoid archiving XLOG_RUNNING_XACTS on idle server > > > > If archive_timeout > 0 we should avoid logging XLOG_RUNNING_XACTS if > idle. > > > > Bug 13685 reported by Laurence Rowe, investigated in

Re: [COMMITTERS] pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

2016-04-03 Thread Michael Paquier
On Mon, Apr 4, 2016 at 3:24 PM, Andres Freund wrote: > On 2016-04-04 06:19:04 +, Simon Riggs wrote: >> Avoid archiving XLOG_RUNNING_XACTS on idle server >> >> If archive_timeout > 0 we should avoid logging XLOG_RUNNING_XACTS if idle. >> >> Bug 13685 reported by Laurence Rowe, investigated in d

Re: [COMMITTERS] pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

2016-04-03 Thread Andres Freund
On 2016-04-04 06:19:04 +, Simon Riggs wrote: > Avoid archiving XLOG_RUNNING_XACTS on idle server > > If archive_timeout > 0 we should avoid logging XLOG_RUNNING_XACTS if idle. > > Bug 13685 reported by Laurence Rowe, investigated in detail by Michael > Paquier, > though this is not his propo

[COMMITTERS] pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

2016-04-03 Thread Simon Riggs
Avoid archiving XLOG_RUNNING_XACTS on idle server If archive_timeout > 0 we should avoid logging XLOG_RUNNING_XACTS if idle. Bug 13685 reported by Laurence Rowe, investigated in detail by Michael Paquier, though this is not his proposed fix. 20151016203031.3019.72...@wrigleys.postgresql.org Simp

Re: [COMMITTERS] pgsql: Copyedit comments and documentation.

2016-04-03 Thread David Rowley
On 4 April 2016 at 12:11, Noah Misch wrote: > On Mon, Apr 04, 2016 at 10:55:03AM +1200, David Rowley wrote: >> On 2 April 2016 at 14:56, Noah Misch wrote: >> > Copyedit comments and documentation. >> >> ... >> > src/backend/storage/freespace/freespace.c | 4 ++-- >> >> - * Returns the physical bl

Re: [COMMITTERS] pgsql: Copyedit comments and documentation.

2016-04-03 Thread Noah Misch
On Mon, Apr 04, 2016 at 10:55:03AM +1200, David Rowley wrote: > On 2 April 2016 at 14:56, Noah Misch wrote: > > Copyedit comments and documentation. > > ... > > src/backend/storage/freespace/freespace.c | 4 ++-- > > - * Returns the physical block number an FSM page > + * Returns the physical bl

Re: [COMMITTERS] pgsql: Copyedit comments and documentation.

2016-04-03 Thread David Rowley
On 4 April 2016 at 10:55, David Rowley wrote: > It appears that the tender is still open on "a SQL" vs "an SQL", but > that'll likely be down to people pronouncing SQL as either > "es-que-el", or "squeal" Of course I mean "sequel". -- David Rowley http://www.2ndQuadrant.com/

Re: [COMMITTERS] pgsql: Copyedit comments and documentation.

2016-04-03 Thread David Rowley
On 2 April 2016 at 14:56, Noah Misch wrote: > Copyedit comments and documentation. ... > src/backend/storage/freespace/freespace.c | 4 ++-- - * Returns the physical block number an FSM page + * Returns the physical block number of a FSM page I'm not sure I want to start a debate over such a tr

[COMMITTERS] pgsql: Clean up dubious code in contrib/seg.

2016-04-03 Thread Tom Lane
Clean up dubious code in contrib/seg. The restore() function assumed that the result of sprintf() with %e format would necessarily contain an 'e', which is false: what if the supplied number is an infinity or NaN? If that did happen, we'd get a null-pointer-dereference core dump. The case appear

[COMMITTERS] pgsql: Fix contrib/bloom to not fail under CLOBBER_CACHE_ALWAYS.

2016-04-03 Thread Tom Lane
Fix contrib/bloom to not fail under CLOBBER_CACHE_ALWAYS. The code was supposing that rd_amcache wouldn't disappear from under it during a scan; which is wrong. Copy the data out of the relcache rather than trying to reference it there. Branch -- master Details --- http://git.postgresql

[COMMITTERS] pgsql: Clean up some stuff in new contrib/bloom module.

2016-04-03 Thread Tom Lane
Clean up some stuff in new contrib/bloom module. Coverity complained about implicit sign-extension in the BloomPageGetFreeSpace macro, probably because sizeOfBloomTuple isn't wide enough for size calculations. No overflow is really possible as long as maxoff and sizeOfBloomTuple are small enough

[COMMITTERS] pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM in all cases

2016-04-03 Thread Simon Riggs
Avoid pin scan for replay of XLOG_BTREE_VACUUM in all cases Replay of XLOG_BTREE_VACUUM during Hot Standby was previously thought to require complex interlocking that matched the requirements on the master. This required an O(N) operation that became a significant problem with large indexes, causi

[COMMITTERS] pgsql: Add psql \errverbose command to see last server error at full ve

2016-04-03 Thread Tom Lane
Add psql \errverbose command to see last server error at full verbosity. Often, upon getting an unexpected error in psql, one's first wish is that the verbosity setting had been higher; for example, to be able to see the schema-name field or the server code location info. Up to now the only way h

[COMMITTERS] pgsql: Add libpq support for recreating an error message with different

2016-04-03 Thread Tom Lane
Add libpq support for recreating an error message with different verbosity. Often, upon getting an unexpected error in psql, one's first wish is that the verbosity setting had been higher; for example, to be able to see the schema-name field or the server code location info. Up to now the only wa

Re: [COMMITTERS] pgsql: Make all the declarations of WaitEventSetWaitBlock be marked "in

2016-04-03 Thread Andres Freund
On 2016-04-02 17:55:52 +, Tom Lane wrote: > Make all the declarations of WaitEventSetWaitBlock be marked "inline". > > The inconsistency here triggered compiler warnings on some buildfarm > members, and it's surely pretty pointless. Thanks for taking care of this one! -- Sent via pgsql-com